Archived issue #0024958
Numerous ShapeFix_IntersectionTool code fixes
Description
This ticket is a common ticket for the following issues in ShapeFix_IntersectionTool:
1. SplitEdge makes nothing for the degenerated edges with SameParameter flag, because degenerated has no 3d curve. Therefore the degenerated edge should be always processed as an edge without SameParameter flag.
2. CutEdge always returns true even if no cuts were done.
3. UnionVertexes always returns true even if nothing is done.
4. FixSelfIntersectingWire doesn't take into account the return values of sub-functions, what results in wrong return flags and wrong further processing.
1. SplitEdge makes nothing for the degenerated edges with SameParameter flag, because degenerated has no 3d curve. Therefore the degenerated edge should be always processed as an edge without SameParameter flag.
2. CutEdge always returns true even if no cuts were done.
3. UnionVertexes always returns true even if nothing is done.
4. FixSelfIntersectingWire doesn't take into account the return values of sub-functions, what results in wrong return flags and wrong further processing.
Public activity
18 archived notes
Participants are labeled by their role within this record.
Please, review the patch
Branch CR24958 is ready to be tested.
Branch CR24958_1 was created (contains only 24958 commit).
Dear BugMaster,
Branch CR24958_1 (and products from GIT master) was compiled on Linux, Windows platforms and tested.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 17 (17 on master)
Windows: 0 (0 on master)
products component :
Linux: 11 (11 on master)
Windows: 2 (2 on master)
Regressions/Differences:
de iges_1 L7 L8 M1 P5 R8
de iges_2 A9 B6 F4 G1
de iges_3 B2
de step_2 F4
de step_3 E6
de step_5 A1
http://occt-tests/CR24958-1-master-occt/Debian60-64/summary.html
http://occt-tests/CR24958-1-master-occt/Windows-32-VC9/summary.html
sat doc_2 F9 - in PRODUCTS
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 356228100 / 356360844
Total CPU difference: 52629.43999999985 / 50334.88000000012
Testing on Windows:
Total MEMORY difference: 375761556 / 380552036
Total CPU difference: 41415.796875 / 36707.09375
There are no differences in images found by testdiff.
Branch CR24958_1 (and products from GIT master) was compiled on Linux, Windows platforms and tested.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 17 (17 on master)
Windows: 0 (0 on master)
products component :
Linux: 11 (11 on master)
Windows: 2 (2 on master)
Regressions/Differences:
de iges_1 L7 L8 M1 P5 R8
de iges_2 A9 B6 F4 G1
de iges_3 B2
de step_2 F4
de step_3 E6
de step_5 A1
http://occt-tests/CR24958-1-master-occt/Debian60-64/summary.html
http://occt-tests/CR24958-1-master-occt/Windows-32-VC9/summary.html
sat doc_2 F9 - in PRODUCTS
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 356228100 / 356360844
Total CPU difference: 52629.43999999985 / 50334.88000000012
Testing on Windows:
Total MEMORY difference: 375761556 / 380552036
Total CPU difference: 41415.796875 / 36707.09375
There are no differences in images found by testdiff.
Can somebody please provide me with summary.html files at least. The models, I think, aren't available.
Dmitry, the differences reported are in number of entities resulting from import from IGES and STEP, thus having data files is necessary for analysis. We will have a look at this.
Irina, please have a look at the reported differences.
Differences were analyzed and all of them are not regressions.
The only problem was with step_3 E6(killed by CPU limit). But the cause in periodic normalization of BSpline surface, not in current fix.
Periodic normalization was optimized and pushed into branch CR24958_2.
Dear GKA,
Please review.
The only problem was with step_3 E6(killed by CPU limit). But the cause in periodic normalization of BSpline surface, not in current fix.
Periodic normalization was optimized and pushed into branch CR24958_2.
Dear GKA,
Please review.
Branch CR24958_2 is ready to be tested.
Dear BugMaster,
Branch CR24958_2 (and products from GIT master) was compiled on Linux, MacOS and Windows platforms and tested.
[revision removed]
Number of compiler warnings:
occt component:
Linux: 16 (16 on master)
Windows: 0 (0 on master)
MacOS: 200 (200 on master)
products component :
Linux: 11 (11 on master)
Windows: 2 (2 on master)
Regressions/Differences:
Additional regression to previously reported: sat - doc_3 (003) - B3
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 345033996 / 344928120
Total CPU difference: 50688.97999999992 / 49969.979999999865
Testing on Windows:
Total MEMORY difference: 374100332 / 374590944
Total CPU difference: 38549.171875 / 38047.34375
Branch CR24958_2 (and products from GIT master) was compiled on Linux, MacOS and Windows platforms and tested.
[revision removed]
Number of compiler warnings:
occt component:
Linux: 16 (16 on master)
Windows: 0 (0 on master)
MacOS: 200 (200 on master)
products component :
Linux: 11 (11 on master)
Windows: 2 (2 on master)
Regressions/Differences:
Additional regression to previously reported: sat - doc_3 (003) - B3
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 345033996 / 344928120
Total CPU difference: 50688.97999999992 / 49969.979999999865
Testing on Windows:
Total MEMORY difference: 374100332 / 374590944
Total CPU difference: 38549.171875 / 38047.34375
The problem was in cutting edge into parts one of which is too small (< Precision::Confusion())
Branch CR24958_2 is ready to be reviewed.
Dear GKA,
Please review.
Branch CR24958_2 is ready to be reviewed.
Dear GKA,
Please review.
Branch CR24958_2 is ready to be tested.
Dear BugMaster,
Branch CR24958_2 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 16 (16 on master)
Windows: 0 (0 on master)
MacOS: 200 (203 on master)
products component :
Linux: 11 (11 on master)
Windows: 2 (2 on master)
Regressions/Differences:
http://occt-tests/CR24958-2-master-occt/Debian60-64/summary.html
http://occt-tests/CR24958-2-master-occt/Windows-32-VC9/summary.html
de iges_1(001) L7, L8, P5, R8
de iges_2(002) A9, B6, G1
de iges_3(003) B2
de step_2(005) F4
de step_3(006) E6
de step_5(008) A1
http://jenkins-test-02.nnov.opencascade.com:8080/user/mnt/my-views/view/CR24958_2/job/mnt-CR24958_2-master_products_tests_linux_sat_start/label=kazbex,tests_group=sat,tests_subgroup=006/3/HTML_Report/
http://jenkins-test-02.nnov.opencascade.com:8080/user/mnt/my-views/view/CR24958_2/job/mnt-CR24958_2-master_products_tests_windows_sat_start/label=sixtex,tests_group=sat,tests_subgroup=006/2/HTML_Report/
sat doc_6(006) F9
http://jenkins-test-02.nnov.opencascade.com:8080/user/mnt/my-views/view/CR24958_2/job/mnt-CR24958_2-master_products_tests_linux_sat_start/3/label=kazbex,tests_group=sat,tests_subgroup=009/HTML_Report/
sat read_parallel(009) A2
http://jenkins-test-02.nnov.opencascade.com:8080/user/mnt/my-views/view/CR24958_2/job/mnt-CR24958_2-master_products_tests_linux_sat_start/3/label=kazbex,tests_group=sat,tests_subgroup=009/HTML_Report/
sat read_parallel(009) A3
http://jenkins-test-02.nnov.opencascade.com:8080/user/mnt/my-views/view/CR24958_2/job/mnt-CR24958_2-master_products_tests_windows_sat_start/label=sixtex,tests_group=sat,tests_subgroup=005/2/HTML_Report/
sat doc_5(005) H6 - Improvement
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 345748032 / 345940280
Total CPU difference: 51307.920000000195 / 50407.420000000006
Testing on Windows:
Total MEMORY difference: 374042036 / 374639012
Total CPU difference: 37061.09375 / 36470.625
There are no differences in images found by testdiff.
Branch CR24958_2 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 16 (16 on master)
Windows: 0 (0 on master)
MacOS: 200 (203 on master)
products component :
Linux: 11 (11 on master)
Windows: 2 (2 on master)
Regressions/Differences:
http://occt-tests/CR24958-2-master-occt/Debian60-64/summary.html
http://occt-tests/CR24958-2-master-occt/Windows-32-VC9/summary.html
de iges_1(001) L7, L8, P5, R8
de iges_2(002) A9, B6, G1
de iges_3(003) B2
de step_2(005) F4
de step_3(006) E6
de step_5(008) A1
http://jenkins-test-02.nnov.opencascade.com:8080/user/mnt/my-views/view/CR24958_2/job/mnt-CR24958_2-master_products_tests_linux_sat_start/label=kazbex,tests_group=sat,tests_subgroup=006/3/HTML_Report/
http://jenkins-test-02.nnov.opencascade.com:8080/user/mnt/my-views/view/CR24958_2/job/mnt-CR24958_2-master_products_tests_windows_sat_start/label=sixtex,tests_group=sat,tests_subgroup=006/2/HTML_Report/
sat doc_6(006) F9
http://jenkins-test-02.nnov.opencascade.com:8080/user/mnt/my-views/view/CR24958_2/job/mnt-CR24958_2-master_products_tests_linux_sat_start/3/label=kazbex,tests_group=sat,tests_subgroup=009/HTML_Report/
sat read_parallel(009) A2
http://jenkins-test-02.nnov.opencascade.com:8080/user/mnt/my-views/view/CR24958_2/job/mnt-CR24958_2-master_products_tests_linux_sat_start/3/label=kazbex,tests_group=sat,tests_subgroup=009/HTML_Report/
sat read_parallel(009) A3
http://jenkins-test-02.nnov.opencascade.com:8080/user/mnt/my-views/view/CR24958_2/job/mnt-CR24958_2-master_products_tests_windows_sat_start/label=sixtex,tests_group=sat,tests_subgroup=005/2/HTML_Report/
sat doc_5(005) H6 - Improvement
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 345748032 / 345940280
Total CPU difference: 51307.920000000195 / 50407.420000000006
Testing on Windows:
Total MEMORY difference: 374042036 / 374639012
Total CPU difference: 37061.09375 / 36470.625
There are no differences in images found by testdiff.
Dear MKV,
OCCT tests are not regressions, but right behavior after initial fix.
sat doc_6 F9:
also not a regression (difference in number of warnings during reading is right result of last fix)
sat read_parallel A2, A3:
I can't reproduce them. Branch CR24958_2 was tested on squeezex2 and results were OK (see attached screen of draw Attachment 1 (PNG))
sat doc_5 H6 (impovement) isn't reproduced too.
Could you please check are regressions sat read_parallel A2, A3 result of this fix?
OCCT tests are not regressions, but right behavior after initial fix.
sat doc_6 F9:
also not a regression (difference in number of warnings during reading is right result of last fix)
sat read_parallel A2, A3:
I can't reproduce them. Branch CR24958_2 was tested on squeezex2 and results were OK (see attached screen of draw Attachment 1 (PNG))
sat doc_5 H6 (impovement) isn't reproduced too.
Could you please check are regressions sat read_parallel A2, A3 result of this fix?
Dear BugMaster,
following test cases are corrected and pushed to branch CR24958_2 of occt git-repository
de iges_1(001) L7, L8, P5, R8
de iges_2(002) A9, B6, G1
de iges_3(003) B2
de step_2(005) F4
de step_3(006) E6
de step_5(008) A1
following test case was corrected and pushed to new branch CR24958_2 of products git-repository
sat doc_6(006) F9
following test cases are non stable test cases
sat doc_5(005) H6
sat read_parallel(009) A2, A3
following test cases are corrected and pushed to branch CR24958_2 of occt git-repository
de iges_1(001) L7, L8, P5, R8
de iges_2(002) A9, B6, G1
de iges_3(003) B2
de step_2(005) F4
de step_3(006) E6
de step_5(008) A1
following test case was corrected and pushed to new branch CR24958_2 of products git-repository
sat doc_6(006) F9
following test cases are non stable test cases
sat doc_5(005) H6
sat read_parallel(009) A2, A3
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]