Archived issue #0025088

Revert or change API of BRepMesh_IncrementalMesh to prevent possible errors occurred due to changed order of parameters

Open CASCADEOCCT:Meshclosed10 public notes

Search issues

Description

Revert or change API of BRepMesh_IncrementalMesh to prevent possible errors occurred due to changed order of parameters.
According to note posted by ABV (#0025039)

Public activity

10 archived notes

Participants are labeled by their role within this record.

01Commenter 3
Branch [archived branch] has been created by Author.

[revision removed]
02Author
changes have been pushed to OCCT and Products repositories, branch CR25088.
Please review.
03Commenter 3
Branch [archived branch] has been updated by Author.

[revision removed]
04Commenter 3
Branch [archived branch] has been created by Author.

[revision removed]
05Author
Branch CR25088_1 is ready to be reviewed.
06Commenter 6
No remarks, please test
07Commenter 3
Branch [archived branch] has been updated forcibly by Participant.

[revision removed]
08Commenter 8
Dear Commenter 1,

Branch CR25088_1 from occt git-repository and branch CR25088_1 from products git-repository was compiled on Linux, MacOS and Windows platforms and tested.
[revision removed]
[revision removed]

Number of compiler warnings:

occt component :
Linux: 15 (15 on master)
Windows: 0 (0 on master)
MacOS: 196 (196 on master)

products component :
Linux: 11 (11 on master)
Windows: 1 (1 on master)

Regressions/Differences:
No regressions/differences

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 350618372 / 351832620
Total CPU difference: 46605.589999999946 / 46199.39000000001

Testing on Windows:
Total MEMORY difference: 239222540 / 239171960
Total CPU difference: 33237.140625 / 35090.21875

There are no differences in images found by testdiff.
09Commenter 3
Branch [archived branch] has been deleted by Participant.

[revision removed]
10Commenter 3
Branch [archived branch] has been deleted by Participant.

[revision removed]

Related records