STEP Reader - allow GEOMETRIC_SET entity to accept non-geometric children

Branch [archived branch] has been created by Author.

[revision removed]


This branch includes the following new commits:

       new 13eaefe 0025166: Allow GEOMETRIC_SET entity to accept GeometricRepresentationItem children


Detailed log of new commits:

[revision removed]
Author: razmyslovich
Date: Tue Aug 19 12:38:51 2014 +0200

    0025166: Allow GEOMETRIC_SET entity to accept GeometricRepresentationItem children

The feature is committed. Please, review it

--- a/src/StepToTopoDS/StepToTopoDS_Builder.cdl
+++ b/src/StepToTopoDS/StepToTopoDS_Builder.cdl
@@ -34,10 +34,11 @@ uses
-    NMTool                      from StepToTopoDS
+    NMTool                      from StepToTopoDS,
+    ActorRead                   from STEPControl

it looks like packages StepToTopoDS and STEPControl will have cyclic dependency, which is not good (and normally forbidden in CDL).

Dear Dima,
>> Import the attached Attachment 1 (STP)
the attachment seems to be forgotten.

Hi, kgv,
sorry, the file is now attached.
Regarding the cyclic dependencies - please, review, maybe you'll find the better way to resolve the dependencies; for me it was just the clearest possibility.

Branch [archived branch] has been updated by Participant.

[revision removed]


      from 13eaefe 0025166: Allow GEOMETRIC_SET entity to accept GeometricRepresentationItem children
       new 8aaca23 Modification to avoid cyclic dependency between STEPControl and StepToTopoDS packages


Detailed log of new commits:

[revision removed]
Author: gka
Date: Wed Aug 20 16:38:55 2014 +0400

    Modification to avoid cyclic dependency between STEPControl and StepToTopoDS packages

Branch CR25166 is ready to be tested

Dear Commenter 1,

Branch CR25166 from occt git-repository (and master from products git-repository) was compiled on Linux and Windows platforms and tested.
[revision removed]

Number of compiler warnings:

occt component :
Linux: 15 (15 on master)
Windows: 0 (0 on master)

products component :
Linux: 11 (11 on master)
Windows: 1 (1 on master)

Regressions/Differences:
No regressions/differences

Testing cases:
http://occt-tests/CR25166-master-occt/Debian60-64/bugs/step/bug25166.html
http://occt-tests/CR25166-master-occt/Windows-32-VC10/bugs/step/bug25166.html
bugs step(014) bug25166: OK

Testing on Linux:
occt component :
Total MEMORY difference: 352213364 / 351903736
Total CPU difference: 44213.05000000006 / 45953.98000000014
products component :
Total MEMORY difference: 109545196 / 109556352
Total CPU difference: 18585.019999999968 / 18691.699999999983

Testing on Windows:
occt component :
Total MEMORY difference: 239813796 / 239728968
Total CPU difference: 35134.84375 / 32650.4375
products component :
Total MEMORY difference: 66305908 / 65539272
Total CPU difference: 12263.3125 / 13013.484375

There are no differences in images found by testdiff.

Branch [archived branch] has been updated by Participant.

[revision removed]


Detailed log of new commits:

Author: mkv
Date: Thu Aug 21 11:49:01 2014 +0400

    Test cases for issue CR25166

Branch [archived branch] has been deleted by Participant.

[revision removed]