DiscussionsIssue archiveOCCT:Configuration

Archived issue #0025215

Porting to Android - fix minor issues

Open CASCADEOCCT:Configurationclosed18 public notes

Search issues

Description

Fix minor compilation issues.

Public activity

18 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Thu Sep 4 13:15:39 2014 +0400

    0025215: Porting to Android - fix minor issues
    
    STEPConstruct_AP203Context = pw_gecos member of passwd struct disabled in android case.
    Standard_Atomic - correct usage of __atomic_inc()/__atomic_dec().
    Standard_CLocaleSentry - Android doesn't support locales in the C library.
    Standard_MMgrOpt - use "/dev/zero" and "/dev/null" for allocation of memory blocks on Android.
02Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
03Author
Patch is ready for review in branch CR25215.
04Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
05Commenter 5
No remarks, please test
06Commenter 2
Branch [archived branch] has been updated by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Fri Sep 5 08:47:32 2014 +0400

    OSD_Chronometer - fix compilation on Android

07Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
08Commenter 2
Branch [archived branch] has been updated by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Fri Sep 5 14:21:07 2014 +0400

    OSD_Disk, OSD_signal - fix compilation issues on Android

09Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Fri Sep 5 14:27:01 2014 +0400

    0025215: Porting to Android - fix minor issues
    
    STEPConstruct_AP203Context = pw_gecos member of passwd struct disabled in android case.
    Standard_Atomic - correct usage of __atomic_inc()/__atomic_dec().
    Standard_CLocaleSentry - Android doesn't support locales in the C library.
    Standard_MMgrOpt - use "/dev/zero" and "/dev/null" for allocation of memory blocks on Android.
    OSD_Chronometer - fix compilation on Android.
    OSD_Disk, OSD_signal - fix headers inclusion on Android.
10Author
Dear Commenter 1,

patch has been updated to fix new issues on current master.
Please use branch CR25215_1 for testing.
11Commenter 11
Dear Commenter 1,
Branch CR25215_1 from occt git-repository (and master from products git-repository) was compiled on Linux and Windows platforms and tested on Release mode.
[revision removed]

Number of compiler warnings:

occt component :
Linux: 15 (15 on master)
Windows: 0 (0 on master)

products component :
Linux: 11 (11 on master)
Windows: 1 (1 on master)

Regressions/Differences:
No regressions/differences

Testing cases:
Not needed

Testing on Linux:
occt component :
Total MEMORY difference: 355127364 / 355199032
Total CPU difference: 47689.03000000017 / 45791.3500000001
products component :
Total MEMORY difference: 109485584 / 109538648
Total CPU difference: 19486.85999999997 / 18111.489999999958

Testing on Windows:
occt component :
Total MEMORY difference: 241686152 / 241837776
Total CPU difference: 38676.90625 / 36476.171875
products component :
Total MEMORY difference: 66496032 / 66458348
Total CPU difference: 14199.53125 / 12369.875

There are no differences in images found by testdiff.
12Commenter 12
Dear Commenter 1,
Branch CR25215_1 from occt git-repository (and master from products git-repository) was compiled on Linux and Windows platforms and tested on Debug mode .
[revision removed]

Regressions/Differences:
http://occt-tests/CR25215-1-master-occt-deb/Windows-32-VC10/summary.html
bugs modalg_5(010) bug23958, bug24157_1, bug24157_2, bug24157_9, bug24751_1, bug24751_2

Testing cases:
Not needed

Testing on Linux on Debug mode:
occt component :
Total MEMORY difference: 425887732 / 425794920
Total CPU difference: 158108.16000000047 / 156885.24999999927
products component :
Total MEMORY difference: 127822808 / 127757472
Total CPU difference: 39332.19000000002 / 38671.12999999995

Testing on Windows on Debug mode:
occt component :
Total MEMORY difference: 332216300 / 331315732
Total CPU difference: 124384.21875 / 103051.8125
products component :
Total MEMORY difference: 88967628 / 88954420
Total CPU difference: 24383.734375 / 27886.515625

There are no differences in images found by testdiff.
13Author
Dear Commenter 1,

could you please update bug state - it is still in "reviewed" state?

bugs modalg_5(010) bug23958, bug24157_1, bug24157_2, bug24157_9, bug24751_1, bug24751_2

This is unlikely that one extra NULL-check in expression would cause performance regression on Windows.
-  if (aPrevLocale[0] == 'C' && aPrevLocale[1] == '\0')
+  if (myPrevLocale == NULL
+   || (aPrevLocale[0] == 'C' && aPrevLocale[1] == '\0'))
14Author
Dear Commenter 1,

please re-test the branch.
15Commenter 2
Branch [archived branch] has been updated forcibly by Participant.

[revision removed]
16Commenter 16
Dear Commenter 1,

Branch CR25215_1 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
[revision removed]

Number of compiler warnings:
occt component:
   Linux: 15 (15 on master)
   Windows: 0 (0 on master)
products component :
   Linux: 11 (11 on master)
   Windows: 1 (1 on master)

Regressions/Differences:
Not detected

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 351810344 / 351946380
Total CPU difference: 44305.49000000001 / 45041.22000000014

Testing on Windows:
Total MEMORY difference: 241853508 / 241924760
Total CPU difference: 39511.140625 / 42620.984375
17Commenter 2
Branch [archived branch] has been deleted by Author.

[revision removed]
18Commenter 2
Branch [archived branch] has been deleted by Author.

[revision removed]

Related records