MFC standard samples: 3D selection rectangle blinking.

Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Thu Nov 19 18:35:20 2015 +0300

    0025338: MFC standard samples: 3D selection rectangle blinking
    - Added new interactive object OCC_RubberRect to draw selection rectangle

Branch [archived branch] has been updated forcibly by Author.

[revision removed]

Just preliminary considerations:

+class OCC_RubberRect : public AIS_InteractiveObject

this object might be reusable, so it is better to place it in AIS package (e.g. AIS_RubberBand).

+  Standard_Real  myMinX;
+  Standard_Real  myMinY;
+  Standard_Real  myMaxX;
+  Standard_Real  myMaxY;

please unify implementation for both use cases - polygonal and rectangular selection using NCollection_Sequence<Graphic3d_Vec2i>. The should be a method defining rectangle and additional methods adding / removing last point and accessing entire array.

+Quantity_NameOfColor OCC_RubberRect::Color() const

it does not look reasonable defining a method returned color name instead of color itself.

+  myDrawer->SetLineAspect (new Prs3d_LineAspect (theColor, theType, theWidth));

it is better to declare face aspect as well for filled rubber band.
Thus methods should be corrected (LineColor(), FillColor(), LineType(), FillTransparency()). 1.0 transparency would mean no filling.

Branch [archived branch] has been updated forcibly by Author.

[revision removed]

Branch [archived branch] has been updated by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Thu Dec 17 19:35:46 2015 +0300

    Remarks

Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Fri Dec 18 10:17:18 2015 +0300

    0025338: MFC standard samples: 3D selection rectangle blinking
    
    - Added new interactive object AIS_RubberBand to draw rubber rectangle or polygon
    - Added using of AIS_RubberBand in DRAW view for rectangular selection
    - Added using of AIS_RubberBand in MFC samples for rectangular selection

Branch [archived branch] has been updated forcibly by Author.

[revision removed]

Branch [archived branch] has been updated forcibly by Author.

[revision removed]

Branch [archived branch] has been updated forcibly by Author.

[revision removed]

Dear kgv,

could you please review the branch CR25338_2?

Branch [archived branch] has been updated forcibly by Author.

[revision removed]

Branch [archived branch] has been updated forcibly by Author.

[revision removed]

Branch [archived branch] has been updated forcibly by Author.

[revision removed]

Please test the patch, and Draw Harness + modified samples interactively.

Branch [archived branch] has been updated forcibly by Participant.

[revision removed]

Branch [archived branch] has been rebased on the current master

Dear Commenter 1,

Branch CR25338_2 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
[revision removed]

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MacOS: 134 (134 on master)
products component:
   Linux: 37 (37 on master)
   Windows: 0 (0 on master)

Regressions/Differences:
http://occt-tests/CR25338-2-master-occt-64/Windows-64-VC10/summary.html
bugs modalg_5 bug23952_1, bug23952_2

Testing on Linux:
Total MEMORY difference: 89782861 / 89711172 [+0.08%]
Total CPU difference: 19317.939999999984 / 19353.450000000063 [-0.18%]

Testing on Windows:
Total MEMORY difference: 54641052 / 54644507 [-0.01%]
Total CPU difference: 17679.172127298945 / 18196.90824609882 [-2.85%]

Dear aba,

Branch [archived branch] has been rejected due to:
- regressions/differences/improvements

Dear Commenter 1,

> Regressions/Differences:
> bugs modalg_5 bug23952_1, bug23952_2
it doesn't look like the patch might affect these test cases in anyway.
Could you please re-check the problem on current master?

Dear Commenter 1,

Branch CR25338_2 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
[revision removed]

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MacOS: 134 (134 on master)
products component:
   Linux: 37 (37 on master)
   Windows: 0 (0 on master)

Regressions/Differences:
Not detected

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 89782861 / 89711172 [+0.08%]
Total CPU difference: 19317.939999999984 / 19353.450000000063 [-0.18%]

Testing on Windows:
Total MEMORY difference: 54641052 / 54644507 [-0.01%]
Total CPU difference: 17679.172127298945 / 18196.90824609882 [-2.85%]

Dear aba,

Branch [archived branch] has been rejected due to:
- problem with rectangular selection in samples

Dear apv,

- problem with rectangular selection in samples

if testing has been performed using RDP as discussed with Anastasia - then this is not proper way for testing visualization functionality.

Please retest samples locally.

Samples have been tested locally. Problem with rectangular selection has not been detected. Current issue is tested.

Branch [archived branch] has been deleted by Commenter 3.

[revision removed]

Branch [archived branch] has been deleted by Commenter 3.

[revision removed]