DiscussionsIssue archiveOCCT:Modeling Algorithms

Archived issue #0025446

The method BRepAlgoAPI_BooleanOperation::IsDeleted() returns TRUE for the faces contained in the result of BOP

CommunityOCCT:Modeling Algorithmsclosed9 public notes

Search issues

Description

Steps to reproduce

box b1 10 10 10
pcylinder b2 3 20
ttranslate b2 5 5 -5
OCC25446 r b1 b2 0
OCC25446 r b1 b2 1
OCC25446 r b1 b2 2
OCC25446 r b1 b2 3
OCC25446 r b1 b2 4

box b1 10 10 10
pcylinder b2 3 20
ttranslate b2 5 5 10
OCC25446 r b1 b2 0
OCC25446 r b1 b2 1
OCC25446 r b1 b2 2
OCC25446 r b1 b2 3
OCC25446 r b1 b2 4

Public activity

9 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Thu Nov 6 12:12:10 2014 +0400

    0025446: The method BRepAlgoAPI_BooleanOperation::IsDeleted() returns TRUE for the faces contained in the result of BOP
    
    1. The method
      Standard_Boolean BOPAlgo_Builder::IsDeleted
        (const TopoDS_Shape& theS)
      has been modified to return TRUE only if the shape theS has been deleted.
    2. Added new draw (QA) command OCC25446 to test this method.
02Commenter 2
Git branch CR25446 is ready to be reviewed.
03Commenter 3
Reviewed
04Commenter 4
Dear emv,
could you please rebase CR25446 on current master, there are conflict in QABugs_19.cxx file.
05Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
06Commenter 6
Done! Please test.
07Commenter 7
Dear Commenter 1,
Branch CR25446 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]

Number of compiler warnings:

occt component :
Linux: 18 (18 on master)
Windows: 1 (1 on master)

products component :
Linux: 11 (11 on master)
Windows: 1 (1 on master)

Regressions/Differences:
No regressions/differences

Testing cases:
http://occt-tests.nnov.opencascade.com/CR25446-master-occt/Debian60-64/bugs/modalg_5/bug25446_1.html
http://occt-tests.nnov.opencascade.com/CR25446-master-occt/Windows-32-VC10/bugs/modalg_5/bug25446_1.html
bugs modalg_5(010) bug25446_1: OK
http://occt-tests.nnov.opencascade.com/CR25446-master-occt/Debian60-64/bugs/modalg_5/bug25446_2.html
http://occt-tests.nnov.opencascade.com/CR25446-master-occt/Windows-32-VC10/bugs/modalg_5/bug25446_2.html
bugs modalg_5(010) bug25446_2: OK

Testing on Linux:
occt component :
Total MEMORY difference: 357421576 / 357831356
Total CPU difference: 46868.00000000009 / 47034.220000000074
products component :
Total MEMORY difference: 112390092 / 112212500
Total CPU difference: 16893.819999999978 / 17583.579999999914

Testing on Windows:
occt component :
Total MEMORY difference: 273025296 / 271829920
Total CPU difference: 35178.125 / 33239.75
products component :
Total MEMORY difference: 72212492 / 71037912
Total CPU difference: 10387.375 / 11441.625

There are no differences in images found by testdiff.
08Commenter 2
Branch [archived branch] has been updated by Participant.

[revision removed]


Detailed log of new commits:

Author: mkv
Date: Fri Nov 7 14:20:28 2014 +0300

    Test cases for issue CR25446

09Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]