Archived issue #0025468
GeomConvert_ApproxSurface should have a constructor for adaptors
Description
GeomConvert_ApproxSurface should have a constructor for Adaptor3d_Surface objects.
Steps to reproduce
Not applicable
Public activity
8 archived notes
Participants are labeled by their role within this record.
I have analyzed this request and found no obstacles to realize this imp.
However, in order to make the API of similar classes consistent, it is needed to add the corresponding constructor with Adaptor to the following classes:
GeomConvert_ApproxSurface
GeomConvert_ApproxCurve
Geom2dConvert_ApproxCurve
However, in order to make the API of similar classes consistent, it is needed to add the corresponding constructor with Adaptor to the following classes:
GeomConvert_ApproxSurface
GeomConvert_ApproxCurve
Geom2dConvert_ApproxCurve
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: azv
Date: Fri Dec 5 14:29:49 2014 +0300
0025468: GeomConvert_ApproxSurface should have a constructor for adaptors
Additional constructors were implemented into classes:
GeomConvert_ApproxCurve
GeomConvert_ApproxSurface
Geom2dConvert_ApproxCurve
[revision removed]
Detailed log of new commits:
Author: azv
Date: Fri Dec 5 14:29:49 2014 +0300
0025468: GeomConvert_ApproxSurface should have a constructor for adaptors
Additional constructors were implemented into classes:
GeomConvert_ApproxCurve
GeomConvert_ApproxSurface
Geom2dConvert_ApproxCurve
Branch CR25468 is ready for review
No remarks.
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Dear Commenter 1,
Branch CR25468 was rebased on current master of occt git-repository.
Branch CR25468 was rebased on current master of occt git-repository.
Dear Commenter 1,
Branch CR25468 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 18 (18 on master)
Windows: 0 (0 on master)
products component :
Linux: 11 (11 on master)
Windows: 1 (1 on master)
Regressions/Differences:
No regressions/differences
Testing cases:
Not needed
Testing on Linux:
occt component :
Total MEMORY difference: 363970260 / 363537596
Total CPU difference: 46728.85 / 47537.2299999999
products component :
Total MEMORY difference: 112112516 / 111872212
Total CPU difference: 16050.679999999957 / 15946.739999999983
Testing on Windows:
occt component :
Total MEMORY difference: 276874980 / 277181316
Total CPU difference: 34636.53125 / 41681.890625
products component :
Total MEMORY difference: 83932196 / 71187188
Total CPU difference: 10114.484375 / 13033.296875
There are no differences in images found by testdiff.
Branch CR25468 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 18 (18 on master)
Windows: 0 (0 on master)
products component :
Linux: 11 (11 on master)
Windows: 1 (1 on master)
Regressions/Differences:
No regressions/differences
Testing cases:
Not needed
Testing on Linux:
occt component :
Total MEMORY difference: 363970260 / 363537596
Total CPU difference: 46728.85 / 47537.2299999999
products component :
Total MEMORY difference: 112112516 / 111872212
Total CPU difference: 16050.679999999957 / 15946.739999999983
Testing on Windows:
occt component :
Total MEMORY difference: 276874980 / 277181316
Total CPU difference: 34636.53125 / 41681.890625
products component :
Total MEMORY difference: 83932196 / 71187188
Total CPU difference: 10114.484375 / 13033.296875
There are no differences in images found by testdiff.
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]