Archived issue #0025591
Command mkshell produces wrong shell
Description
Command mkshell produces wrong shell.
The shell sh contains edges sh_2, sh_3, that have 3-D curves.
For e.g (csh_2):
*********** Dump of csh_2 *************
Trimmed curve
Parameters : 0 6.28318530717959
Basis curve :
BSplineCurve
Degree 1, 2 Poles, 2 Knots
Poles :
1 : 6.12323399573677e-015, -1.57772181044202e-030, -100
2 : 6.12323399573677e-015, -1.57772181044202e-030, -100
Knots :
1 : 0 2
2 : 6.28318530717959 2
The edges sh_2, sh_3 should be degenerated.
The shell sh contains edges sh_2, sh_3, that have 3-D curves.
For e.g (csh_2):
*********** Dump of csh_2 *************
Trimmed curve
Parameters : 0 6.28318530717959
Basis curve :
BSplineCurve
Degree 1, 2 Poles, 2 Knots
Poles :
1 : 6.12323399573677e-015, -1.57772181044202e-030, -100
2 : 6.12323399573677e-015, -1.57772181044202e-030, -100
Knots :
1 : 0 2
2 : 6.28318530717959 2
The edges sh_2, sh_3 should be degenerated.
Steps to reproduce
# Use the following DRAW commands to reproduce the problem:
sphere surf 100
mkshell sh surf 1
explode sh e
mkcurve csh_2 sh_2
dump csh_2
sphere surf 100
mkshell sh surf 1
explode sh e
mkcurve csh_2 sh_2
dump csh_2
Public activity
13 archived notes
Participants are labeled by their role within this record.
I agree that 3d bspline curve consisting of two poles that are coincided must not be created. Such edge must be degenerated.
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: azv
Date: Tue Dec 16 15:48:42 2014 +0300
0025591: Command mkshell produces wrong shell
The functionality to decide, whether the edge is degenerated, was shared via BRepLib. The verification of producing degenerated edges was added to BRepLib_MakeShell.
[revision removed]
Detailed log of new commits:
Author: azv
Date: Tue Dec 16 15:48:42 2014 +0300
0025591: Command mkshell produces wrong shell
The functionality to decide, whether the edge is degenerated, was shared via BRepLib. The verification of producing degenerated edges was added to BRepLib_MakeShell.
Branch CR25591 is ready for review
Please move the method IsDegenerated back to MakeFace and make it public static class method.
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Please, review updated branch CR25591
OK. Please test.
Dear Commenter 1,
Branch CR25591 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 18 (18 on master)
Windows: 0 (0 on master)
products component :
Linux: 11 (11 on master)
Windows: 1 (1 on master)
Regressions/Differences:
No regressions/differences
Testing cases:
http://occt-tests.nnov.opencascade.com/CR25591-master-occt/Debian60-64/bugs/modalg_5/bug25591.html
http://occt-tests.nnov.opencascade.com/CR25591-master-occt/Windows-32-VC10/bugs/modalg_5/bug25591.html
bugs modalg_5(010) bug25591: OK
Testing on Linux:
occt component :
Total MEMORY difference: 367121684 / 367914368
Total CPU difference: 49935.789999999884 / 51486.65000000016
products component :
Total MEMORY difference: 112312036 / 112529744
Total CPU difference: 16234.62999999999 / 16876.739999999983
Testing on Windows:
occt component :
Total MEMORY difference: 277868488 / 277270364
Total CPU difference: 44731.453125 / 37471.9842007
products component :
Total MEMORY difference: 72405396 / 71382268
Total CPU difference: 13259.609375 / 10342.656534399997
There are no differences in images found by testdiff.
Branch CR25591 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 18 (18 on master)
Windows: 0 (0 on master)
products component :
Linux: 11 (11 on master)
Windows: 1 (1 on master)
Regressions/Differences:
No regressions/differences
Testing cases:
http://occt-tests.nnov.opencascade.com/CR25591-master-occt/Debian60-64/bugs/modalg_5/bug25591.html
http://occt-tests.nnov.opencascade.com/CR25591-master-occt/Windows-32-VC10/bugs/modalg_5/bug25591.html
bugs modalg_5(010) bug25591: OK
Testing on Linux:
occt component :
Total MEMORY difference: 367121684 / 367914368
Total CPU difference: 49935.789999999884 / 51486.65000000016
products component :
Total MEMORY difference: 112312036 / 112529744
Total CPU difference: 16234.62999999999 / 16876.739999999983
Testing on Windows:
occt component :
Total MEMORY difference: 277868488 / 277270364
Total CPU difference: 44731.453125 / 37471.9842007
products component :
Total MEMORY difference: 72405396 / 71382268
Total CPU difference: 13259.609375 / 10342.656534399997
There are no differences in images found by testdiff.
Branch [archived branch] has been updated by Participant.
[revision removed]
Detailed log of new commits:
Author: mkv
Date: Fri Dec 19 12:08:45 2014 +0300
Test case for issue CR25591
[revision removed]
Detailed log of new commits:
Author: mkv
Date: Fri Dec 19 12:08:45 2014 +0300
Test case for issue CR25591
Dear azv,
could you please review test case bugs/modalg_5(010)/bug25591
could you please review test case bugs/modalg_5(010)/bug25591
Dear mkv,
Test case is OK.
Test case is OK.
Branch CR25591 is TESTED.
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]