Archived issue #0025695
Visualization, AIS_InteractiveContext - define default HilightMode
Description
AIS_InteractiveObject has hilight mode feature as below:
Standard_Boolean HasHilightMode() const;
Standard_Integer HilightMode() const;
void SetHilightMode (const Standard_Integer anIndex) ;
void UnsetHilightMode() ;
In most cad application, it's more preferable to set hilight mode in the interactive context instead of each interactive object. It would be nice to support hilight mode in AIS_InteractiveContext besides AIS_InteractiveObject.
Standard_Boolean HasHilightMode() const;
Standard_Integer HilightMode() const;
void SetHilightMode (const Standard_Integer anIndex) ;
void UnsetHilightMode() ;
In most cad application, it's more preferable to set hilight mode in the interactive context instead of each interactive object. It would be nice to support hilight mode in AIS_InteractiveContext besides AIS_InteractiveObject.
Public activity
56 archived notes
Participants are labeled by their role within this record.
In OCCT each interactive object defines its own set of display modes.
Storing highlight mode in AIS_InteractiveContext would not make any sense in most applications not limited to AIS_Shape presentation objects.
Storing highlight mode in AIS_InteractiveContext would not make any sense in most applications not limited to AIS_Shape presentation objects.
Branch [archived branch] has been created by Commenter 2.
[revision removed]
Detailed log of new commits:
Author: Commenter 2
Date: Wed Nov 2 17:36:18 2016 +0300
0025695: Visualization, AIS_InteractiveContext - define default HilightMode
AIS_InteractiveContext - removed the following unused properties:
- PreSelectionColor(), DefaultColor(), WasCurrentTouched(), ZDetection().
Graphic3d_HighlightStyle has been extended with new properties:
- ZLayer() defining Z-Layer for highlighting presentation.
- DisplayMode() defining display mode for highlighting.
[revision removed]
Detailed log of new commits:
Author: Commenter 2
Date: Wed Nov 2 17:36:18 2016 +0300
0025695: Visualization, AIS_InteractiveContext - define default HilightMode
AIS_InteractiveContext - removed the following unused properties:
- PreSelectionColor(), DefaultColor(), WasCurrentTouched(), ZDetection().
Graphic3d_HighlightStyle has been extended with new properties:
- ZLayer() defining Z-Layer for highlighting presentation.
- DisplayMode() defining display mode for highlighting.
Branch [archived branch] has been updated forcibly by Commenter 2.
[revision removed]
[revision removed]
Branch [archived branch] has been updated forcibly by Commenter 2.
[revision removed]
[revision removed]
Patch is ready for review.
Branch [archived branch] has been updated forcibly by Commenter 2.
[revision removed]
[revision removed]
Branch [archived branch] has been updated forcibly by Commenter 2.
[revision removed]
[revision removed]
Branch [archived branch] has been updated forcibly by Commenter 2.
[revision removed]
[revision removed]
Branch [archived branch] has been updated by Commenter 2.
[revision removed]
Detailed log of new commits:
Author: Commenter 2
Date: Fri Dec 2 22:16:10 2016 +0300
Prs3d_Drawer - removed properties HighlightStyle() and SelectionStyle().
Prs3d_Drawer now inherits class Graphic3d_PresentationAttributes.
[revision removed]
Detailed log of new commits:
Author: Commenter 2
Date: Fri Dec 2 22:16:10 2016 +0300
Prs3d_Drawer - removed properties HighlightStyle() and SelectionStyle().
Prs3d_Drawer now inherits class Graphic3d_PresentationAttributes.
Branch [archived branch] has been updated forcibly by Commenter 2.
[revision removed]
[revision removed]
Branch [archived branch] has been updated by Commenter 2.
[revision removed]
Detailed log of new commits:
Author: Commenter 2
Date: Fri Dec 2 22:16:10 2016 +0300
corrections
[revision removed]
Detailed log of new commits:
Author: Commenter 2
Date: Fri Dec 2 22:16:10 2016 +0300
corrections
Branch [archived branch] has been updated forcibly by Commenter 2.
[revision removed]
[revision removed]
Branch [archived branch] has been updated by Commenter 2.
[revision removed]
Detailed log of new commits:
Author: Commenter 2
Date: Sat Dec 3 10:58:42 2016 +0300
PrsMgr_PresentableObject::myZLayer has been replaced by myDrawer->ZLayer()
[revision removed]
Detailed log of new commits:
Author: Commenter 2
Date: Sat Dec 3 10:58:42 2016 +0300
PrsMgr_PresentableObject::myZLayer has been replaced by myDrawer->ZLayer()
Branch [archived branch] has been updated by Commenter 2.
[revision removed]
Detailed log of new commits:
Author: Commenter 2
Date: Sat Dec 3 13:32:48 2016 +0300
PrsMgr_PresentationManager::Unhighlight() now unhighlight all modes.
The method taking Mode as argument has been marked deprecated.
[revision removed]
Detailed log of new commits:
Author: Commenter 2
Date: Sat Dec 3 13:32:48 2016 +0300
PrsMgr_PresentationManager::Unhighlight() now unhighlight all modes.
The method taking Mode as argument has been marked deprecated.
Branch [archived branch] has been updated by Commenter 2.
[revision removed]
Detailed log of new commits:
Author: Commenter 2
Date: Sat Dec 3 14:22:15 2016 +0300
Porting notes
[revision removed]
Detailed log of new commits:
Author: Commenter 2
Date: Sat Dec 3 14:22:15 2016 +0300
Porting notes
Branch [archived branch] has been created by Commenter 2.
[revision removed]
Detailed log of new commits:
Author: Commenter 2
Date: Wed Nov 2 17:36:18 2016 +0300
0025695: Visualization, AIS_InteractiveContext - define default HilightMode
AIS_InteractiveContext - removed the following unused properties:
- PreSelectionColor(), DefaultColor(), WasCurrentTouched(), ZDetection().
AIS_InteractiveObject - removed unused property SelectionPriority().
Prs3d_Drawer - removed properties HighlightStyle() and SelectionStyle().
Graphic3d_HighlightStyle has been superseded by Prs3d_Drawer
inheriting from new class Graphic3d_PresentationAttributes.
Graphic3d_PresentationAttributes (as Graphic3d_HighlightStyle replacement)
has been extended with new properties:
- ZLayer() defining Z-Layer for highlighting presentation.
- DisplayMode() defining display mode for highlighting.
StdSelect_BRepSelectionTool methods have been corrected to take
SelectMgr_EntityOwner instead of StdSelect_BRepOwner.
AIS_InteractiveObject - myDrawer->Color() is now used instead of myOwnColor,
myDrawer->Transparency() instead of myTransparency
and myDrawer->ZLayer() instead of myZLayer.
PrsMgr_PresentationManager::Unhighlight() now unhighlight all modes.
The method taking Mode as argument has been marked deprecated.
[revision removed]
Detailed log of new commits:
Author: Commenter 2
Date: Wed Nov 2 17:36:18 2016 +0300
0025695: Visualization, AIS_InteractiveContext - define default HilightMode
AIS_InteractiveContext - removed the following unused properties:
- PreSelectionColor(), DefaultColor(), WasCurrentTouched(), ZDetection().
AIS_InteractiveObject - removed unused property SelectionPriority().
Prs3d_Drawer - removed properties HighlightStyle() and SelectionStyle().
Graphic3d_HighlightStyle has been superseded by Prs3d_Drawer
inheriting from new class Graphic3d_PresentationAttributes.
Graphic3d_PresentationAttributes (as Graphic3d_HighlightStyle replacement)
has been extended with new properties:
- ZLayer() defining Z-Layer for highlighting presentation.
- DisplayMode() defining display mode for highlighting.
StdSelect_BRepSelectionTool methods have been corrected to take
SelectMgr_EntityOwner instead of StdSelect_BRepOwner.
AIS_InteractiveObject - myDrawer->Color() is now used instead of myOwnColor,
myDrawer->Transparency() instead of myTransparency
and myDrawer->ZLayer() instead of myZLayer.
PrsMgr_PresentationManager::Unhighlight() now unhighlight all modes.
The method taking Mode as argument has been marked deprecated.
Updated patch is ready for review.
Branch [archived branch] has been updated forcibly by Commenter 2.
[revision removed]
[revision removed]
Branch [archived branch] has been updated forcibly by Commenter 2.
[revision removed]
[revision removed]
Branch [archived branch] has been updated forcibly by Commenter 2.
[revision removed]
[revision removed]
Branch [archived branch] has been updated forcibly by Commenter 2.
[revision removed]
[revision removed]
Branch [archived branch] has been updated by Commenter 2.
[revision removed]
Detailed log of new commits:
Author: Commenter 2
Date: Wed Nov 2 17:36:18 2016 +0300
AIS_InteractiveObject - split highlight styles for Global and Local selection.
New enumeration Prs3d_TypeOfHighlight has been introduced
defining different highlight types.
ComesFromDecomposition() property has been moved
from StdSelect_BRepOwner to SelectMgr_EntityOwner.
[revision removed]
Detailed log of new commits:
Author: Commenter 2
Date: Wed Nov 2 17:36:18 2016 +0300
AIS_InteractiveObject - split highlight styles for Global and Local selection.
New enumeration Prs3d_TypeOfHighlight has been introduced
defining different highlight types.
ComesFromDecomposition() property has been moved
from StdSelect_BRepOwner to SelectMgr_EntityOwner.
Branch [archived branch] has been updated forcibly by Commenter 2.
[revision removed]
[revision removed]
Branch [archived branch] has been updated forcibly by Commenter 2.
[revision removed]
[revision removed]
Branch [archived branch] has been updated forcibly by Commenter 2.
[revision removed]
[revision removed]
Branch [archived branch] has been updated forcibly by Commenter 2.
[revision removed]
[revision removed]
Branch [archived branch] has been updated forcibly by Commenter 2.
[revision removed]
[revision removed]
Branch [archived branch] has been updated forcibly by Commenter 2.
[revision removed]
[revision removed]
Branch CR25695_1 in occt and occt-products reviewed without remarks, ready for testing.
Dear Commenter 3,
Branch CR25695_1 from occt git-repository (and CR25695_1 from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
[revision removed]
There are following compilation errors:
Linux:
http://jenkins-test-07.nnov.opencascade.com:8080/view/CR25695_1-CR25695_1/job/CR25695_1-CR25695_1-Products-Debian70-64-opt-compile/1/parsed_console/
/dn54/builds/CR25695_1-CR25695_1/Debian70-64-opt/Products/src/PMIVis/PMIVis_Info.cxx:31:38: fatal error: Select3d_SensitiveFace.hxx: No such file or directory
Branch CR25695_1 from occt git-repository (and CR25695_1 from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
[revision removed]
There are following compilation errors:
Linux:
http://jenkins-test-07.nnov.opencascade.com:8080/view/CR25695_1-CR25695_1/job/CR25695_1-CR25695_1-Products-Debian70-64-opt-compile/1/parsed_console/
/dn54/builds/CR25695_1-CR25695_1/Debian70-64-opt/Products/src/PMIVis/PMIVis_Info.cxx:31:38: fatal error: Select3d_SensitiveFace.hxx: No such file or directory
Dear kgv,
Branch [archived branch] has been rejected due to:
- compilation errors
Branch [archived branch] has been rejected due to:
- compilation errors
I have pushed branch to Products repository rebased on current master - there no such compilation errors.
Dear Commenter 3,
Branch CR25695_1 from occt git-repository (and CR25695_1 from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
[revision removed]
There are following compilation errors:
Windows:
http://jenkins-test-07.nnov.opencascade.com:8080/view/CR25695_1-CR25695_1/job/CR25695_1-CR25695_1-Products-Windows-64-VC10-csharp-samples/2/parsed_console/
2>------ Build started: Project: OCCCSharp, Configuration: Release x64 ------
d:\install\CR25695_1-CR25695_1\Windows-64-VC10-opt\Products\samples\csharp\OCCCSharp\Wrappers\Prs3d_Drawer.cs(1190,36): warning CS0109: The member 'Prs3d.Prs3d_Drawer.DownCast(Standard.Standard_Transient)' does not hide an inherited member. The new keyword is not required.
d:\install\CR25695_1-CR25695_1\Windows-64-VC10-opt\Products\samples\csharp\OCCCSharp\Wrappers\Prs3d_Drawer.cs(55,48): error CS0103: The name 'checkTransientInheritance' does not exist in the current context
d:\install\CR25695_1-CR25695_1\Windows-64-VC10-opt\Products\samples\csharp\OCCCSharp\Wrappers\AIS_CustomInteractiveObject.cs(88,5): error CS1502: The best overloaded method match for 'PrsMgr.PrsMgr_PresentableObject.SetDynamicHilightAttributes(SWIG.SWIGTYPE_p_opencascade__handleT_Prs3d_Drawer_t)' has some invalid arguments
d:\install\CR25695_1-CR25695_1\Windows-64-VC10-opt\Products\samples\csharp\OCCCSharp\Wrappers\AIS_CustomInteractiveObject.cs(88,34): error CS1503: Argument 1: cannot convert from 'Prs3d.Prs3d_Drawer' to 'SWIG.SWIGTYPE_p_opencascade__handleT_Prs3d_Drawer_t'
Compile complete -- 3 errors, 1 warnings
http://jenkins-test-07.nnov.opencascade.com:8080/view/CR25695_1-CR25695_1/job/CR25695_1-CR25695_1-Products-Windows-64-VC10-java-samples/2/parsed_console/
OCCwrapJavaJNI.java:21746: error: incompatible types: Prs3d_Drawer cannot be converted to SWIGTYPE_p_opencascade__handleT_Prs3d_Drawer_t
1 error
http://jenkins-test-07.nnov.opencascade.com:8080/view/CR25695_1-CR25695_1/job/CR25695_1-CR25695_1-Products-Windows-64-VC10-mfc-samples/2/parsed_console/
1>src\Kernel_MeshPrs.cxx(238): error C2065: 'myTransparency' : undeclared identifier
1>src\Kernel_MeshPrs.cxx(257): error C2065: 'myTransparency' : undeclared identifier
Number of compiler warnings:
occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 2 (0 on master)
products component :
Linux: 63 (63 on master)
Windows: 0 (0 on master)
MacOS : 1139
There are new additional compilation warnings on MacOS platform:
http://jenkins-test-07.nnov.opencascade.com:8080/user/mnt/my-views/view/A_mnt_warnings/portlet/dashboard_portlet_13912/job/CR25695_1-CR25695_1-OCCT-MacOS-opt-compile/1/warnings7Result/
AIS_MultipleConnectedInteractive.cxx:51, Clang (LLVM based), Priority: Normal
'Selectable' overrides a member function but is not marked 'override'
StdSelect_Shape.hxx:57, Clang (LLVM based), Priority: Normal
'SetAttributes' overrides a member function but is not marked 'override'
Regressions/Differences/Improvements:
http://occt-tests/CR25695_1-CR25695_1-Products/Debian70-64/pmivis/import/select.html
http://occt-tests/CR25695_1-CR25695_1-Products/Windows-64-VC10/pmivis/import/select.html
pmivis import select: FAILED
Testing cases:
http://occt-tests/CR25695_1-CR25695_1-OCCT/Debian70-64/bugs/vis/bug25695.html
http://occt-tests/CR25695_1-CR25695_1-OCCT/Windows-64-VC10/bugs/vis/bug25695.html
bugs vis bug25695: OK
Testing on Linux:
occt component :
Total MEMORY difference: 91470594 / 91438072 [+0.04%]
Total CPU difference: 21931.110000000313 / 21816.29000000019 [+0.53%]
products component :
Total MEMORY difference: 29864487 / 29803095 [+0.21%]
Total CPU difference: 5296.029999999967 / 5308.749999999961 [-0.24%]
Testing on Windows:
occt component :
Total MEMORY difference: 56942301 / 56944788 [-0.00%]
Total CPU difference: 20525.784774698488 / 20501.5734194986 [+0.12%]
products component :
Total MEMORY difference: 20860564 / 20808844 [+0.25%]
Total CPU difference: 5260.088518299974 / 5254.222880699978 [+0.11%]
There are following differences in images found by testdiff.
http://occt-tests/CR25695_1-CR25695_1-OCCT/Debian70-64/diff-Debian70-64.html
http://occt-tests/CR25695_1-CR25695_1-OCCT/Windows-64-VC10/diff-Windows-64-VC10-image.html
IMAGE bugs vis bug27986_2: bug27986_2.png differs
IMAGE bugs vis bug27817: bug27817.png differs
Branch CR25695_1 from occt git-repository (and CR25695_1 from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
[revision removed]
There are following compilation errors:
Windows:
http://jenkins-test-07.nnov.opencascade.com:8080/view/CR25695_1-CR25695_1/job/CR25695_1-CR25695_1-Products-Windows-64-VC10-csharp-samples/2/parsed_console/
2>------ Build started: Project: OCCCSharp, Configuration: Release x64 ------
d:\install\CR25695_1-CR25695_1\Windows-64-VC10-opt\Products\samples\csharp\OCCCSharp\Wrappers\Prs3d_Drawer.cs(1190,36): warning CS0109: The member 'Prs3d.Prs3d_Drawer.DownCast(Standard.Standard_Transient)' does not hide an inherited member. The new keyword is not required.
d:\install\CR25695_1-CR25695_1\Windows-64-VC10-opt\Products\samples\csharp\OCCCSharp\Wrappers\Prs3d_Drawer.cs(55,48): error CS0103: The name 'checkTransientInheritance' does not exist in the current context
d:\install\CR25695_1-CR25695_1\Windows-64-VC10-opt\Products\samples\csharp\OCCCSharp\Wrappers\AIS_CustomInteractiveObject.cs(88,5): error CS1502: The best overloaded method match for 'PrsMgr.PrsMgr_PresentableObject.SetDynamicHilightAttributes(SWIG.SWIGTYPE_p_opencascade__handleT_Prs3d_Drawer_t)' has some invalid arguments
d:\install\CR25695_1-CR25695_1\Windows-64-VC10-opt\Products\samples\csharp\OCCCSharp\Wrappers\AIS_CustomInteractiveObject.cs(88,34): error CS1503: Argument 1: cannot convert from 'Prs3d.Prs3d_Drawer' to 'SWIG.SWIGTYPE_p_opencascade__handleT_Prs3d_Drawer_t'
Compile complete -- 3 errors, 1 warnings
http://jenkins-test-07.nnov.opencascade.com:8080/view/CR25695_1-CR25695_1/job/CR25695_1-CR25695_1-Products-Windows-64-VC10-java-samples/2/parsed_console/
OCCwrapJavaJNI.java:21746: error: incompatible types: Prs3d_Drawer cannot be converted to SWIGTYPE_p_opencascade__handleT_Prs3d_Drawer_t
1 error
http://jenkins-test-07.nnov.opencascade.com:8080/view/CR25695_1-CR25695_1/job/CR25695_1-CR25695_1-Products-Windows-64-VC10-mfc-samples/2/parsed_console/
1>src\Kernel_MeshPrs.cxx(238): error C2065: 'myTransparency' : undeclared identifier
1>src\Kernel_MeshPrs.cxx(257): error C2065: 'myTransparency' : undeclared identifier
Number of compiler warnings:
occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 2 (0 on master)
products component :
Linux: 63 (63 on master)
Windows: 0 (0 on master)
MacOS : 1139
There are new additional compilation warnings on MacOS platform:
http://jenkins-test-07.nnov.opencascade.com:8080/user/mnt/my-views/view/A_mnt_warnings/portlet/dashboard_portlet_13912/job/CR25695_1-CR25695_1-OCCT-MacOS-opt-compile/1/warnings7Result/
AIS_MultipleConnectedInteractive.cxx:51, Clang (LLVM based), Priority: Normal
'Selectable' overrides a member function but is not marked 'override'
StdSelect_Shape.hxx:57, Clang (LLVM based), Priority: Normal
'SetAttributes' overrides a member function but is not marked 'override'
Regressions/Differences/Improvements:
http://occt-tests/CR25695_1-CR25695_1-Products/Debian70-64/pmivis/import/select.html
http://occt-tests/CR25695_1-CR25695_1-Products/Windows-64-VC10/pmivis/import/select.html
pmivis import select: FAILED
Testing cases:
http://occt-tests/CR25695_1-CR25695_1-OCCT/Debian70-64/bugs/vis/bug25695.html
http://occt-tests/CR25695_1-CR25695_1-OCCT/Windows-64-VC10/bugs/vis/bug25695.html
bugs vis bug25695: OK
Testing on Linux:
occt component :
Total MEMORY difference: 91470594 / 91438072 [+0.04%]
Total CPU difference: 21931.110000000313 / 21816.29000000019 [+0.53%]
products component :
Total MEMORY difference: 29864487 / 29803095 [+0.21%]
Total CPU difference: 5296.029999999967 / 5308.749999999961 [-0.24%]
Testing on Windows:
occt component :
Total MEMORY difference: 56942301 / 56944788 [-0.00%]
Total CPU difference: 20525.784774698488 / 20501.5734194986 [+0.12%]
products component :
Total MEMORY difference: 20860564 / 20808844 [+0.25%]
Total CPU difference: 5260.088518299974 / 5254.222880699978 [+0.11%]
There are following differences in images found by testdiff.
http://occt-tests/CR25695_1-CR25695_1-OCCT/Debian70-64/diff-Debian70-64.html
http://occt-tests/CR25695_1-CR25695_1-OCCT/Windows-64-VC10/diff-Windows-64-VC10-image.html
IMAGE bugs vis bug27986_2: bug27986_2.png differs
IMAGE bugs vis bug27817: bug27817.png differs
Dear kgv,
Branch [archived branch] has been rejected due to:
- compilation errors
- additional warnings
- regressions/differences/improvements
- differences in images
Branch [archived branch] has been rejected due to:
- compilation errors
- additional warnings
- regressions/differences/improvements
- differences in images
Branch [archived branch] has been updated by Commenter 2.
[revision removed]
Detailed log of new commits:
Author: Commenter 2
Date: Thu Dec 8 14:31:05 2016 +0300
StdSelect_Shape - duplicated field myDrawer has been dropped.
SelectMgr_AssemblyEntityOwner::Selectable() - added missing override keyword.
[revision removed]
Detailed log of new commits:
Author: Commenter 2
Date: Thu Dec 8 14:31:05 2016 +0300
StdSelect_Shape - duplicated field myDrawer has been dropped.
SelectMgr_AssemblyEntityOwner::Selectable() - added missing override keyword.
Branch [archived branch] has been updated forcibly by Commenter 2.
[revision removed]
[revision removed]
> IMAGE bugs vis bug27986_2: bug27986_2.png differs
> IMAGE bugs vis bug27817: bug27817.png differs
This difference is expected.
Other issues should be fixed now - please re-check updated patch.
> IMAGE bugs vis bug27817: bug27817.png differs
This difference is expected.
Other issues should be fixed now - please re-check updated patch.
Dear kgv,
could you please rebase branch CR25695_1 on IR-2016-12-08 of occt git-repository, there are conflict files.
could you please rebase branch CR25695_1 on IR-2016-12-08 of occt git-repository, there are conflict files.
Branch [archived branch] has been created by Commenter 2.
[revision removed]
Detailed log of new commits:
Author: Commenter 2
Date: Wed Nov 2 17:36:18 2016 +0300
0025695: Visualization, AIS_InteractiveContext - define default HilightMode
AIS_InteractiveContext - removed the following unused properties:
- PreSelectionColor(), DefaultColor(), WasCurrentTouched(), ZDetection().
AIS_InteractiveObject - removed unused property SelectionPriority().
Prs3d_Drawer - removed properties HighlightStyle() and SelectionStyle().
Graphic3d_HighlightStyle has been superseded by Prs3d_Drawer
inheriting from new class Graphic3d_PresentationAttributes.
Graphic3d_PresentationAttributes (as Graphic3d_HighlightStyle replacement)
has been extended with new properties:
- ZLayer() defining Z-Layer for highlighting presentation.
- DisplayMode() defining display mode for highlighting.
StdSelect_BRepSelectionTool methods have been corrected to take
SelectMgr_EntityOwner instead of StdSelect_BRepOwner.
StdSelect_Shape - duplicated field myDrawer has been dropped.
AIS_InteractiveObject - myDrawer->Color() is now used instead of myOwnColor,
myDrawer->Transparency() instead of myTransparency
and myDrawer->ZLayer() instead of myZLayer.
PrsMgr_PresentationManager::Unhighlight() now unhighlight all modes.
The method taking Mode as argument has been marked deprecated.
New enumeration Prs3d_TypeOfHighlight has been introduced
defining different highlight types.
AIS_InteractiveObject::HighlightStyle() now takes enumeration argument
and defines different styles for Global and Local selection.
ComesFromDecomposition() property has been moved
from StdSelect_BRepOwner to SelectMgr_EntityOwner.
[revision removed]
Detailed log of new commits:
Author: Commenter 2
Date: Wed Nov 2 17:36:18 2016 +0300
0025695: Visualization, AIS_InteractiveContext - define default HilightMode
AIS_InteractiveContext - removed the following unused properties:
- PreSelectionColor(), DefaultColor(), WasCurrentTouched(), ZDetection().
AIS_InteractiveObject - removed unused property SelectionPriority().
Prs3d_Drawer - removed properties HighlightStyle() and SelectionStyle().
Graphic3d_HighlightStyle has been superseded by Prs3d_Drawer
inheriting from new class Graphic3d_PresentationAttributes.
Graphic3d_PresentationAttributes (as Graphic3d_HighlightStyle replacement)
has been extended with new properties:
- ZLayer() defining Z-Layer for highlighting presentation.
- DisplayMode() defining display mode for highlighting.
StdSelect_BRepSelectionTool methods have been corrected to take
SelectMgr_EntityOwner instead of StdSelect_BRepOwner.
StdSelect_Shape - duplicated field myDrawer has been dropped.
AIS_InteractiveObject - myDrawer->Color() is now used instead of myOwnColor,
myDrawer->Transparency() instead of myTransparency
and myDrawer->ZLayer() instead of myZLayer.
PrsMgr_PresentationManager::Unhighlight() now unhighlight all modes.
The method taking Mode as argument has been marked deprecated.
New enumeration Prs3d_TypeOfHighlight has been introduced
defining different highlight types.
AIS_InteractiveObject::HighlightStyle() now takes enumeration argument
and defines different styles for Global and Local selection.
ComesFromDecomposition() property has been moved
from StdSelect_BRepOwner to SelectMgr_EntityOwner.
The patch has been rebased (branch CR25695_2), upgrade guide has been merged.
Dear Commenter 3,
Branch CR25695_2 from occt git-repository (and CR25695_2 from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
[revision removed]
There are following compilation errors:
Windows:
http://jenkins-test-07.nnov.opencascade.com:8080/view/CR25695_2-CR25695_2/job/CR25695_2-CR25695_2-Products-Windows-64-VC10-csharp-samples/1/parsed_console/
d:\install\CR25695_2-CR25695_2\Windows-64-VC10-opt\Products\samples\csharp\OCCCSharp\Wrappers\AIS_CustomInteractiveObject.cs(88,5): error CS1502: The best overloaded method match for 'PrsMgr.PrsMgr_PresentableObject.SetDynamicHilightAttributes(SWIG.SWIGTYPE_p_opencascade__handleT_Prs3d_Drawer_t)' has some invalid arguments
d:\install\CR25695_2-CR25695_2\Windows-64-VC10-opt\Products\samples\csharp\OCCCSharp\Wrappers\AIS_CustomInteractiveObject.cs(88,34): error CS1503: Argument 1: cannot convert from 'Prs3d.Prs3d_Drawer' to 'SWIG.SWIGTYPE_p_opencascade__handleT_Prs3d_Drawer_t'
http://jenkins-test-07.nnov.opencascade.com:8080/view/CR25695_2-CR25695_2/job/CR25695_2-CR25695_2-Products-Windows-64-VC10-java-samples/1/parsed_console/
OCCwrapJavaJNI.java:21764: error: incompatible types: Prs3d_Drawer cannot be converted to SWIGTYPE_p_opencascade__handleT_Prs3d_Drawer_t
http://jenkins-test-07.nnov.opencascade.com:8080/view/CR25695_2-CR25695_2/job/CR25695_2-CR25695_2-Products-Windows-64-VC10-mfc-samples/1/parsed_console/
1>Kernel\Kernel_MeshPrs.cxx(531): error C2065: 'myTransparency' : undeclared identifier
1>Kernel\Kernel_MeshPrs.cxx(557): error C2065: 'myTransparency' : undeclared identifier
Number of compiler warnings:
occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)
products component :
Linux: 63 (63 on master)
Windows: 0 (0 on master)
MacOS : 1138
Regressions/Differences/Improvements:
http://occt-tests/CR25695_2-CR25695_2-OCCT/Debian70-64/summary.html
http://occt-tests/CR25695_2-CR25695_2-OCCT/Windows-64-VC10/summary.html
Failed:
bugs vis bug1786, bug7186, bug23539_1, bug23539_2, bug23649_1, bug23649_2, bug24966, bug25335, bug26147, bug26172, bug26209, bug26430, bug26721
v3d vertex B3, B4, B5, B6, B7, B8, B9, C1
http://occt-tests/CR25695_2-CR25695_2-Products/Debian70-64/pmivis/import/select.html
http://occt-tests/CR25695_2-CR25695_2-Products/Windows-64-VC10/pmivis/import/select.html
pmivis import select: FAILED
Testing cases:
http://occt-tests/CR25695_2-CR25695_2-OCCT/Debian70-64/bugs/vis/bug25695.html
http://occt-tests/CR25695_2-CR25695_2-OCCT/Windows-64-VC10/bugs/vis/bug25695.html
bugs vis bug25695: OK
Testing on Linux:
occt component :
Total MEMORY difference: 93345735 / 92651729 [+0.75%]
Total CPU difference: 21605.24000000014 / 21536.050000000276 [+0.32%]
products component :
Total MEMORY difference: 30085093 / 30078149 [+0.02%]
Total CPU difference: 5343.94999999998 / 5302.72999999998 [+0.78%]
Testing on Windows:
occt component :
Total MEMORY difference: 58454758 / 58458666 [-0.01%]
Total CPU difference: 20050.059725198407 / 20176.670136798508 [-0.63%]
products component :
Total MEMORY difference: 20894701 / 20859840 [+0.17%]
Total CPU difference: 5294.954741799973 / 5125.865257899959 [+3.30%]
There are following differences in images found by testdiff.
http://occt-tests/CR25695_2-CR25695_2-OCCT/Debian70-64/diff-Debian70-64.html
http://occt-tests/CR25695_2-CR25695_2-OCCT/Windows-64-VC10/diff-Windows-64-VC10-image.html
IMAGE bugs vis bug26973: bug26973_obj_with_trsf.png differs
IMAGE bugs vis bug26973: bug26973_view_with_trsf.png differs
IMAGE bugs vis bug26973: bug26973_obj_wo_trsf.png differs
IMAGE bugs vis bug26973: bug26973_view_wo_trsf.png differs
IMAGE bugs vis bug27986_2: bug27986_2.png differs - This difference is expected
IMAGE bugs vis bug27817: bug27817.png differs - This difference is expected
Branch CR25695_2 from occt git-repository (and CR25695_2 from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
[revision removed]
There are following compilation errors:
Windows:
http://jenkins-test-07.nnov.opencascade.com:8080/view/CR25695_2-CR25695_2/job/CR25695_2-CR25695_2-Products-Windows-64-VC10-csharp-samples/1/parsed_console/
d:\install\CR25695_2-CR25695_2\Windows-64-VC10-opt\Products\samples\csharp\OCCCSharp\Wrappers\AIS_CustomInteractiveObject.cs(88,5): error CS1502: The best overloaded method match for 'PrsMgr.PrsMgr_PresentableObject.SetDynamicHilightAttributes(SWIG.SWIGTYPE_p_opencascade__handleT_Prs3d_Drawer_t)' has some invalid arguments
d:\install\CR25695_2-CR25695_2\Windows-64-VC10-opt\Products\samples\csharp\OCCCSharp\Wrappers\AIS_CustomInteractiveObject.cs(88,34): error CS1503: Argument 1: cannot convert from 'Prs3d.Prs3d_Drawer' to 'SWIG.SWIGTYPE_p_opencascade__handleT_Prs3d_Drawer_t'
http://jenkins-test-07.nnov.opencascade.com:8080/view/CR25695_2-CR25695_2/job/CR25695_2-CR25695_2-Products-Windows-64-VC10-java-samples/1/parsed_console/
OCCwrapJavaJNI.java:21764: error: incompatible types: Prs3d_Drawer cannot be converted to SWIGTYPE_p_opencascade__handleT_Prs3d_Drawer_t
http://jenkins-test-07.nnov.opencascade.com:8080/view/CR25695_2-CR25695_2/job/CR25695_2-CR25695_2-Products-Windows-64-VC10-mfc-samples/1/parsed_console/
1>Kernel\Kernel_MeshPrs.cxx(531): error C2065: 'myTransparency' : undeclared identifier
1>Kernel\Kernel_MeshPrs.cxx(557): error C2065: 'myTransparency' : undeclared identifier
Number of compiler warnings:
occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)
products component :
Linux: 63 (63 on master)
Windows: 0 (0 on master)
MacOS : 1138
Regressions/Differences/Improvements:
http://occt-tests/CR25695_2-CR25695_2-OCCT/Debian70-64/summary.html
http://occt-tests/CR25695_2-CR25695_2-OCCT/Windows-64-VC10/summary.html
Failed:
bugs vis bug1786, bug7186, bug23539_1, bug23539_2, bug23649_1, bug23649_2, bug24966, bug25335, bug26147, bug26172, bug26209, bug26430, bug26721
v3d vertex B3, B4, B5, B6, B7, B8, B9, C1
http://occt-tests/CR25695_2-CR25695_2-Products/Debian70-64/pmivis/import/select.html
http://occt-tests/CR25695_2-CR25695_2-Products/Windows-64-VC10/pmivis/import/select.html
pmivis import select: FAILED
Testing cases:
http://occt-tests/CR25695_2-CR25695_2-OCCT/Debian70-64/bugs/vis/bug25695.html
http://occt-tests/CR25695_2-CR25695_2-OCCT/Windows-64-VC10/bugs/vis/bug25695.html
bugs vis bug25695: OK
Testing on Linux:
occt component :
Total MEMORY difference: 93345735 / 92651729 [+0.75%]
Total CPU difference: 21605.24000000014 / 21536.050000000276 [+0.32%]
products component :
Total MEMORY difference: 30085093 / 30078149 [+0.02%]
Total CPU difference: 5343.94999999998 / 5302.72999999998 [+0.78%]
Testing on Windows:
occt component :
Total MEMORY difference: 58454758 / 58458666 [-0.01%]
Total CPU difference: 20050.059725198407 / 20176.670136798508 [-0.63%]
products component :
Total MEMORY difference: 20894701 / 20859840 [+0.17%]
Total CPU difference: 5294.954741799973 / 5125.865257899959 [+3.30%]
There are following differences in images found by testdiff.
http://occt-tests/CR25695_2-CR25695_2-OCCT/Debian70-64/diff-Debian70-64.html
http://occt-tests/CR25695_2-CR25695_2-OCCT/Windows-64-VC10/diff-Windows-64-VC10-image.html
IMAGE bugs vis bug26973: bug26973_obj_with_trsf.png differs
IMAGE bugs vis bug26973: bug26973_view_with_trsf.png differs
IMAGE bugs vis bug26973: bug26973_obj_wo_trsf.png differs
IMAGE bugs vis bug26973: bug26973_view_wo_trsf.png differs
IMAGE bugs vis bug27986_2: bug27986_2.png differs - This difference is expected
IMAGE bugs vis bug27817: bug27817.png differs - This difference is expected
Dear kgv,
Branch [archived branch] has been rejected due to:
- compilation errors
- regressions/differences/improvements
- differences in images
Branch [archived branch] has been rejected due to:
- compilation errors
- regressions/differences/improvements
- differences in images
Branch [archived branch] has been updated forcibly by Commenter 2.
[revision removed]
[revision removed]
Branch [archived branch] has been updated by Commenter 2.
[revision removed]
Detailed log of new commits:
Author: Commenter 2
Date: Sat Dec 10 12:22:57 2016 +0300
StdSelect_Shape - set highlighting style as a link to the own drawer.
[revision removed]
Detailed log of new commits:
Author: Commenter 2
Date: Sat Dec 10 12:22:57 2016 +0300
StdSelect_Shape - set highlighting style as a link to the own drawer.
Branch [archived branch] has been created by Commenter 2.
[revision removed]
Detailed log of new commits:
Author: Commenter 2
Date: Wed Nov 2 17:36:18 2016 +0300
0025695: Visualization, AIS_InteractiveContext - define default HilightMode
AIS_InteractiveContext - removed the following unused properties:
- PreSelectionColor(), DefaultColor(), WasCurrentTouched(), ZDetection().
AIS_InteractiveObject - removed unused property SelectionPriority().
Prs3d_Drawer - removed properties HighlightStyle() and SelectionStyle().
Graphic3d_HighlightStyle has been superseded by Prs3d_Drawer
inheriting from new class Graphic3d_PresentationAttributes.
Graphic3d_PresentationAttributes (as Graphic3d_HighlightStyle replacement)
has been extended with new properties:
- ZLayer() defining Z-Layer for highlighting presentation.
- DisplayMode() defining display mode for highlighting.
StdSelect_BRepSelectionTool methods have been corrected to take
SelectMgr_EntityOwner instead of StdSelect_BRepOwner.
StdSelect_Shape - duplicated field myDrawer has been dropped.
AIS_InteractiveObject - myDrawer->Color() is now used instead of myOwnColor,
myDrawer->Transparency() instead of myTransparency
and myDrawer->ZLayer() instead of myZLayer.
PrsMgr_PresentationManager::Unhighlight() now unhighlight all modes.
The method taking Mode as argument has been marked deprecated.
New enumeration Prs3d_TypeOfHighlight has been introduced
defining different highlight types.
AIS_InteractiveObject::HighlightStyle() now takes enumeration argument
and defines different styles for Global and Local selection.
ComesFromDecomposition() property has been moved
from StdSelect_BRepOwner to SelectMgr_EntityOwner.
[revision removed]
Detailed log of new commits:
Author: Commenter 2
Date: Wed Nov 2 17:36:18 2016 +0300
0025695: Visualization, AIS_InteractiveContext - define default HilightMode
AIS_InteractiveContext - removed the following unused properties:
- PreSelectionColor(), DefaultColor(), WasCurrentTouched(), ZDetection().
AIS_InteractiveObject - removed unused property SelectionPriority().
Prs3d_Drawer - removed properties HighlightStyle() and SelectionStyle().
Graphic3d_HighlightStyle has been superseded by Prs3d_Drawer
inheriting from new class Graphic3d_PresentationAttributes.
Graphic3d_PresentationAttributes (as Graphic3d_HighlightStyle replacement)
has been extended with new properties:
- ZLayer() defining Z-Layer for highlighting presentation.
- DisplayMode() defining display mode for highlighting.
StdSelect_BRepSelectionTool methods have been corrected to take
SelectMgr_EntityOwner instead of StdSelect_BRepOwner.
StdSelect_Shape - duplicated field myDrawer has been dropped.
AIS_InteractiveObject - myDrawer->Color() is now used instead of myOwnColor,
myDrawer->Transparency() instead of myTransparency
and myDrawer->ZLayer() instead of myZLayer.
PrsMgr_PresentationManager::Unhighlight() now unhighlight all modes.
The method taking Mode as argument has been marked deprecated.
New enumeration Prs3d_TypeOfHighlight has been introduced
defining different highlight types.
AIS_InteractiveObject::HighlightStyle() now takes enumeration argument
and defines different styles for Global and Local selection.
ComesFromDecomposition() property has been moved
from StdSelect_BRepOwner to SelectMgr_EntityOwner.
Please test updated patch in branch CR25695_3.
Branch [archived branch] has been created by Commenter 2.
[revision removed]
Detailed log of new commits:
Author: Commenter 2
Date: Mon Dec 12 12:54:25 2016 +0300
0028213: Visualization, StdPrs_ShadedShape - compute face edges for triangulation-only Faces
[revision removed]
Detailed log of new commits:
Author: Commenter 2
Date: Mon Dec 12 12:54:25 2016 +0300
0028213: Visualization, StdPrs_ShadedShape - compute face edges for triangulation-only Faces
Dear Commenter 3,
Branch CR25695_3 from occt git-repository (and CR25695_3 from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
[revision removed]
Number of compiler warnings:
occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)
products component :
Linux: 63 (63 on master)
Windows: 0 (0 on master)
MacOS : 1137
Regressions/Differences/Improvements:
No regressions/differences
Testing cases:
http://occt-tests/CR25695_3-CR25695_3-OCCT/Debian70-64/bugs/vis/bug25695.html
http://occt-tests/CR25695_3-CR25695_3-OCCT/Windows-64-VC10/bugs/vis/bug25695.html
bugs vis bug25695: OK
Testing on Linux:
occt component :
Total MEMORY difference: 93053591 / 92244004 [+0.88%]
Total CPU difference: 21594.29000000011 / 21539.100000000275 [+0.26%]
products component :
Total MEMORY difference: 30067814 / 30095445 [-0.09%]
Total CPU difference: 5323.639999999979 / 5303.47999999998 [+0.38%]
Testing on Windows:
occt component :
http://occt-tests/CR25695_3-CR25695_3-OCCT/Windows-64-VC10-cpu/diff-Windows-64-VC10-cpu.html
CPU v3d raytrace sample_cube_twosided: 9.3444599 / 4.5708293 [+104.44%]
Total MEMORY difference: 58459725 / 58458666 [+0.00%]
Total CPU difference: 20064.692618998626 / 20176.670136798508 [-0.55%]
products component :
Total MEMORY difference: 20894763 / 20859840 [+0.17%]
Total CPU difference: 5301.537983999972 / 5125.865257899959 [+3.43%]
There are following differences in images found by testdiff.
http://occt-tests/CR25695_3-CR25695_3-OCCT/Debian70-64/diff-Debian70-64.html
http://occt-tests/CR25695_3-CR25695_3-OCCT/Windows-64-VC10/diff-Windows-64-VC10-image.html
IMAGE bugs vis bug27986_2: bug27986_2.png differs - This difference is expected
IMAGE bugs vis bug27817: bug27817.png differs - This difference is expected
Branch CR25695_3 from occt git-repository (and CR25695_3 from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
[revision removed]
Number of compiler warnings:
occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)
products component :
Linux: 63 (63 on master)
Windows: 0 (0 on master)
MacOS : 1137
Regressions/Differences/Improvements:
No regressions/differences
Testing cases:
http://occt-tests/CR25695_3-CR25695_3-OCCT/Debian70-64/bugs/vis/bug25695.html
http://occt-tests/CR25695_3-CR25695_3-OCCT/Windows-64-VC10/bugs/vis/bug25695.html
bugs vis bug25695: OK
Testing on Linux:
occt component :
Total MEMORY difference: 93053591 / 92244004 [+0.88%]
Total CPU difference: 21594.29000000011 / 21539.100000000275 [+0.26%]
products component :
Total MEMORY difference: 30067814 / 30095445 [-0.09%]
Total CPU difference: 5323.639999999979 / 5303.47999999998 [+0.38%]
Testing on Windows:
occt component :
http://occt-tests/CR25695_3-CR25695_3-OCCT/Windows-64-VC10-cpu/diff-Windows-64-VC10-cpu.html
CPU v3d raytrace sample_cube_twosided: 9.3444599 / 4.5708293 [+104.44%]
Total MEMORY difference: 58459725 / 58458666 [+0.00%]
Total CPU difference: 20064.692618998626 / 20176.670136798508 [-0.55%]
products component :
Total MEMORY difference: 20894763 / 20859840 [+0.17%]
Total CPU difference: 5301.537983999972 / 5125.865257899959 [+3.43%]
There are following differences in images found by testdiff.
http://occt-tests/CR25695_3-CR25695_3-OCCT/Debian70-64/diff-Debian70-64.html
http://occt-tests/CR25695_3-CR25695_3-OCCT/Windows-64-VC10/diff-Windows-64-VC10-image.html
IMAGE bugs vis bug27986_2: bug27986_2.png differs - This difference is expected
IMAGE bugs vis bug27817: bug27817.png differs - This difference is expected
Dear kgv,
Branch [archived branch] has been rejected due to:
- CPU problems
Branch [archived branch] has been rejected due to:
- CPU problems
Please switch bug to TESTED.
Branch [archived branch] has been updated by Commenter 2.
[revision removed]
Detailed log of new commits:
Author: Commenter 2
Date: Tue Dec 13 12:36:41 2016 +0300
0028215: Visualization - define EMPTY type line for consistenct with Interior Style
Added new values Aspect_TOL_EMPTY (line type) and Aspect_TOM_EMPTY (marker type).
[revision removed]
Detailed log of new commits:
Author: Commenter 2
Date: Tue Dec 13 12:36:41 2016 +0300
0028215: Visualization - define EMPTY type line for consistenct with Interior Style
Added new values Aspect_TOL_EMPTY (line type) and Aspect_TOM_EMPTY (marker type).
Branch [archived branch] has been deleted by Commenter 2.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Commenter 2.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Commenter 2.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Commenter 2.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Commenter 2.
[revision removed]
[revision removed]
Related records
- #0027818 · related to · closedVisualization - provide an interface to define highlight presentation properties
- #0029500 · parent of · closedVisualization - AIS_Point dynamic highlighting is not drawn on RedrawImmediate
- #0032056 · parent of · closedCoding Rules - remove package MMgt and other types deprecated since OCCT 7.2.0
- #0032230 · parent of · closedCoding Rules - remove class headers Graphic3d_HighlightStyle.hxx deprecated since OCCT 7.2.0
- #0032428 · parent of · closedDocumentation, AIS_InteractiveContext - put cross-references between MoveTo() and HighlightStyle()