DiscussionsIssue archiveOCCT:Modeling Algorithms

Archived issue #0025757

distmini returns wrong solution for ellipse/vertex

CommunityOCCT:Modeling Algorithmsclosed11 public notes

Search issues

Description

> Looking at the script you will notice that the only difference between vertex1 and vertex2, is vertex1 has an additional 9 on the y component.

Thomas has already pointed this out on the oce-dev mailing list. In fact the problem is reproduce-able in the current OCCT development version, as well.

Steps to reproduce

Draw[1]> Draw[2]> source Attachment 1 (TXT)
vertex1 distance = 5.7574949687856307
vertex2 distance = 5.[revision removed]-15
Draw[3]>

Additional information

Public activity

11 archived notes

Participants are labeled by their role within this record.

01Commenter 1
Alexander, please look if time.
02Commenter 2
Branch [archived branch] has been created by Participant.

[revision removed]


Detailed log of new commits:

Author: aml
Date: Fri Feb 6 15:56:08 2015 +0300

    0025757: distmini returns wrong solution for ellipse/vertex
    
    Analytical handling of degenerated cases added.
03Commenter 3
Dear msv,
Please check current state of branch CR25757.
04Commenter 4
Reviewed.
05Commenter 5
Dear Commenter 1,
Branch CR25757 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]

Number of compiler warnings:

occt component :
Linux: 18 (18 on master)
Windows: 0 (0 on master)

products component :
Linux: 11 (11 on master)
Windows: 1 (1 on master)

Regressions/Differences:
No regressions/differences

Testing cases:
http://occt-tests/CR25757-master-occt/Windows-32-VC10/bugs/fclasses/bug25757.html
bugs fclasses(002) bug25757: OK

Testing on Linux:
occt component :
Total MEMORY difference: 84599490 / 86208664
Total CPU difference: 49301.48 / 47876.709999999846
products component :
Total MEMORY difference: 23063368 / 23139894
Total CPU difference: 15240.159999999978 / 14598.869999999963

Testing on Windows:
occt component :
Total MEMORY difference: 40649664 / 40658496
Total CPU difference: 36779.4375 / 32754.0
products component :
Total MEMORY difference: 11034483 / 11081969
Total CPU difference: 10886.78125 / 10978.125

There are no differences in images found by testdiff.
06Commenter 2
Branch [archived branch] has been updated by Participant.

[revision removed]


Detailed log of new commits:

Author: mkv
Date: Wed Feb 11 18:43:24 2015 +0300

    Test case for issue CR25757

07Commenter 7
Dear aml,
could you please review test case
bugs fclasses(002) bug25757
08Commenter 8
Dear mkv,

1) Change expected distance to the 0.0 in both cases.
2) "tol_abs_dist" may be decreased to 1e-12.
3) "tol_rel_dist" should changed to pass tests.
09Commenter 2
Branch [archived branch] has been updated by Participant.

[revision removed]


Detailed log of new commits:

Author: mkv
Date: Thu Feb 12 11:35:51 2015 +0300

    Correction of test case for issue CR25757

10Commenter 10
Branch CR25757 is TESTED.
11Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]