DiscussionsIssue archiveOCCT:Modeling Algorithms

Archived issue #0025788

Parallelization of the BOP Builder algorithm on second level

Open CASCADEOCCT:Modeling Algorithmsclosed14 public notes

Search issues

Description

Parallelization of the BOP Builder algorithm on second level.

The attached document shows the measurements of the performance of the most time consuming parts of the Builder algorithm on OCCT test cases.

Steps to reproduce

#Use the following commands to check improvement of the performance:

source zboxholes

bclearobjects; bcleartools;
baddobjects b1
baddtools b2

brunparallel 1

dchrono cpu reset
dchrono cpu start
bcut r b1 b2
dchrono cpu stop
dchrono cpu show
#
#------------------------------------------
#the results obtained [station: PETREX, optimized mode]

branch:
Elapsed time: 0 Hours 0 Minutes 8.09207130119 Seconds

dev:
Elapsed time: 0 Hours 0 Minutes 28.8896280681 Seconds

Public activity

14 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Participant.

[revision removed]


No new revisions were added by this update.
02Commenter 2
Branch [archived branch] has been updated by Participant.

[revision removed]


Detailed log of new commits:

Author: pkv
Date: Fri Feb 6 07:31:20 2015 +0300

    v1.0
    I. New features:
    No new features.
    
    II. Changes:
    II.1. class BOPAlgo_Builder
    method:
      void BOPAlgo_Builder::FillIn3DParts
      (BOPCol_DataMapOfShapeListOfShape&,
       BOPCol_DataMapOfShapeShape&,
       const BOPCol_BaseAllocator& )
    has been optimized and
    modified to provide parallel treatment.
    
    III. Modified entities:
    packages:
    BOPAlgo

03Commenter 3
Git branch CR25788 is ready to be reviewed.
04Commenter 4
Reviewed.
05Commenter 2
Branch [archived branch] has been updated forcibly by Participant.

[revision removed]
06Commenter 2
Branch [archived branch] has been updated forcibly by Participant.

[revision removed]
07Commenter 7
Dear Commenter 1,
Branch CR25788 from occt git-repository was compiled on Linux and Windows platforms.
[revision removed]

There are following compilation errors:
http://jenkins-test-03.nnov.opencascade.com:8080/user/mnt/my-views/view/CR25788/job/mnt-CR25788-master_build_occt_linux/1/parsed_console/
../../../../src/BOPAlgo/BOPAlgo_Builder_3.cxx:484: error: expected initializer before ‘<’ token
../../../../src/BOPAlgo/BOPAlgo_Builder_3.cxx:490: error: expected initializer before ‘<’ token
../../../../src/BOPAlgo/BOPAlgo_Builder_3.cxx: In member function ‘virtual void BOPAlgo_Builder::FillIn3DParts(BOPCol_DataMapOfShapeListOfShape&, BOPCol_DataMapOfShapeShape&, const BOPCol_BaseAllocator&)’:
../../../../src/BOPAlgo/BOPAlgo_Builder_3.cxx:661: error: ‘BOPAlgo_FillIn3DPartsCnt’ has not been declared
make[2]: *** [BOPAlgo_Builder_3.lo] Error 1
08Commenter 2
Branch [archived branch] has been updated by Participant.

[revision removed]


Detailed log of new commits:

Author: mkv
Date: Fri Feb 6 15:28:38 2015 +0300

    Correction of compilation errors

09Commenter 9
Dear Commenter 1,
Branch CR25788 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]

Number of compiler warnings:

occt component :
Linux: 18 (18 on master)
Windows: 0 (0 on master)

products component :
Linux: 11 (11 on master)
Windows: 1 (1 on master)

Regressions/Differences:
No regressions/differences

Testing cases:
http://occt-tests/CR25788-master-occt/Debian60-64/bugs/modalg_5/bug25788.html
http://occt-tests/CR25788-master-occt/Windows-32-VC10/bugs/modalg_5/bug25788.html
bugs modalg_5(010) bug25788: OK

Testing on Linux:
occt component :
Total MEMORY difference: 84559893 / 86244247
Total CPU difference: 50908.60999999997 / 47876.559999999845
products component :
Total MEMORY difference: 22945015 / 22989111
Total CPU difference: 15687.729999999981 / 14506.069999999965

Testing on Windows:
occt component :
Total MEMORY difference: 40648799 / 40658496
Total CPU difference: 34839.40625 / 32754.0
products component :
Total MEMORY difference: 11034951 / 11081969
Total CPU difference: 10456.0625 / 10978.125

There are no differences in images found by testdiff.
10Commenter 2
Branch [archived branch] has been updated by Participant.

[revision removed]


Detailed log of new commits:

Author: mkv
Date: Tue Feb 10 18:39:47 2015 +0300

    Test cases for issue CR25788

11Commenter 11
Dear pkv,
could you please review test case
bugs modalg_5(010) bug25788
12Commenter 12
test case
bugs modalg_5(010) bug25788
is reviewed
13Commenter 13
Branch CR25788 is TESTED.
14Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]