OCCT3D
DiscussionsIssue archiveOCCT:Visualization

Archived issue #0025867

Visualization, TKOpenGl - fix misprint in transformation persistence math

Open CASCADEOCCT:Visualizationclosed9 public notes

Search issues

Description

The following code has misprint with missing aWinX, which causes misbehavior of transformation persistence algorithm:
    OpenGl_Utils::Project<Standard_Real> (theTransPers->pointX,
                                          theTransPers->pointY,
                                          theTransPers->pointZ,
                                          aModelMatrix,
                                          aProjMatrix,
                                          aViewport,
                                          aWinZ,
                                          aWinY,
                                          aWinZ);


this is regression after #0024381.

Steps to reproduce

test bugs vis bug25867

Public activity

9 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Wed Feb 25 14:52:03 2015 +0300

    0025867: Visualization, TKOpenGl - fix misprint in transformation persistence math
02Author
Dear aba,

please add test cases to the patch.
03Commenter 2
Branch [archived branch] has been updated by Participant.

[revision removed]


Detailed log of new commits:

Author: aba
Date: Wed Feb 25 16:17:22 2015 +0300

    Added test case

04Commenter 4
Test case for zoom transform persistence was added.

Dear kgv,

please review.
05Author
Please test the patch.
06Commenter 2
Branch [archived branch] has been updated forcibly by Participant.

[revision removed]
07Commenter 7
Branch [archived branch] has been rebased on the current master
08Commenter 8
Dear Commenter 1,

Branch CR25867 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
[revision removed]

Number of compiler warnings:
occt component:
   Linux: 18 (18 on master)
   Windows: 2 (2 on master)
products component:
   Linux: 11 (11 on master)
   Windows: 4 (4 on master)

Regressions/Differences:
Not detected

Testing cases:
bugs vis(004) bug25867 - OK
http://occt-tests/CR25867-master-occt-64/Debian60-64/bugs/vis/bug25867.html
http://occt-tests/CR25867-master-occt-64/Windows-64-VC10/bugs/vis/bug25867.html

Testing on Linux:
Total MEMORY difference: 91519881 / 91839889
Total CPU difference: 55839.72000000016 / 59519.03999999998

Testing on Windows:
Total MEMORY difference: 57942999 / 57944267
Total CPU difference: 40423.75 / 38926.375
09Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]

Related records