Archived issue #0025955

Visualization, AIS_Shape::UnsetColor() - fix storing color in a local variable

CommunityOCCT:Visualizationclosed5 public notes

Description

Quantity_Color aColor = aDefaultMat.AmbientColor();
if (myDrawer->HasLink())
{
Quantity_Color aColor = myDrawer->Link()->ShadingAspect()->Color (myCurrentFacingModel);
}
mat.SetColor (aColor);

Steps to reproduce

Not applicable.

Public activity

5 archived notes

Participants are labeled by their role within this record.

01Commenter 22015-03-17 20:28

Branch [archived branch] has been created by Author.

[revision removed]

Detailed log of new commits:

Author: Author
Date: Tue Mar 17 18:27:49 2015 +0100

Removed the color declaration overriding another variable.

02Author2015-03-17 20:29

Branch 25955 pushed. Please review.

03Commenter 32015-03-19 09:21

Please test the patch

04Commenter 42015-03-19 16:17

Dear Commenter 1,

Branch CR25955 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
[revision removed]

Number of compiler warnings:
occt component:
   Linux: 18 (18 on master)
   Windows: 0 (0 on master)
products component:
   Linux: 11 (11 on master)
   Windows: 4 (4 on master)

Regressions/Differences:
Not detected

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 89826858 / 90001620
Total CPU difference: 58339.789999999986 / 58911.169999999984

Testing on Windows:
Total MEMORY difference: 58088432 / 58093704
Total CPU difference: 48598.46875 / 57284.859375

05Commenter 22015-04-09 09:49

Branch [archived branch] has been deleted by Commenter 3.

[revision removed]