Archived issue #0026035

Length dimension can't be built between two vertices in Draw

Open CASCADEOCCT:DRAWclosed13 public notes

Search issues

Description

In Draw length dimension can't be built between two vertices if they were created with the command "vertex". If create two points with command "vpoint" with the same coordinates then dimension is drawn correctly.

Steps to reproduce

bugs vis bug26035_1
bugs vis bug26035_2
bugs vis bug26035_3
bugs vis bug26035_4
bugs vis bug26035_5
bugs vis bug26035_6

Public activity

13 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Thu Apr 9 11:03:41 2015 +0300

    Fixed drawing length dimension between two vertices in Draw.
02Commenter 2
Dear Andrey,

please review patch in occt branch CR26035
03Commenter 3
+          TopoDS_Vertex aVertex1 = TopoDS::Vertex ((Handle(AIS_Shape)::DownCast(aShapes.First ()))->Shape());

this will raise exception if not TopoDS_Vertex will be passed.
Please add ShapeType() check to the command.
04Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
05Commenter 5
Dear Kirill,

please review update for the patch in branch CR26035
06Commenter 3
The patch breaks the following test case:
pload MODELING VISUALIZATION
box b 100 200 300
vinit View1
vclear
vaxo
explode b F
vdisplay b_1 b_2
vdimension len -length -shapes b_1 b_2 -plane zox
vfit
07Commenter 7
Dear dbv,

please consider, that length dimension can be built on two shapes of different kinds (not only on vertices, but also edges and faces) according to AIS_LengthDimension interface.
08Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
09Commenter 9
Fixed drawing length dimension for two vertices in Draw
Fixed exception when trying to draw length dimension for face-point or point-face
Fixed drawing length dimension for edge-vertex/point and vertex/point-edge

Btw, why there is no ability in AIS_LengthDimension to draw dimension between face and vertex?

Dear Kirill,

please review latest patch in branch CR26035
10Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
11Commenter 3
Please test the patch.
12Commenter 12
Dear Commenter 1,
Branch CR26035 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]

Number of compiler warnings:

occt component :
Linux: 18 (18 on master)
Windows: 0 (0 on master)

products component :
Linux: 4 (4 on master)
Windows: 0 (0 on master)

Regressions/Differences:
No regressions/differences

Testing cases:

http://occt-tests/CR26035-master-occt-64/Debian60-64/bugs/vis/bug26035_1.html
http://occt-tests/CR26035-master-occt-64/Windows-64-VC10/bugs/vis/bug26035_1.html
bugs vis(004) bug26035_1: OK

http://occt-tests/CR26035-master-occt-64/Debian60-64/bugs/vis/bug26035_2.html
http://occt-tests/CR26035-master-occt-64/Windows-64-VC10/bugs/vis/bug26035_2.html
bugs vis(004) bug26035_2: OK

http://occt-tests/CR26035-master-occt-64/Debian60-64/bugs/vis/bug26035_3.html
http://occt-tests/CR26035-master-occt-64/Windows-64-VC10/bugs/vis/bug26035_3.html
bugs vis(004) bug26035_3: OK

http://occt-tests/CR26035-master-occt-64/Debian60-64/bugs/vis/bug26035_4.html
http://occt-tests/CR26035-master-occt-64/Windows-64-VC10/bugs/vis/bug26035_4.html
bugs vis(004) bug26035_4: OK

http://occt-tests/CR26035-master-occt-64/Debian60-64/bugs/vis/bug26035_5.html
http://occt-tests/CR26035-master-occt-64/Windows-64-VC10/bugs/vis/bug26035_5.html
bugs vis(004) bug26035_5: OK

http://occt-tests/CR26035-master-occt-64/Debian60-64/bugs/vis/bug26035_6.html
http://occt-tests/CR26035-master-occt-64/Windows-64-VC10/bugs/vis/bug26035_6.html
bugs vis(004) bug26035_6: OK

Testing on Linux:
occt component :
Total MEMORY difference: 93986008 / 94253387 [-0.28%]
Total CPU difference: 58571.41999999937 / 56192.6999999997 [+4.23%]
products component :
Total MEMORY difference: 23688711 / 23689725 [-0.00%]
Total CPU difference: 19417.829999999973 / 19042.799999999963 [+1.97%]

Testing on Windows:
occt component :
Total MEMORY difference: 57126709 / 57127349 [-0.00%]
Total CPU difference: 15876.455771499132 / 15976.514812898899 [-0.63%]
products component :
Total MEMORY difference: 15477003 / 15478724 [-0.01%]
Total CPU difference: 6369.7704316 / 6217.388654799964 [+2.45%]

There are no differences in images found by testdiff.
13Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]