Archived issue #0026150

BRepOffsetAPI_ThruSections doesn't implement history method Generated().

CommunityOCCT:Modeling Algorithmsclosed25 public notes

Description

The history method BRepOffsetAPI_ThruSections::Generated don't have implementation. Without the history, it's difficult to implement parametric feature.

There is a method related to history:
TopoDS_Shape BRepOffsetAPI_ThruSections::GeneratedFace (const TopoDS_Shape& Edge) const; but this method won't work if there are punctural vertex or edge splitting for compatibility checking.

Steps to reproduce

See test cases

bugs modalg_6 bug26150_*

Public activity

25 archived notes

Participants are labeled by their role within this record.

01Commenter 22017-01-24 16:29

Branch [archived branch] has been created by Participant.

[revision removed]

Detailed log of new commits:

Author: jgv
Date: Tue Jan 24 16:27:13 2017 +0300

    0026150: BRepOffsetAPI_ThruSections doesn't implement history method Generated().

    Virtual method Generated is redefined. Now it returns:

    - chain of generated faces for sub-edge of a profile;
    - chain of generated edges for sub-vertex of a profile;
    - bunch of chains of generated edges for start or end vertex if it is degenerated section.

02Commenter 22017-01-24 16:31

Please review the branch CR26150.

03Commenter 32017-01-25 16:34

src\BRepOffsetAPI\BRepOffsetAPI_ThruSections.hxx
- 150: BRepOffsetAPI_MakeShape => BRepBuilderAPI_MakeShape

src\BRepOffsetAPI\BRepOffsetAPI_ThruSections.cxx
- myNbEdgesInSection is not initialized in ctor.
- Please insert more comments for not trivial code.

src\BRepTest\BRepTest_SweepCommands.cxx
- 968: add a short description of the genthrus command in its help.
- 443: add check for null pointer Generator.
- 454,834: use const& for Shells.
- 454: In addition, the name "Shells" is not relevant here, since it returns edges or faces.

04Commenter 22017-01-26 13:22

Branch [archived branch] has been updated by Participant.

[revision removed]

Detailed log of new commits:

Author: jgv
Date: Thu Jan 26 13:21:49 2017 +0300

Correction according to the remarks.

05Commenter 52017-01-26 13:22

Please review updated branch.

06Commenter 62017-01-26 16:15

Reviewed.

07Commenter 22017-01-26 17:53

Branch [archived branch] has been updated forcibly by Participant.

[revision removed]

08Commenter 82017-01-27 16:30

Dear Commenter 1,
Branch CR26150 was rebased on IR-2017-01-26 of occt git-repository.
[revision removed]

09Commenter 92017-01-27 16:31

Dear Commenter 1,
Branch CR26150 from occt git-repository (and IR-2017-01-26 from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]

Number of compiler warnings:

occt component :
Linux: 7 (0 on master)
Windows: 0 (0 on master)
MacOS : 5 (0 on master)

products component :
Linux: 63 (63 on master)
Windows: 0 (0 on master)
MacOS : 1142

There are new additional compilation warnings on Linux and MacOS platforms:
http://jenkins-test-07.nnov.opencascade.com:8080/user/mnt/my-views/view/A_mnt_warnings/portlet/dashboard_portlet_13912/job/CR26150-master-OCCT-Debian70-64-opt-compile/1/warnings17Result/
BRepFill_CompatibleWires.cxx:752, GNU C Compiler 4 (gcc), Priority: Normal
type qualifiers ignored on function return type [-Wignored-qualifiers]
BRepFill_CompatibleWires.cxx:761, GNU C Compiler 4 (gcc), Priority: Normal
type qualifiers ignored on function return type [-Wignored-qualifiers]
BRepFill_CompatibleWires.hxx:67, GNU C Compiler 4 (gcc), Priority: Normal
type qualifiers ignored on function return type [-Wignored-qualifiers]
BRepFill_CompatibleWires.hxx:69, GNU C Compiler 4 (gcc), Priority: Normal
type qualifiers ignored on function return type [-Wignored-qualifiers]
BRepOffsetAPI_ThruSections.cxx:247, GNU C Compiler 4 (gcc), Priority: Normal
when initialized here [-Wreorder]
BRepOffsetAPI_ThruSections.hxx:184, GNU C Compiler 4 (gcc), Priority: Normal
'Standard_Real BRepOffsetAPI_ThruSections::myPres3d' [-Wreorder]
BRepOffsetAPI_ThruSections.hxx:188, GNU C Compiler 4 (gcc), Priority: Normal
'BRepOffsetAPI_ThruSections::myDegen2' will be initialized after [-Wreorder]

http://jenkins-test-07.nnov.opencascade.com:8080/user/mnt/my-views/view/A_mnt_warnings/portlet/dashboard_portlet_13912/job/CR26150-master-OCCT-MacOS-opt-compile/1/warnings7Result/
BRepFill_CompatibleWires.cxx:752, Clang (LLVM based), Priority: Normal
'const' type qualifier on return type has no effect
BRepFill_CompatibleWires.cxx:761, Clang (LLVM based), Priority: Normal
'const' type qualifier on return type has no effect
BRepFill_CompatibleWires.hxx:67, Clang (LLVM based), Priority: Normal
'const' type qualifier on return type has no effect
BRepFill_CompatibleWires.hxx:69, Clang (LLVM based), Priority: Normal
'const' type qualifier on return type has no effect
BRepOffsetAPI_ThruSections.cxx:251, Clang (LLVM based), Priority: Normal
field 'myDegen2' will be initialized after field 'myPres3d'

Regressions/Differences/Improvements:
http://occt-tests/CR26150-master-OCCT/Debian70-64/bugs/modalg_6/bug27386_5.html
http://occt-tests/CR26150-master-OCCT/Windows-64-VC10/bugs/modalg_6/bug27386_5.html
bugs modalg_6 bug27386_5: FAILED

Testing cases:
http://occt-tests/CR26150-master-OCCT/Debian70-64/bugs/modalg_6/bug26150_1.html
http://occt-tests/CR26150-master-OCCT/Windows-64-VC10/bugs/modalg_6/bug26150_1.html
bugs modalg_6 bug26150_1: OK
http://occt-tests/CR26150-master-OCCT/Debian70-64/bugs/modalg_6/bug26150_2.html
http://occt-tests/CR26150-master-OCCT/Windows-64-VC10/bugs/modalg_6/bug26150_2.html
bugs modalg_6 bug26150_2: OK
http://occt-tests/CR26150-master-OCCT/Debian70-64/bugs/modalg_6/bug26150_3.html
http://occt-tests/CR26150-master-OCCT/Windows-64-VC10/bugs/modalg_6/bug26150_3.html
bugs modalg_6 bug26150_3: OK
http://occt-tests/CR26150-master-OCCT/Debian70-64/bugs/modalg_6/bug26150_4.html
http://occt-tests/CR26150-master-OCCT/Windows-64-VC10/bugs/modalg_6/bug26150_4.html
bugs modalg_6 bug26150_4: OK
http://occt-tests/CR26150-master-OCCT/Debian70-64/bugs/modalg_6/bug26150_5.html
http://occt-tests/CR26150-master-OCCT/Windows-64-VC10/bugs/modalg_6/bug26150_5.html
bugs modalg_6 bug26150_5: OK
http://occt-tests/CR26150-master-OCCT/Debian70-64/bugs/modalg_6/bug26150_6.html
http://occt-tests/CR26150-master-OCCT/Windows-64-VC10/bugs/modalg_6/bug26150_6.html
bugs modalg_6 bug26150_6: OK
http://occt-tests/CR26150-master-OCCT/Debian70-64/bugs/modalg_6/bug26150_7.html
http://occt-tests/CR26150-master-OCCT/Windows-64-VC10/bugs/modalg_6/bug26150_7.html
bugs modalg_6 bug26150_7: OK
http://occt-tests/CR26150-master-OCCT/Debian70-64/bugs/modalg_6/bug26150_8.html
http://occt-tests/CR26150-master-OCCT/Windows-64-VC10/bugs/modalg_6/bug26150_8.html
bugs modalg_6 bug26150_8: OK
http://occt-tests/CR26150-master-OCCT/Debian70-64/bugs/modalg_6/bug26150_9.html
http://occt-tests/CR26150-master-OCCT/Windows-64-VC10/bugs/modalg_6/bug26150_9.html
bugs modalg_6 bug26150_9: OK
http://occt-tests/CR26150-master-OCCT/Debian70-64/bugs/modalg_6/bug26150_10.html
http://occt-tests/CR26150-master-OCCT/Windows-64-VC10/bugs/modalg_6/bug26150_10.html
bugs modalg_6 bug26150_10: OK
http://occt-tests/CR26150-master-OCCT/Debian70-64/bugs/modalg_6/bug26150_11.html
http://occt-tests/CR26150-master-OCCT/Windows-64-VC10/bugs/modalg_6/bug26150_11.html
bugs modalg_6 bug26150_11: OK
http://occt-tests/CR26150-master-OCCT/Debian70-64/bugs/modalg_6/bug26150_12.html
http://occt-tests/CR26150-master-OCCT/Windows-64-VC10/bugs/modalg_6/bug26150_12.html
bugs modalg_6 bug26150_12: OK
http://occt-tests/CR26150-master-OCCT/Debian70-64/bugs/modalg_6/bug26150_13.html
http://occt-tests/CR26150-master-OCCT/Windows-64-VC10/bugs/modalg_6/bug26150_13.html
bugs modalg_6 bug26150_13: OK
http://occt-tests/CR26150-master-OCCT/Debian70-64/bugs/modalg_6/bug26150_14.html
http://occt-tests/CR26150-master-OCCT/Windows-64-VC10/bugs/modalg_6/bug26150_14.html
bugs modalg_6 bug26150_14: OK

Testing on Linux:
occt component :
Total MEMORY difference: 91761346 / 92261126 [-0.54%]
Total CPU difference: 19945.040000000245 / 19913.840000000215 [+0.16%]
products component :
Total MEMORY difference: 31447330 / 31477908 [-0.10%]
Total CPU difference: 5604.689999999981 / 5544.959999999981 [+1.08%]

Testing on Windows:
occt component :
Total MEMORY difference: 57622346 / 57617820 [+0.01%]
Total CPU difference: 18418.53886679849 / 18683.147762998648 [-1.42%]
products component :
Total MEMORY difference: 22659099 / 22621210 [+0.17%]
Total CPU difference: 5572.012517799986 / 5570.546108399986 [+0.03%]

There are no differences in images found by testdiff.

10Commenter 102017-01-27 16:31

Dear jgv,
Branch [archived branch] has been rejected due to:
- additional warnings
- regressions/differences/improvements

11Commenter 22017-02-02 16:22

Branch [archived branch] has been created by Participant.

[revision removed]

Detailed log of new commits:

Author: jgv
Date: Thu Feb 2 16:20:40 2017 +0300

    Fix compiler's warnings and add 4 new test cases.

Author: jgv
Date: Thu Jan 26 13:21:49 2017 +0300

    Correction according to the remarks.

Author: jgv
Date: Tue Jan 24 16:27:13 2017 +0300

    0026150: BRepOffsetAPI_ThruSections doesn't implement history method Generated().

    Virtual method Generated is redefined. Now it returns:

    - chain of generated faces for sub-edge of a profile;
    - chain of generated edges for sub-vertex of a profile;
    - bunch of chains of generated edges for start or end vertex if it is degenerated section.

12Commenter 122017-02-02 16:23

Please test the branch CR26150-1.

13Commenter 22017-02-02 16:49

Branch [archived branch] has been updated by Participant.

[revision removed]

Detailed log of new commits:

Author: jgv
Date: Thu Feb 2 16:49:24 2017 +0300

Correction of mistake.

14Commenter 142017-02-07 16:03

15Commenter 152017-02-07 16:04

Dear jgv,
Branch [archived branch] has been rejected due to:
- failed test-case for issue

16Commenter 22017-02-20 19:13

Branch [archived branch] has been updated forcibly by Participant.

[revision removed]

17Commenter 172017-02-21 13:09

Dear Commenter 1,
Branch CR26150-1 was rebased on current master of occt git-repository.
[revision removed]

18Commenter 182017-02-21 13:09

19Commenter 192017-02-21 13:10

Dear Commenter 1,
Branch CR26150-1 is TESTED.

20Commenter 22017-03-02 11:22

Branch [archived branch] has been created by Participant.

[revision removed]

Detailed log of new commits:

Author: msv
Date: Thu Mar 2 11:22:46 2017 +0300

// Compilation warnings are gone.

21Commenter 22017-03-02 13:09

Branch [archived branch] has been created by Participant.

[revision removed]

Detailed log of new commits:

Author: jgv
Date: Thu Mar 2 13:09:05 2017 +0300

    Fix of compiler warnings

Author: jgv
Date: Thu Feb 2 16:49:24 2017 +0300

    Correction of mistake.

Author: jgv
Date: Thu Feb 2 16:20:40 2017 +0300

    Fix compiler's warnings and add 4 new test cases.

Author: jgv
Date: Thu Jan 26 13:21:49 2017 +0300

    Correction according to the remarks.

Author: jgv
Date: Tue Jan 24 16:27:13 2017 +0300

    0026150: BRepOffsetAPI_ThruSections doesn't implement history method Generated().

    Virtual method Generated is redefined. Now it returns:

    - chain of generated faces for sub-edge of a profile;
    - chain of generated edges for sub-vertex of a profile;
    - bunch of chains of generated edges for start or end vertex if it is degenerated section.

22Commenter 22017-03-20 14:33

Branch [archived branch] has been deleted by Participant.

[revision removed]

23Commenter 22017-03-20 14:33

Branch [archived branch] has been deleted by Participant.

[revision removed]

24Commenter 22017-03-20 14:34

Branch [archived branch] has been deleted by Participant.

[revision removed]

25Commenter 22017-03-20 14:36

Branch [archived branch] has been deleted by Participant.

[revision removed]

Related records