DiscussionsIssue archiveOCCT:Shape Healing

Archived issue #0026182

Calling ShapeFix_FixSmallFace.RemoveSmallFaces() always leads to stack overflow

CommunityOCCT:Shape Healingclosed4 public notes

Search issues

Description

The functions ShapeFix_FixSmallFace::RemoveSmallFaces and SplitFaces call each other. Therefore, calling one of the functions always leads to a stack overflow.

The functions are defined as follows:

TopoDS_Shape ShapeFix_FixSmallFace::RemoveSmallFaces()
{
   myShape = SplitFaces();
   ...
}


TopoDS_Shape ShapeFix_FixSmallFace::SplitFaces()
{
   myShape = RemoveSmallFaces();
   ...
}


It seems, these functions currently have no use and should be removed or corrected.

Steps to reproduce

N/A

Public activity

4 archived notes

Participants are labeled by their role within this record.

01Commenter 1
Branch [archived branch] has been created by Participant.

[revision removed]


Detailed log of new commits:

Author: abv
Date: Wed May 6 06:20:29 2015 +0300

    0026182: Calling ShapeFix_FixSmallFace.RemoveSmallFaces() always leads to stack overflow
    
    Unused methods RemoveSmallFaces() and SplitFaces() are removed.
02Commenter 2
Offending methods removed, please integrate branch CR26182 (no testing is required)
03Commenter 3
Dear BugMaster,
Branch CR26182 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]

Number of compiler warnings:

occt component :
Linux: 18 (18 on master)
Windows: 0 (0 on master)

products component :
Linux: 4 (4 on master)
Windows: 0 (0 on master)
04Commenter 1
Branch [archived branch] has been deleted by Participant.

[revision removed]