Wrong result obtained by General Fuse operator.

Branch [archived branch] has been created by Author.

[revision removed]


No new revisions were added by this update.

Branch [archived branch] has been updated by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Fri May 22 11:14:37 2015 +0300

    0026253: Wrong result obtained by General Fuse operator.
    
    I. New features:
    No new features.
    
    II. Changes:
    II.1. class BOPAlgo_ShellSplitter
    - method:
    void BOPAlgo_ShellSplitter::SplitBlock(BOPTools_ConnexityBlock& aCB)
    It has changed the algorithm of separation shells.
    
    III. Modified entities:
    packages:
    BOPAlgo

Git branch CR26253 is ready to review.

Reviewed.

Branch [archived branch] has been updated forcibly by Participant.

[revision removed]

Dear Commenter 1,
Branch CR26253 was rebased on current master of occt git-repository.
[revision removed]

Dear Commenter 1,
Branch CR26253 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]

Number of compiler warnings:

occt component :
Linux: 25 (25 on master)
Windows: 0 (0 on master)

products component :
Linux: 37 (37 on master)
Windows: 0 (0 on master)

Regressions/Differences:
http://occt-tests/CR26253-master-occt-64/Debian70-64/summary.html
Improvements:
  boolean bcut_complex N9
  boolean gdml_private F8, K4, P7
  boolean volumemaker D8, D9
  feat featprism C4
Failed:
  boolean bcommon_complex C3
  boolean gdml_private H7, ZH5
  boolean volumemaker A4, B7, B8, C1, C6, D6, F2
  bugs modalg_5 bug25184
  perf ncollection A1
http://occt-tests/CR26253-master-occt-64/Windows-64-VC10/summary.html
Improvements:
  boolean bcut_complex N9
  boolean gdml_private K4, L8, O1
  boolean volumemaker D8, D9
  feat featprism C4
Failed:
  boolean bcommon_complex C3
  boolean gdml_private ZH5
  boolean volumemaker B7, B8, C1, C6, D6, F2
  bugs mesh bug25378_1_2
  bugs modalg_5 bug25184

Testing cases:
http://occt-tests/CR26253-master-occt-64/Debian70-64/bugs/modalg_6/bug26253.html
http://occt-tests/CR26253-master-occt-64/Windows-64-VC10/bugs/modalg_6/bug26253.html
bugs modalg_6 bug26253: OK

Testing on Linux:
occt component :
Total MEMORY difference: 98873103 / 99755709 [-0.88%]
Total CPU difference: 19154.63999999984 / 18211.02000000013 [+5.18%]
products component :
Total MEMORY difference: 24123948 / 24303876 [-0.74%]
Total CPU difference: 7361.679999999977 / 7853.200000000018 [-6.26%]
Testing on Windows:

occt component :
http://occt-tests/CR26253-master-occt-64/Windows-64-VC10/diff-Windows-64-VC10.html
CPU boolean gdml_private P2: 4.4928288 / 2.8392182 [+58.24%]
CPU boolean volumemaker A6: 0.9048058 / 0.2340015 [+286.67%]
CPU bugs fclasses bug22980: 1.8564119 / 0.936006 [+98.33%]
Total MEMORY difference: 58783763 / 58656322 [+0.22%]
Total CPU difference: 16873.598563399464 / 16657.31877699903 [+1.30%]

products component :
Total MEMORY difference: 15630276 / 15634962 [-0.03%]
Total CPU difference: 6576.456156499982 / 6589.763041799983 [-0.20%]

There are following differences in images found by testdiff.
http://occt-tests/CR26253-master-occt-64/Debian70-64/diff-Debian70-64.html
http://occt-tests/CR26253-master-occt-64/Windows-64-VC10/diff-Windows-64-VC10.html
IMAGE boolean gdml_private ZJ7: ZJ7.png differs
IMAGE boolean gdml_private L7: L7.png differs
IMAGE boolean gdml_private G1: G1.png differs
IMAGE boolean gdml_private O1: O1.png differs
IMAGE boolean gdml_private ZJ3: ZJ3.png differs
IMAGE boolean gdml_private U4: U4.png differs
IMAGE boolean gdml_private P5: P5.png differs
IMAGE boolean gdml_private L3: L3.png differs
IMAGE boolean gdml_private O4: O4.png differs
IMAGE boolean gdml_private I8: I8.png differs
IMAGE boolean gdml_private L9: L9.png differs
IMAGE boolean gdml_private N8: N8.png differs
IMAGE boolean gdml_private K2: K2.png differs
IMAGE boolean gdml_private Q5: Q5.png differs
IMAGE boolean gdml_private ZJ4: ZJ4.png differs
IMAGE boolean gdml_private O6: O6.png differs
IMAGE boolean gdml_private U5: U5.png differs
IMAGE boolean gdml_private O3: O3.png differs
IMAGE boolean gdml_private T2: T2.png differs
IMAGE boolean gdml_private W2: W2.png differs
IMAGE boolean gdml_private L5: L5.png differs
IMAGE boolean gdml_private ZI7: ZI7.png differs
IMAGE boolean gdml_public A9: A9.png differs
IMAGE boolean volumemaker B4: B4.png differs
IMAGE boolean volumemaker B9: B9.png differs
IMAGE boolean volumemaker A6: A6.png differs
IMAGE boolean volumemaker B6: B6.png differs
IMAGE boolean volumemaker C9: C9.png differs
IMAGE boolean volumemaker A8: A8.png differs
IMAGE bugs moddata_2 bug26_1: bug26_1.png differs

Branch [archived branch] has been updated by Participant.

[revision removed]


Detailed log of new commits:

Author: mkv
Date: Mon May 25 14:37:10 2015 +0300

    Test case for issue CR26253

Dear pkv,
could you please review following test case
bugs modalg_6 bug26253

Branch [archived branch] has been created by Author.

[revision removed]


No new revisions were added by this update.

Branch [archived branch] has been updated by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Tue May 26 13:48:40 2015 +0300

    0026253: Wrong result obtained by General Fuse operator.
    
    Replace BOPCol_MapOfShape by BOPCol_IndexedMapOfShape to provide
    the same order of shells in the result

Git branch CR26253_1 is ready to review.

Reviewed.

Dear Commenter 1,
Branch CR26253_1 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]

Number of compiler warnings:

occt component :
Linux: 25 (25 on master)
Windows: 0 (0 on master)

products component :
Linux: 37 (37 on master)
Windows: 0 (0 on master)

Regressions/Differences/Improvements:
http://occt-tests/CR26253-1-master-occt-64/Debian70-64/boolean/bcut_complex/N9.html
http://occt-tests/CR26253-1-master-occt-64/Windows-64-VC10/boolean/bcut_complex/N9.html
boolean bcut_complex N9 - will be corrected
http://occt-tests/CR26253-1-master-occt-64/Debian70-64/feat/featprism/C4.html
http://occt-tests/CR26253-1-master-occt-64/Windows-64-VC10/feat/featprism/C4.html
feat featprism C4 - will be corrected
http://occt-tests/CR26253-1-master-occt-64/Debian70-64/boolean/bcommon_complex/C3.html
http://occt-tests/CR26253-1-master-occt-64/Windows-64-VC10/boolean/bcommon_complex/C3.html
boolean bcommon_complex C3 - will be corrected

Testing cases:
http://occt-tests/CR26253-1-master-occt-64/Debian70-64/bugs/modalg_6/bug26253.html
http://occt-tests/CR26253-1-master-occt-64/Windows-64-VC10/bugs/modalg_6/bug26253.html
bugs modalg_6 bug26253: OK

Testing on Linux:
occt component :
Total MEMORY difference: 99427090 / 99767134 [-0.34%]
Total CPU difference: 18790.26000000009 / 18351.93000000015 [+2.39%]
products component :
Total MEMORY difference: 24096397 / 24303876 [-0.85%]
Total CPU difference: 7805.040000000037 / 7853.200000000018 [-0.61%]

Testing on Windows:
occt component :
Total MEMORY difference: 58707910 / 58641270 [+0.11%]
Total CPU difference: 16830.511087198927 / 16774.085525499027 [+0.34%]
products component :
Total MEMORY difference: 15624516 / 15628514 [-0.03%]
Total CPU difference: 6574.506143999999 / 6588.515033799982 [-0.21%]

There are following differences in images found by testdiff.
http://occt-tests/CR26253-1-master-occt-64/Debian70-64/diff-Debian70-64.html
http://occt-tests/CR26253-1-master-occt-64/Windows-64-VC10/diff-Windows-64-VC10.html
IMAGE bugs moddata_2 bug26_1: bug26_1.png differs

Branch [archived branch] has been updated by Participant.

[revision removed]


Detailed log of new commits:

Author: mkv
Date: Wed May 27 19:10:21 2015 +0300

    Test case for issue CR26253

1. Case
bugs moddata_2 bug26_1

1.1. Analysis:
The arguments a_1, a_2
are not valid for fuse.

To check tthe fact please, use the commands:

bopargcheck a_1 #F
bopargcheck a_2 #F

1.2 Proposal
Correct the script:

brestore T:/occt_tests_data/private/customers/Samtech/OCC26.brep a
explode a

settolerance a_1 0.000301
settolerance a_2 0.000301

bclearobjects
bcleartools
baddobjects a_1
baddtools a_2

bfillds
bbop result 1

Branch [archived branch] has been updated by Participant.

[revision removed]


Detailed log of new commits:

Author: mkv
Date: Thu May 28 14:47:29 2015 +0300

    Correction of test case for issue CR26253

Dear Commenter 1,
Test case
bugs moddata_2 bug26_1
was corrected and pushed to branch CR26253_1 of occt git-repository.
Now it is OK.

Branch [archived branch] has been deleted by Participant.

[revision removed]

Branch [archived branch] has been deleted by Participant.

[revision removed]