Archived issue #0026256
FSD_File and FSD_CmpFile are almost twins
Description
FSD_CmpFile is a almost copy of FSD_File. Why FSF_CmpFile is not child of FSD_File?
Steps to reproduce
N/A (Only optimization of architecture).
Public activity
9 archived notes
Participants are labeled by their role within this record.
It is not correct definition.
Both inherit from BaseDriver from Storage which defines
in general the framework of a specific driver implementation.
Both as BinaryFile as CmpFile implement the same methods in different way
taking into account that input data have different nature and structure.
I.e. here is used separation by type approach.
What is strange here?
Both inherit from BaseDriver from Storage which defines
in general the framework of a specific driver implementation.
Both as BinaryFile as CmpFile implement the same methods in different way
taking into account that input data have different nature and structure.
I.e. here is used separation by type approach.
What is strange here?
90% of the code is the same for both the classes. Would a parent class containing shared code be better approach for further development and support?
Vlad,
Check optimization possibility, please.
Check optimization possibility, please.
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: szy
Date: Wed Sep 13 16:43:32 2017 +0300
0026256: FSD_File and FSD_CmpFile are almost twins.
//CmpFile inheritance schema is changed.
//Additional test - B1 is added to persist/fsd folder.
[revision removed]
Detailed log of new commits:
Author: szy
Date: Wed Sep 13 16:43:32 2017 +0300
0026256: FSD_File and FSD_CmpFile are almost twins.
//CmpFile inheritance schema is changed.
//Additional test - B1 is added to persist/fsd folder.
Test case B1 requires file Attachment 1 (CMP) (attached).
Attachment 1 (CMP) has been pushed to shape database.
Results of testing:
http://jenkins-test-10.nnov.opencascade.com/view/CR26256-master-SZY/view/TESTING/job/CR26256-master-SZY-OCCT-Debian70-64-opt-test-restart/HTML_Report/
http://jenkins-test-10.nnov.opencascade.com/view/CR26256-master-SZY/view/TESTING/job/CR26256-master-SZY-OCCT-Windows-64-VC10-opt-test-restart/HTML_Report/
Results of testing:
http://jenkins-test-10.nnov.opencascade.com/view/CR26256-master-SZY/view/TESTING/job/CR26256-master-SZY-OCCT-Debian70-64-opt-test-restart/HTML_Report/
http://jenkins-test-10.nnov.opencascade.com/view/CR26256-master-SZY/view/TESTING/job/CR26256-master-SZY-OCCT-Windows-64-VC10-opt-test-restart/HTML_Report/
Review it, please.
Jenkins result =>http://jenkins-test-10.nnov.opencascade.com/view/CR26256-master-SZY/.
Testgrid relevant to test modifications: 'persist/fsd'
New test case: B1
Jenkins result =>http://jenkins-test-10.nnov.opencascade.com/view/CR26256-master-SZY/.
Testgrid relevant to test modifications: 'persist/fsd'
New test case: B1
Combination:
Branch OCCT : CR26256 [revision removed]
Branch products : master
was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Detected differences have been agreed with developer
Image differences :
Detected differences have been agreed with developer
Memory differences :
No differences that require special attention
New test cases are OK
Branch OCCT : CR26256 [revision removed]
Branch products : master
was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Detected differences have been agreed with developer
Image differences :
Detected differences have been agreed with developer
Memory differences :
No differences that require special attention
New test cases are OK
Branch [archived branch] has been deleted by Commenter 4.
[revision removed]
[revision removed]