DiscussionsIssue archiveOCCT:Data Exchange

Archived issue #0026341

Uninitialized field in ShapeFix_Face

Open CASCADEOCCT:Data Exchangeclosed10 public notes

Search issues

Description

The new field myRemoveSmallAreaFaceMode introduced in class ShapeFix_Face by patch for #25923 is not initialized in constructor.

Steps to reproduce

N/A

Public activity

10 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Thu Jun 18 18:40:42 2015 +0300

    0026341: Uninitialized field in ShapeFix_Face
    
    Parameter RemoveSmallAreaFaceMode in ShapeFix_Face is properly initialized; some other minor corrections
02Commenter 2
Fix pushed to CR26341, please review
03Commenter 3
Branch CR26341 is ready to be tested
04Commenter 2
Branch [archived branch] has been updated forcibly by Participant.

[revision removed]
05Commenter 5
Dear Commenter 1,
Branch CR26341 was rebased on current master of occt git-repository.
[revision removed]
06Commenter 6
Dear Commenter 1,
Branch CR26341 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]

There is following extraction error:
Linux:
http://jenkins-test-01.nnov.opencascade.com:8080/view/CR26341-master/job/CR26341-master_prepare_occt_linux/2/parsed_console/


Error : /misc/dn60/LocalWOK/wok_entities/LOC/dev/CR26341-master-occt-64/src/ShapeFix/ShapeFix_Face.cdl", line 212: parse error
Error : 1 errors.
07Commenter 2
Branch [archived branch] has been updated by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Wed Jul 1 09:02:35 2015 +0300

    correction

08Commenter 8
Corrected, please test
09Commenter 9
Dear Commenter 1,
Branch CR26341 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]

Number of compiler warnings:

occt component :
Linux: 25 (25 on master)
Windows: 0 (0 on master)

products component :
Linux: 37 (37 on master)
Windows: 0 (0 on master)

Regressions/Differences/Improvements:
No regressions/differences

Testing cases:
Not needed

Testing on Linux:
occt component :
Total MEMORY difference: 97770681 / 98565567 [-0.81%]
Total CPU difference: 17991.539999999884 / 18149.380000000052 [-0.87%]
products component :
Total MEMORY difference: 24184365 / 24211008 [-0.11%]
Total CPU difference: 7841.81000000002 / 7857.050000000034 [-0.19%]

Testing on Windows:
occt component :
Total MEMORY difference: 56579008 / 56772988 [-0.34%]
Total CPU difference: 17082.577502998898 / 17207.643504698844 [-0.73%]
products component :
Total MEMORY difference: 15535064 / 15550857 [-0.10%]
Total CPU difference: 6205.485778499974 / 6303.984809899965 [-1.56%]

There are no differences in images found by testdiff.
10Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]