Archived issue #0026360
Useless global functions IsSimilar() in Standard
Description
Package Standard contains definitions of global functions IsSimailar() for primitive types (Address, Integer, Real, Character, CString, etc...), which do the same check as IsEqual() and are not used (except in 3 places for strings).
These functions should be removed as useless; IsEqual() should be used instead.
These functions should be removed as useless; IsEqual() should be used instead.
Steps to reproduce
Not required
Public activity
8 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: akz
Date: Fri Sep 25 16:33:23 2015 +0300
0026360: Useless global functions IsSimilar() in Standard
Remove IsSimilar() global function for Standard types. Replace usege of IsSimilar() by IsEqual().
[revision removed]
Detailed log of new commits:
Author: akz
Date: Fri Sep 25 16:33:23 2015 +0300
0026360: Useless global functions IsSimilar() in Standard
Remove IsSimilar() global function for Standard types. Replace usege of IsSimilar() by IsEqual().
Branch CR26360 is ready for review.
No remarks, please test
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Dear Commenter 1,
Branch CR26360 was rebased on branch IR-2015-09-24 of occt git-repository.
[revision removed]
Branch CR26360 was rebased on branch IR-2015-09-24 of occt git-repository.
[revision removed]
Dear Commenter 1,
Branch CR26360 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 13 (13 on master)
Windows: 0 (0 on master)
products component :
Linux: 39 (39 on master)
Windows: 0 (0 on master)
Regressions/Differences/Improvements:
No regressions/differences
Testing cases:
Not needed
Testing on Linux:
occt component :
Total MEMORY difference: 93467410 / 93205933 [+0.28%]
Total CPU difference: 19578.849999999136 / 19578.36999999923 [+0.00%]
products component :
Total MEMORY difference: 26268759 / 26313326 [-0.17%]
Total CPU difference: 6521.979999999951 / 7200.459999999998 [-9.42%]
Testing on Windows:
occt component :
Total MEMORY difference: 57852376 / 57876111 [-0.04%]
Total CPU difference: 18865.965334898912 / 17715.52036029908 [+6.49%]
products component :
Total MEMORY difference: 17133675 / 17140676 [-0.04%]
Total CPU difference: 6069.437306400009 / 5623.134045499962 [+7.94%]
There are no differences in images found by testdiff.
Branch CR26360 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 13 (13 on master)
Windows: 0 (0 on master)
products component :
Linux: 39 (39 on master)
Windows: 0 (0 on master)
Regressions/Differences/Improvements:
No regressions/differences
Testing cases:
Not needed
Testing on Linux:
occt component :
Total MEMORY difference: 93467410 / 93205933 [+0.28%]
Total CPU difference: 19578.849999999136 / 19578.36999999923 [+0.00%]
products component :
Total MEMORY difference: 26268759 / 26313326 [-0.17%]
Total CPU difference: 6521.979999999951 / 7200.459999999998 [-9.42%]
Testing on Windows:
occt component :
Total MEMORY difference: 57852376 / 57876111 [-0.04%]
Total CPU difference: 18865.965334898912 / 17715.52036029908 [+6.49%]
products component :
Total MEMORY difference: 17133675 / 17140676 [-0.04%]
Total CPU difference: 6069.437306400009 / 5623.134045499962 [+7.94%]
There are no differences in images found by testdiff.
Dear Commenter 1,
Branch CR26360 is TESTED.
Branch CR26360 is TESTED.
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]