Archived issue #0026363
Visualization, TKOpenGl - missing RayTracing shader files should be properly reported in Release mode
Description
Current implementation of OpenGl_View::ShaderSource::Load() uses Standard_ASSERT_RETURN() in case of missing files.
This results in weird error reporting when GLSL program has been build with incomplete sources list.
This results in weird error reporting when GLSL program has been build with incomplete sources list.
Steps to reproduce
N/A
Public activity
5 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Tue Jun 23 10:12:03 2015 +0300
0026363: Visualization, TKOpenGl - missing RayTracing shader files should be properly reported in Release mode
OpenGl_View::ShaderSource::Load() - print error about missing files.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Tue Jun 23 10:12:03 2015 +0300
0026363: Visualization, TKOpenGl - missing RayTracing shader files should be properly reported in Release mode
OpenGl_View::ShaderSource::Load() - print error about missing files.
Patch is ready for review in branch CR26363.
Dear Commenter 1,
please test the patch.
please test the patch.
Dear Commenter 1,
Branch CR26363 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 25 (25 on master)
Windows: 0 (0 on master)
products component :
Linux: 37 (37 on master)
Windows: 0 (0 on master)
Regressions/Differences/Improvements:
No regressions/differences
Testing cases:
Not needed
Testing on Linux:
occt component :
Total MEMORY difference: 97770458 / 98272225 [-0.51%]
Total CPU difference: 18453.930000000055 / 18555.40000000014 [-0.55%]
products component :
Total MEMORY difference: 24253444 / 24316064 [-0.26%]
Total CPU difference: 8207.90000000001 / 7858.430000000035 [+4.45%]
Testing on Windows:
occt component :
Total MEMORY difference: 56553621 / 56649611 [-0.17%]
Total CPU difference: 17328.38827869876 / 17577.05387269885 [-1.41%]
products component :
Total MEMORY difference: 15546726 / 15550884 [-0.03%]
Total CPU difference: 6385.370531599977 / 6414.932721099968 [-0.46%]
There are no differences in images found by testdiff.
Branch CR26363 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 25 (25 on master)
Windows: 0 (0 on master)
products component :
Linux: 37 (37 on master)
Windows: 0 (0 on master)
Regressions/Differences/Improvements:
No regressions/differences
Testing cases:
Not needed
Testing on Linux:
occt component :
Total MEMORY difference: 97770458 / 98272225 [-0.51%]
Total CPU difference: 18453.930000000055 / 18555.40000000014 [-0.55%]
products component :
Total MEMORY difference: 24253444 / 24316064 [-0.26%]
Total CPU difference: 8207.90000000001 / 7858.430000000035 [+4.45%]
Testing on Windows:
occt component :
Total MEMORY difference: 56553621 / 56649611 [-0.17%]
Total CPU difference: 17328.38827869876 / 17577.05387269885 [-1.41%]
products component :
Total MEMORY difference: 15546726 / 15550884 [-0.03%]
Total CPU difference: 6385.370531599977 / 6414.932721099968 [-0.46%]
There are no differences in images found by testdiff.
Branch [archived branch] has been deleted by Author.
[revision removed]
[revision removed]