Archived issue #0026383

Incorrect tolerance computing in IntTools_FaceFace::ComputeTolerance()

Open CASCADEOCCT:Modeling Algorithmsclosed5 public notes

Description

line 865:

      const TopoDS_Face& aF = !i ? myFace1 : myFace2;
      aD = FindMaxDistance(aC3D, aFirst, aLast, aF, myContext);
      if (aD > aDMax) {
        aDMax = aD;
      }

But it is not necessary in case of computing intersection line. All information about quality of intersection curve stored in "same parameter" tolerance computation (line 853-864).

Proposed fix:
Delete this block and dependent code.

Steps to reproduce

N/A

Public activity

5 archived notes

Participants are labeled by their role within this record.

01Commenter 22015-07-01 09:46

Branch [archived branch] has been created by Author.

[revision removed]

Detailed log of new commits:

Author: Author
Date: Wed Jul 1 09:44:28 2015 +0300

    0026383: Incorrect tolerance computing in IntTools_FaceFace::ComputeTolerance()

    Projection of points 3d curve on faces deleted from ComputeTolerance().

02Commenter 22015-07-01 09:48

Dear msv,

Please check current state of branch CR26383.

03Commenter 32015-07-01 09:56

Reviewed.

04Commenter 42015-07-02 12:28

Dear Commenter 1,

Branch CR26383 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
[revision removed]

Number of compiler warnings:
occt component:
   Linux: 25 (25 on master)
   Windows: 0 (0 on master)
products component:
   Linux: 37 (37 on master)
   Windows: 0 (0 on master)

Regressions/Differences:
Not detected

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 98039666 / 98056296 [-0.02%]
Total CPU difference: 18494.120000000108 / 18222.6600000001 [+1.49%]

Testing on Windows:
Total MEMORY difference: 56523648 / 56577171 [-0.09%]
Total CPU difference: 17183.52575009888 / 17365.17331449884 [-1.05%]

05Commenter 22015-08-14 10:57

Branch [archived branch] has been deleted by Participant.

[revision removed]