AIS_Dimension may attempt to modify the state of default Drawer shading aspect

Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Tue Jul 14 17:42:27 2015 +0300

    0026433: AIS_Dimension may attempt to modify the state of default Drawer shading aspect

Please, move the block

if (!myDrawer->HasOwnShadingAspect())
{
  ...
}

inside the block

// draw text
if (myDrawer->DimensionAspect()->IsTextShaded())
{
  ...
}

i.e. at the location where myDrawer->ShadingAspect() is actually modified. Else there is no visible logical connection between the two blocks, and the newly added one looks a bit oddly, especially without any comments.

Dear Anastasia,

please update the patch in accordance with Sergey remarks if problem has not been solved in scope of other patches.

Branch [archived branch] has been updated forcibly by Participant.

[revision removed]

Dear kgv,

could you please review patch in the updated and rebased branch CR26433?

Please test the patch.

Dear Commenter 1,

Branch CR26433 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
[revision removed]

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MacOS: 134 (134 on master)
products component:
   Linux: 37 (37 on master)
   Windows: 0 (0 on master)

Regressions/Differences:
Not detected

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 89448600 / 89711291 [-0.29%]
Total CPU difference: 19300.210000000145 / 19353.80000000006 [-0.28%]

Testing on Windows:
Total MEMORY difference: 54599165 / 54607233 [-0.01%]
Total CPU difference: 17601.35882849873 / 18177.392520998823 [-3.17%]

Branch [archived branch] has been deleted by Commenter 3.

[revision removed]