DiscussionsIssue archiveOCCT:Modeling Algorithms

Archived issue #0026522

Exception while copying offset on C0 surface

Open CASCADEOCCT:Modeling Algorithmsclosed21 public notes

Search issues

Description

Constructor rises an exception while trying to make a copy of an offset on C0 surface.

Steps to reproduce

restore s
checkshape s

// CheckFail rising while executing Geom_OffsetSurface::Copy ()

Public activity

21 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Wed Aug 5 15:59:10 2015 +0300

    0026522: Exception while copying offset on C0 surface
    
    Removed check for C0 surface while copying offset surface
02Commenter 2
There is no need to check for C0 surfaces when copying offset surface. Copy of C0 offset should be a C0 offset.
Please check.
03Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
04Commenter 2
Branch [archived branch] has been updated by Participant.

[revision removed]


Detailed log of new commits:

Author: szv
Date: Thu Aug 6 10:19:37 2015 +0300

    General code melioration

05Commenter 5
Reviewed with general code melioration (inline methods, const qualifiers, formatting), please test.
06Commenter 2
Branch [archived branch] has been updated forcibly by Participant.

[revision removed]
07Commenter 2
Branch [archived branch] has been updated by Participant.

[revision removed]


Detailed log of new commits:

Author: mkv
Date: Thu Aug 6 16:43:02 2015 +0300

    Test case for issue CR26522

08Commenter 8
Dear Commenter 1,
Branch CR26522 was rebased on IR-2015-08-06 of occt git-repository.
[revision removed]
09Commenter 9
Dear Commenter 1,
Branch CR26522 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]

Number of compiler warnings:

occt component :
Linux: 15 (15 on master)
Windows: 0 (0 on master)

products component :
Linux: 39 (39 on master)
Windows: 0 (0 on master)

Regressions/Differences/Improvements:
No regressions/differences

Testing cases:
http://occt-tests/CR26522-master-occt-64/Debian70-64/bugs/moddata_3/bug26522.html
http://occt-tests/CR26522-master-occt-64/Windows-64-VC10/bugs/moddata_3/bug26522.html
bugs moddata_3 bug26522: FAILED

Testing on Linux:
occt component :
Total MEMORY difference: 90766379 / 90517459 [+0.27%]
Total CPU difference: 17845.929999999535 / 17640.95999999938 [+1.16%]
products component :
Total MEMORY difference: 24885984 / 24836344 [+0.20%]
Total CPU difference: 7224.349999999991 / 7006.110000000006 [+3.11%]

Testing on Windows:
occt component :
Total MEMORY difference: 56903314 / 56926406 [-0.04%]
Total CPU difference: 16773.664322799246 / 16688.082174199026 [+0.51%]
products component :
Total MEMORY difference: 16004841 / 16012079 [-0.05%]
Total CPU difference: 5315.110070999982 / 5275.579417599962 [+0.75%]

There are no differences in images found by testdiff.
10Commenter 10
Dear anv,
could you please review following test case
bugs moddata_3 bug26522
11Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
12Commenter 12
Ok.
13Commenter 2
Branch [archived branch] has been updated forcibly by Participant.

[revision removed]
14Commenter 14
Dear Commenter 1,
Branch CR26522 was rebased on branch IR-2015-09-03 of occt git-repository.
[revision removed].
15Commenter 15
Dear Commenter 1,
Branch CR26522 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]

Number of compiler warnings:

occt component :
Linux: 15 (15 on master)
Windows: 0 (0 on master)

products component :
Linux: 39 (39 on master)
Windows: 0 (0 on master)

Regressions/Differences/Improvements:
No regressions/differences

Testing cases:
http://occt-tests/CR26522-master-occt-64/Debian70-64/bugs/moddata_3/bug26522.html
http://occt-tests/CR26522-master-occt-64/Windows-64-VC10/bugs/moddata_3/bug26522.html
bugs moddata_3 bug26522: OK

Testing on Linux:
occt component :
Total MEMORY difference: 91816972 / 91946396 [-0.14%]
Total CPU difference: 17638.399999998946 / 17713.96999999897 [-0.43%]
products component :
Total MEMORY difference: 25229774 / 25210384 [+0.08%]
Total CPU difference: 7378.439999999995 / 6935.280000000003 [+6.39%]

Testing on Windows:
occt component :
Total MEMORY difference: 57110600 / 57102997 [+0.01%]
Total CPU difference: 17615.289717798743 / 16228.487628099389 [+8.55%]
products component :
Total MEMORY difference: 16225985 / 16225943 [+0.00%]
Total CPU difference: 5826.668550199978 / 5398.88260799997 [+7.92%]

There are no differences in images found by testdiff.
16Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
17Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
18Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Thu Sep 17 09:55:23 2015 +0300

    0026522: Exception while copying offset on C0 surface
19Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
20Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]
21Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]