Archived issue #0026536
Visualization, Ray-tracing engine - improve BVH traverse and fix texture support
Description
Improving BVH traverse and fixing texture support
Steps to reproduce
N/A
Public activity
29 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Mon Aug 10 11:42:05 2015 +0300
Revising traverse of two-level BVH and fixing texture support
[revision removed]
Detailed log of new commits:
Author: Author
Date: Mon Aug 10 11:42:05 2015 +0300
Revising traverse of two-level BVH and fixing texture support
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Mon Aug 10 12:34:58 2015 +0300
0026536: Visualization - Ray-tracing engine: improving BVH traverse and fixing texture support
[revision removed]
Detailed log of new commits:
Author: Author
Date: Mon Aug 10 12:34:58 2015 +0300
0026536: Visualization - Ray-tracing engine: improving BVH traverse and fixing texture support
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Mon Aug 10 12:34:58 2015 +0300
0026536: Visualization - Ray-tracing engine: improving BVH traverse and fixing texture support
[revision removed]
Detailed log of new commits:
Author: Author
Date: Mon Aug 10 12:34:58 2015 +0300
0026536: Visualization - Ray-tracing engine: improving BVH traverse and fixing texture support
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Mon Aug 10 12:34:58 2015 +0300
0026536: Visualization - Ray-tracing engine: improving BVH traverse and fixing texture support
[revision removed]
Detailed log of new commits:
Author: Author
Date: Mon Aug 10 12:34:58 2015 +0300
0026536: Visualization - Ray-tracing engine: improving BVH traverse and fixing texture support
Branch [archived branch] has been updated forcibly by Author.
[revision removed]
[revision removed]
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Mon Aug 10 12:34:58 2015 +0300
0026536: Visualization - Ray-tracing engine: improving BVH traverse and fixing texture support
[revision removed]
Detailed log of new commits:
Author: Author
Date: Mon Aug 10 12:34:58 2015 +0300
0026536: Visualization - Ray-tracing engine: improving BVH traverse and fixing texture support
Dear kgv,
please review the patch in branch CR26536_4. Main improvements:
1) Textures are working on AMD! If you have time and possibility, could you please check it on your Radeon? We have tested on Radeon 7870.
2) Rendering of large-scale scenes containing many objects (> 100) was significantly improved. E.g. on the turbine model (sceenshot attached) path tracing performance increased on 40%. This is due to refactored traverse subroutine: now there is single traverse for two levels of BVH.
please review the patch in branch CR26536_4. Main improvements:
1) Textures are working on AMD! If you have time and possibility, could you please check it on your Radeon? We have tested on Radeon 7870.
2) Rendering of large-scale scenes containing many objects (> 100) was significantly improved. E.g. on the turbine model (sceenshot attached) path tracing performance increased on 40%. This is due to refactored traverse subroutine: now there is single traverse for two levels of BVH.
Branch [archived branch] has been updated by Commenter 3.
[revision removed]
Detailed log of new commits:
Author: Commenter 3
Date: Thu Aug 13 09:27:41 2015 +0300
OpenGl_View::initProgram() - fix NULL-dereference
[revision removed]
Detailed log of new commits:
Author: Commenter 3
Date: Thu Aug 13 09:27:41 2015 +0300
OpenGl_View::initProgram() - fix NULL-dereference
Branch [archived branch] has been updated by Commenter 3.
[revision removed]
Detailed log of new commits:
Author: Commenter 3
Date: Thu Aug 13 09:49:20 2015 +0300
OpenGl_RaytraceGeometry::ReleaseResources() - nullify resource
[revision removed]
Detailed log of new commits:
Author: Commenter 3
Date: Thu Aug 13 09:49:20 2015 +0300
OpenGl_RaytraceGeometry::ReleaseResources() - nullify resource
I confirm that textures are now operable on Radeon R9 R290 (with Catalyst 15.4 beta).
Please proceed minor remarks.
Please proceed minor remarks.
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Thu Aug 27 10:27:41 2015 +0300
0026536: Visualization - Ray-tracing engine: improving BVH traverse and fixing texture support
In order to provide compatibility with AMD GPUs, 64-bit texture handles were replaced by uvec2 type in GLSL code.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Thu Aug 27 10:27:41 2015 +0300
0026536: Visualization - Ray-tracing engine: improving BVH traverse and fixing texture support
In order to provide compatibility with AMD GPUs, 64-bit texture handles were replaced by uvec2 type in GLSL code.
Dear kgv,
please review the patch in branch CR26536_5.
please review the patch in branch CR26536_5.
Branch [archived branch] has been updated forcibly by Author.
[revision removed]
[revision removed]
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Thu Aug 27 10:27:41 2015 +0300
0026536: Visualization - Ray-tracing engine: improving BVH traverse and fixing texture support
In order to provide compatibility with AMD GPUs, 64-bit texture handles were replaced by uvec2 type in GLSL code.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Thu Aug 27 10:27:41 2015 +0300
0026536: Visualization - Ray-tracing engine: improving BVH traverse and fixing texture support
In order to provide compatibility with AMD GPUs, 64-bit texture handles were replaced by uvec2 type in GLSL code.
Branch [archived branch] has been updated by Commenter 3.
[revision removed]
Detailed log of new commits:
Author: Commenter 3
Date: Thu Aug 27 12:43:22 2015 +0300
cosmetics
[revision removed]
Detailed log of new commits:
Author: Commenter 3
Date: Thu Aug 27 12:43:22 2015 +0300
cosmetics
Branch [archived branch] has been created by Commenter 3.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Thu Aug 27 12:46:22 2015 +0300
0026536: Visualization - Ray-tracing engine: improving BVH traverse and fixing texture support
Replace 64-bit handles of bindless textures by uvec2 type in GLSL code for compatibility with AMD drivers.
OpenGl_View::initProgram() - fix NULL-dereference.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Thu Aug 27 12:46:22 2015 +0300
0026536: Visualization - Ray-tracing engine: improving BVH traverse and fixing texture support
Replace 64-bit handles of bindless textures by uvec2 type in GLSL code for compatibility with AMD drivers.
OpenGl_View::initProgram() - fix NULL-dereference.
Please test patch in branch CR26536_6.
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Dear Commenter 1,
Branch CR26536_6 was rebased on branch IR-2015-08-27 of occt git-repository.
[revision removed]
Branch CR26536_6 was rebased on branch IR-2015-08-27 of occt git-repository.
[revision removed]
Dear Commenter 1,
Branch CR26536_6 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 15 (15 on master)
Windows: 0 (0 on master)
products component :
Linux: 39 (39 on master)
Windows: 0 (0 on master)
Regressions/Differences/Improvements:
No regressions/differences
Testing cases:
Not needed
Testing on Linux:
occt component :
Total MEMORY difference: 91918242 / 91193918 [+0.79%]
Total CPU difference: 17887.33999999895 / 17162.149999999383 [+4.23%]
products component :
Total MEMORY difference: 25186122 / 25216901 [-0.12%]
Total CPU difference: 7113.120000000007 / 7037.939999999998 [+1.07%]
Testing on Windows:
occt component :
Total MEMORY difference: 57061389 / 57052452 [+0.02%]
Total CPU difference: 16078.882669099032 / 16097.197186498954 [-0.11%]
products component :
Total MEMORY difference: 16223163 / 16222282 [+0.01%]
Total CPU difference: 5385.263720699981 / 5332.831784599964 [+0.98%]
There are following differences in images found by testdiff.
http://occt-tests/CR26536-6-master-occt-64/Debian70-64/diff-Debian70-64.html
IMAGE bugs vis bug24288_2: bug24288_2_Driver1_Viewer1_View1.png differs
IMAGE bugs vis bug25732_1: bug25732_1_Driver1_Viewer1_View1.png differs
Branch CR26536_6 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 15 (15 on master)
Windows: 0 (0 on master)
products component :
Linux: 39 (39 on master)
Windows: 0 (0 on master)
Regressions/Differences/Improvements:
No regressions/differences
Testing cases:
Not needed
Testing on Linux:
occt component :
Total MEMORY difference: 91918242 / 91193918 [+0.79%]
Total CPU difference: 17887.33999999895 / 17162.149999999383 [+4.23%]
products component :
Total MEMORY difference: 25186122 / 25216901 [-0.12%]
Total CPU difference: 7113.120000000007 / 7037.939999999998 [+1.07%]
Testing on Windows:
occt component :
Total MEMORY difference: 57061389 / 57052452 [+0.02%]
Total CPU difference: 16078.882669099032 / 16097.197186498954 [-0.11%]
products component :
Total MEMORY difference: 16223163 / 16222282 [+0.01%]
Total CPU difference: 5385.263720699981 / 5332.831784599964 [+0.98%]
There are following differences in images found by testdiff.
http://occt-tests/CR26536-6-master-occt-64/Debian70-64/diff-Debian70-64.html
IMAGE bugs vis bug24288_2: bug24288_2_Driver1_Viewer1_View1.png differs
IMAGE bugs vis bug25732_1: bug25732_1_Driver1_Viewer1_View1.png differs
Dear Commenter 1,
> There are following differences in images found by testdiff.
> http://occt-tests/CR26536-6-master-occt-64/Debian70-64/diff-Debian70-64.html [^]
> IMAGE bugs vis bug24288_2: bug24288_2_Driver1_Viewer1_View1.png differs
> IMAGE bugs vis bug25732_1: bug25732_1_Driver1_Viewer1_View1.png differs
these differences are caused by different versions of tests (with and without "vfont add") and unrelated to patch itself.
Please switch to tested.
> There are following differences in images found by testdiff.
> http://occt-tests/CR26536-6-master-occt-64/Debian70-64/diff-Debian70-64.html [^]
> IMAGE bugs vis bug24288_2: bug24288_2_Driver1_Viewer1_View1.png differs
> IMAGE bugs vis bug25732_1: bug25732_1_Driver1_Viewer1_View1.png differs
these differences are caused by different versions of tests (with and without "vfont add") and unrelated to patch itself.
Please switch to tested.
Branch [archived branch] has been deleted by Commenter 3.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Commenter 3.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Commenter 3.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Commenter 3.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Commenter 3.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Commenter 3.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Commenter 3.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Commenter 3.
[revision removed]
[revision removed]