Archived issue #0026632

HLR sample doesn't work with Algo mode

Open CASCADEOCCT:Samplesclosed12 public notes

Search issues

Description

HLR Process works incorrect using Algo mode in "Choose Shapes and Projector" menu. Problem is in out of range array in function Update in HLRBRep_Data.cxx.
Problem is reproduced on 6.9.1 beta (works correctly on 6.9.0)

Steps to reproduce

Run mfc HLR sample, import shape, run Process HLR, push Get Shapes and choose Algo mode.

--------------------------------------------------
Test script (it is OK on both MASTER and FIX. I cannot reproduce the problem with using DRAW-commands):

Draw[]> restore samples\\mfc\\standard\\Data\\bottle.brep bb
Draw[]> vinit
Draw[]> vdisplay bb
Draw[]> vfit
Draw[]> vhlr on
Draw[]> vhlrtype algo

Public activity

12 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Dear APN,

Please try to analyze reason of problem i.e. problem algorithm or sample.
If problem please ask JGV for help
02Author
It's a problem in HLR algorithm (in HLRBRep_InternalAlgo.cxx)
03Commenter 3
Dear Andrei (apn),

The main reason of the problem is incorrect curve resolution computation (with BSplCLib class). It returns resolution value ~ 1.0e307. Finally, it leads to Floating Overflow exception.
04Commenter 3
Branch [archived branch] has been created by Participant.

[revision removed]


Detailed log of new commits:

Author: nbv
Date: Tue Sep 22 13:35:13 2015 +0300

    0026632: HLR sample doesn't work with Algo mode
    
    The main reason of the problem is Walking-line contains two equal Walking-points (the segment has null-length both in 3D and 2D).
05Commenter 5
Dear Mikhail,

Please review CR26632 branch.
06Commenter 3
Branch [archived branch] has been updated forcibly by Participant.

[revision removed]
07Commenter 7
Reviewed.
Concerning the test case, it would be good to make a test command in QABugs.
08Commenter 8
Issue #0026714 has been created according to previous recommendation.
09Commenter 9
Dear Commenter 2,

Branch CR26632 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
[revision removed]

Number of compiler warnings:
occt component:
   Linux: 15 (15 on master)
   Windows: 0 (0 on master)
products component:
   Linux: 39 (39 on master)
   Windows: 0 (0 on master)

Regressions/Differences:
Not detected

Testing on Linux:
Total MEMORY difference: 92254523 / 92156584 [+0.11%]
Total CPU difference: 19069.22999999906 / 18924.599999998987 [+0.76%]

Testing on Windows:
Total MEMORY difference: 56863979 / 56867352 [-0.01%]
Total CPU difference: 16962.581533799137 / 17116.72612189913 [-0.90%]
10Commenter 10
Dear apn,

Please, verify HLR sample. Thank you in advance.
11Author
HLR sample works correctly with Algo mode.
12Commenter 3
Branch [archived branch] has been deleted by Commenter 1.

[revision removed]