DiscussionsIssue archiveOCCT:Visualization

Archived issue #0026765

Visualization - drop TKVoxel toolkit

Open CASCADEOCCT:Visualizationclosed11 public notes

Search issues

Description

TKVoxel has been introduced as experimental module for displaying data in form of voxels.

In current state the package uses obsolete OpenGL API, questionable design and data structures definitions. Having these issues and without evolution plan, it seems maintenance of this package as part of OCCT is not justified.

Thus it is considered to drop this package and consider usage alternative algorithms based on Volume Rendering.

Steps to reproduce

N/A

Public activity

11 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Sat Oct 10 22:18:47 2015 +0300

    0026734: Visualization, D3DHost_View - drop outdated UserDraw interfaces

Author: Author
Date: Sat Oct 10 22:17:37 2015 +0300

    0026765: Visualization - drop TKVoxel toolkit
02Author
Patch is ready for review.
03Commenter 3
Branch CR26765 reviewed without remarks, ready for testing.
04Commenter 2
Branch [archived branch] has been updated by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Sat Oct 10 22:45:14 2015 +0300

    0026768: Visualization, Graphic3d_Camera::ZFitAll() - define method estimating ZRange without assigning it
    
    Declare methods V3d_View::Redraw() and V3d_View::RedrawImmediate() as virtual to allow customization.

05Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
06Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
07Commenter 7
Dear Commenter 1,
Branch CR26765 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]

Number of compiler warnings:

occt component :
Linux: 13 (13 on master)
Windows: 0 (0 on master)

products component :
Linux: 39 (39 on master)
Windows: 0 (0 on master)

Regressions/Differences/Improvements:
http://occt-tests/CR26765-master-occt-64/Debian70-64/boolean/volumemaker/C9.html
boolean volumemaker C9: IMPROVEMENT

Testing cases:
Not needed

Testing on Linux:
occt component :
Total MEMORY difference: 92409577 / 92427332 [-0.02%]
Total CPU difference: 19550.109999999837 / 19399.48000000005 [+0.78%]
products component :
Total MEMORY difference: 26212504 / 26341594 [-0.49%]
Total CPU difference: 7360.959999999994 / 7327.720000000003 [+0.45%]

Testing on Windows:
occt component :
Total MEMORY difference: 58042676 / 58118207 [-0.13%]
Total CPU difference: 18562.309388398815 / 18356.52846929885 [+1.12%]
products component :
Total MEMORY difference: 17162334 / 17192277 [-0.17%]
Total CPU difference: 5621.215233199969 / 5634.4753181999695 [-0.24%]

There are no differences in images found by testdiff.

08Commenter 2
Branch [archived branch] has been updated by Participant.

[revision removed]


Detailed log of new commits:

Author: mkv
Date: Tue Oct 13 16:01:18 2015 +0300

    Correction of test case for issue CR26765

09Commenter 9
Dear Commenter 1,
following test case is corrected and pushed to branch CR26765 of occt git-repository
boolean volumemaker C9
10Commenter 10
Dear Commenter 1,
Branch CR26765 is TESTED.
11Commenter 2
Branch [archived branch] has been deleted by Author.

[revision removed]

Related records