Archived issue #0026773
Visualization - deviation angle cannot be set by AIS_InteractiveContext::SetDeviationAngle() due to misprint
Description
The setter takes the angle parameter and sets it as deviation coefficient. This seems to be a typo.
void AIS_InteractiveContext::SetDeviationCoefficient (const Standard_Real theCoefficient)
{
myDefaultDrawer->SetDeviationCoefficient (theCoefficient);
}
void AIS_InteractiveContext::SetDeviationAngle (const Standard_Real theAngle)
{
myDefaultDrawer->SetDeviationCoefficient (theAngle);
}
Steps to reproduce
Not required, source code seems to have an obvious error
Public activity
7 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Benjamin Bihler
Date: Wed Oct 14 10:35:47 2015 +0200
Modified deviation angle setter to set the angle
[revision removed]
Detailed log of new commits:
Author: Benjamin Bihler
Date: Wed Oct 14 10:35:47 2015 +0200
Modified deviation angle setter to set the angle
Branch [archived branch] has been created by Commenter 3.
[revision removed]
Detailed log of new commits:
Author: Benjamin Bihler
Date: Wed Oct 14 11:45:18 2015 +0300
0026773: Visualization - deviation angle cannot be set by AIS_InteractiveContext::SetDeviationAngle() due to misprint
Modified deviation angle setter to set the angle.
[revision removed]
Detailed log of new commits:
Author: Benjamin Bihler
Date: Wed Oct 14 11:45:18 2015 +0300
0026773: Visualization - deviation angle cannot be set by AIS_InteractiveContext::SetDeviationAngle() due to misprint
Modified deviation angle setter to set the angle.
Please test the patch.
Dear Commenter 1,
Branch CR26773 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 13 (13 on master)
Windows: 0 (0 on master)
products component :
Linux: 39 (39 on master)
Windows: 0 (0 on master)
Regressions/Differences/Improvements:
No regressions/differences
Testing cases:
Not needed
Testing on Linux:
occt component :
Total MEMORY difference: 92441401 / 92512152 [-0.08%]
Total CPU difference: 19359.879999999826 / 19304.950000000048 [+0.28%]
products component :
Total MEMORY difference: 26320455 / 26341594 [-0.08%]
Total CPU difference: 7244.290000000009 / 7327.720000000003 [-1.14%]
Testing on Windows:
occt component :
Total MEMORY difference: 58085156 / 58096926 [-0.02%]
Total CPU difference: 18410.5516155989 / 18015.8690855989 [+2.19%]
products component :
Total MEMORY difference: 17180548 / 17185795 [-0.03%]
Total CPU difference: 5872.766845699987 / 5633.28971059997 [+4.25%]
There are no differences in images found by testdiff.
Branch CR26773 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 13 (13 on master)
Windows: 0 (0 on master)
products component :
Linux: 39 (39 on master)
Windows: 0 (0 on master)
Regressions/Differences/Improvements:
No regressions/differences
Testing cases:
Not needed
Testing on Linux:
occt component :
Total MEMORY difference: 92441401 / 92512152 [-0.08%]
Total CPU difference: 19359.879999999826 / 19304.950000000048 [+0.28%]
products component :
Total MEMORY difference: 26320455 / 26341594 [-0.08%]
Total CPU difference: 7244.290000000009 / 7327.720000000003 [-1.14%]
Testing on Windows:
occt component :
Total MEMORY difference: 58085156 / 58096926 [-0.02%]
Total CPU difference: 18410.5516155989 / 18015.8690855989 [+2.19%]
products component :
Total MEMORY difference: 17180548 / 17185795 [-0.03%]
Total CPU difference: 5872.766845699987 / 5633.28971059997 [+4.25%]
There are no differences in images found by testdiff.
Dear Commenter 1,
Branch CR26773 is TESTED.
Branch CR26773 is TESTED.
Branch [archived branch] has been deleted by Commenter 3.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Commenter 3.
[revision removed]
[revision removed]