Archived issue #0026833
Create command checkview containing all viewer types
Description
Create command checkview which takes viewer type (2d, 3d, axo, etc), displayed shapes, display order.
Steps to reproduce
N/A
Public activity
18 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: ski
Date: Wed Jan 27 09:55:25 2016 +0300
0026833: Create command checkview containing all viewer types
Created command checkview for displaying shapes.
[revision removed]
Detailed log of new commits:
Author: ski
Date: Wed Jan 27 09:55:25 2016 +0300
0026833: Create command checkview containing all viewer types
Created command checkview for displaying shapes.
OCCT branch CR26833 was created and rebased on current state of master.
Command checkview was created. It is possible to use it to make snapshots of viewers.
Test cases, "help" of checkview proc and documentation were updated.
Note that there will be a lot of differences in images during testing.
Most of them are caused by superposition of axis (global axis of smallview viewer and local axis of shape (after commands lprops/sprops)) in branch master
and by using simple name format in some test cases:
name of image in branch master - bug22789_Driver1_Viewer1_View1.png
name of image in branch CR26833 - bug22789.png
Also, some test cases without this patch show unnecessary objects in viewer:
• boolean bcommon_simple I2
• boolean bcut_simple M2
• boolean bopcommon_complex K6,K9,L1
Snapshots in test cases are empty because result is empty shape (and test is OK):
• boolean volumemaker B5,B6,C3
Last image in test case is removed because it is a duplicate of previous image:
• 3rdparty fonts C1
There are new snapshots in test cases:
• boolean bopcut_complex B9,E1,E5,E8
• boolean bopfuse_comples B4,B5,C9,D1,D4,D5,D6,D7
These test cases are BAD (command fails) and test cases show source shapes used by the command
Please, review.
Command checkview was created. It is possible to use it to make snapshots of viewers.
Test cases, "help" of checkview proc and documentation were updated.
Note that there will be a lot of differences in images during testing.
Most of them are caused by superposition of axis (global axis of smallview viewer and local axis of shape (after commands lprops/sprops)) in branch master
and by using simple name format in some test cases:
name of image in branch master - bug22789_Driver1_Viewer1_View1.png
name of image in branch CR26833 - bug22789.png
Also, some test cases without this patch show unnecessary objects in viewer:
• boolean bcommon_simple I2
• boolean bcut_simple M2
• boolean bopcommon_complex K6,K9,L1
Snapshots in test cases are empty because result is empty shape (and test is OK):
• boolean volumemaker B5,B6,C3
Last image in test case is removed because it is a duplicate of previous image:
• 3rdparty fonts C1
There are new snapshots in test cases:
• boolean bopcut_complex B9,E1,E5,E8
• boolean bopfuse_comples B4,B5,C9,D1,D4,D5,D6,D7
These test cases are BAD (command fails) and test cases show source shapes used by the command
Please, review.
From docs:
> Use: checkview [options...]
> Allowed options are:
> ..
> * Procedure can check some property of shape (length, area or volume) and compare it with some value N:
is that true?? why procedure checking view shall do any computations?
> Use: checkview [options...]
> Allowed options are:
> ..
> * Procedure can check some property of shape (length, area or volume) and compare it with some value N:
is that true?? why procedure checking view shall do any computations?
That behavior was taken from current state of test cases. In some situation it is necessary to show source shapes used by command if result shape is empty (wrong).
Note that it is possible to use command checkview with previously calculated value of area/length/volume:
regexp {Mass +: +([-0-9.+eE]+)} [sprops result] full m
checkview -display result -2d -s ${m} -path ${imagedir}/photo.png
Note that it is possible to use command checkview with previously calculated value of area/length/volume:
regexp {Mass +: +([-0-9.+eE]+)} [sprops result] full m
checkview -display result -2d -s ${m} -path ${imagedir}/photo.png
regexp {Mass +: +([-0-9.+eE]+)} [sprops result] full m
checkview -display result -2d -s ${m} -otherwise {a b} -path ${imagedir}/photo.png
In this example, if result shape is empty, procedure checkview will display shapes 'a' and 'b' in current viewer and a snapshot will be done.
checkview -display result -2d -s ${m} -otherwise {a b} -path ${imagedir}/photo.png
In this example, if result shape is empty, procedure checkview will display shapes 'a' and 'b' in current viewer and a snapshot will be done.
This behavior is used in test group boolean.
I think it is possible to avoid any calculation in proc checkview:
• do not use this behavior or
• proc checkprops should return current value of property, for example
set area [checkprops result -s 13.8136]
checkview -display result -2d -s ${area} -path ${imagedir}/${test_image}.png
So, in this case, no calculation of properties (area/length/volume) will be done in proc checkview.
I think it is possible to avoid any calculation in proc checkview:
• do not use this behavior or
• proc checkprops should return current value of property, for example
set area [checkprops result -s 13.8136]
checkview -display result -2d -s ${area} -path ${imagedir}/${test_image}.png
So, in this case, no calculation of properties (area/length/volume) will be done in proc checkview.
No remarks, please test
Dear ski,
could you please rebase branch CR26833 on current master, there are conflict files.
could you please rebase branch CR26833 on current master, there are conflict files.
Branch [archived branch] has been updated forcibly by Author.
[revision removed]
[revision removed]
Branch [archived branch] has been updated by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Tue Feb 2 00:32:26 2016 +0300
Cosmetic changes in geometry test group
[revision removed]
Detailed log of new commits:
Author: Author
Date: Tue Feb 2 00:32:26 2016 +0300
Cosmetic changes in geometry test group
Branch [archived branch] has been updated forcibly by Author.
[revision removed]
[revision removed]
Branch CR26833 was rebased on current state of master.
Branch [archived branch] has been updated by Participant.
[revision removed]
Detailed log of new commits:
Author: ski
Date: Tue Feb 2 10:37:52 2016 +0300
Small corrections after rebase
[revision removed]
Detailed log of new commits:
Author: ski
Date: Tue Feb 2 10:37:52 2016 +0300
Small corrections after rebase
Dear BugMaster,
Branch CR26833 from occt git-repository was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 1 (1 on master)
Regressions/Differences/Improvements:
No regressions/differences
Testing cases:
Not needed
Testing on Linux:
occt component :
Total MEMORY difference: 90640868 / 89353065 [+1.44%]
Total CPU difference: 19074.039999999924 / 18836.58999999982 [+1.26%]
Testing on Windows:
occt component :
Total MEMORY difference: 57306438 / 57304383 [+0.00%]
Total CPU difference: 17998.47497409881 / 18573.837862298933 [-3.10%]
There are following differences in images found by testdiff.
http://occt-tests/CR26833-master-occt-64/Debian70-64/diff-Debian70-64.html
http://occt-tests/CR26833-master-occt-64/Windows-64-VC10/diff-Windows-64-VC10.html
IMAGE boolean bcut_simple M2: M2.png differs
IMAGE boolean bcommon_simple I2: I2.png differs
IMAGE boolean gdml_private I6: I6.png differs
IMAGE boolean bopcommon_complex L1: L1.png differs
IMAGE boolean bopcommon_complex K9: K9.png differs
IMAGE boolean bopcommon_complex K6: K6.png differs
IMAGE boolean volumemaker B5: B5.png differs
IMAGE boolean volumemaker C3: C3.png differs
IMAGE boolean volumemaker B6: B6.png differs
Branch CR26833 from occt git-repository was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 1 (1 on master)
Regressions/Differences/Improvements:
No regressions/differences
Testing cases:
Not needed
Testing on Linux:
occt component :
Total MEMORY difference: 90640868 / 89353065 [+1.44%]
Total CPU difference: 19074.039999999924 / 18836.58999999982 [+1.26%]
Testing on Windows:
occt component :
Total MEMORY difference: 57306438 / 57304383 [+0.00%]
Total CPU difference: 17998.47497409881 / 18573.837862298933 [-3.10%]
There are following differences in images found by testdiff.
http://occt-tests/CR26833-master-occt-64/Debian70-64/diff-Debian70-64.html
http://occt-tests/CR26833-master-occt-64/Windows-64-VC10/diff-Windows-64-VC10.html
IMAGE boolean bcut_simple M2: M2.png differs
IMAGE boolean bcommon_simple I2: I2.png differs
IMAGE boolean gdml_private I6: I6.png differs
IMAGE boolean bopcommon_complex L1: L1.png differs
IMAGE boolean bopcommon_complex K9: K9.png differs
IMAGE boolean bopcommon_complex K6: K6.png differs
IMAGE boolean volumemaker B5: B5.png differs
IMAGE boolean volumemaker C3: C3.png differs
IMAGE boolean volumemaker B6: B6.png differs
Dear ski,
Branch [archived branch] has been rejected due to:
- differences in images
Branch [archived branch] has been rejected due to:
- differences in images
Dear mkv,
differences in images were described in my message above.
The only exception is IMAGE boolean gdml_private I6.
The reason of difference is axis after command sprops.
All differences are OK.
differences in images were described in my message above.
The only exception is IMAGE boolean gdml_private I6.
The reason of difference is axis after command sprops.
All differences are OK.
Dear BugMaster,
Branch CR26833 is TESTED.
Branch CR26833 is TESTED.
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Related records