Archived issue #0026865
Configuration, CMake - ensure consistency between FILES and actual content of inc and src folders
Description
CMake generation process of OCCT solution does not remove existing old copies of headers that might have been removed from OCCT sources.
Furthermore, it copies all headers found in the package directory, regardless of whether they are listed in the FILES file of the package.
it should be improved to ensure consistency:
- Only headers listed in FILES should be copied / linked to inc.
- All files found in package directory but not listed in FILES should be reported (warning).
- Headers found in inc but not in FILES of any package should be removed (with warning message).
Furthermore, it copies all headers found in the package directory, regardless of whether they are listed in the FILES file of the package.
it should be improved to ensure consistency:
- Only headers listed in FILES should be copied / linked to inc.
- All files found in package directory but not listed in FILES should be reported (warning).
- Headers found in inc but not in FILES of any package should be removed (with warning message).
Steps to reproduce
N/A
Public activity
10 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Tue Nov 10 11:49:08 2015 +0300
0026865: Configuration, CMake - ensure consistency between FILES and actual content of inc and src folders
headers from inc folder are being checked for using in further building process
parse FILES file to collect header files for inc folder
[revision removed]
Detailed log of new commits:
Author: Author
Date: Tue Nov 10 11:49:08 2015 +0300
0026865: Configuration, CMake - ensure consistency between FILES and actual content of inc and src folders
headers from inc folder are being checked for using in further building process
parse FILES file to collect header files for inc folder
dear ski,
please review CR26865 branch of OCCT git
please review CR26865 branch of OCCT git
Branch [archived branch] has been updated forcibly by Author.
[revision removed]
[revision removed]
Branch [archived branch] has been updated by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Fri Nov 13 14:57:46 2015 +0300
during cleaning inc folder, do not remove the headers with name not containing their package name
[revision removed]
Detailed log of new commits:
Author: Author
Date: Fri Nov 13 14:57:46 2015 +0300
during cleaning inc folder, do not remove the headers with name not containing their package name
Dear ibs,
"- All files found in package directory but not listed in FILES should be reported (warning)."
It seems that only header files are processed as in description.
"- All files found in package directory but not listed in FILES should be reported (warning)."
It seems that only header files are processed as in description.
Branch [archived branch] has been updated by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Mon Nov 16 16:53:24 2015 +0300
FILES is parsed not only for headers files
Warning is emitted when a file in folder is not involved to corresponding FILES file
lex and yacc file added StepFile/FILES file
[revision removed]
Detailed log of new commits:
Author: Author
Date: Mon Nov 16 16:53:24 2015 +0300
FILES is parsed not only for headers files
Warning is emitted when a file in folder is not involved to corresponding FILES file
lex and yacc file added StepFile/FILES file
dear ski,
your remark has been considered. Now each file from a package directory is checked for involving to FILES file
your remark has been considered. Now each file from a package directory is checked for involving to FILES file
No remarks, please test.
dear Commenter 1,
please check compilation, testing is not needed.
please check compilation, testing is not needed.
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Related records