Archived issue #0026908
Visualization, TKOpenGl - eliminate -Wunused-parameter compiler warnings for Android target
Description
Current implementation TKOpenGl for android contain compiler warnings:
OpenGl_Structure.cxx:66:57: warning: unused parameter 'theWorkspace' [-Wunused-parameter] OpenGl_Workspace.cxx:1214:76: warning: unused parameter 'theBufferType' [-Wunused-parameter] OpenGl_LineAttributes.cxx:523:65:warning: unused parameter 'theGlCtx' [-Wunused-parameter] OpenGl_LineAttributes.cxx:553:55: warning: unused parameter 'theType' [-Wunused-parameter] OpenGl_Texture.cxx:721:67: warning: unused parameter 'theSizeX' [-Wunused-parameter] OpenGl_Texture.cxx:722:67: warning: unused parameter 'theSizeY' [-Wunused-parameter] OpenGl_Texture.cxx:723:67: warning: unused parameter 'theFormat' [-Wunused-parameter] OpenGl_Clipping.cxx:212:70: warning: unused parameter 'theGlCtx' [-Wunused-parameter] OpenGl_GraphicDriver.cxx:738:81:warning: unused parameter 'AWindow' [-Wunused-parameter] OpenGl_Sampler.cxx:91:44: warning: unused parameter 'theContext' [-Wunused-parameter] OpenGl_Sampler.cxx:92:44: warning: unused parameter 'theUnit' [-Wunused-parameter] OpenGl_Sampler.cxx:106:46: warning: unused parameter 'theContext' [-Wunused-parameter] OpenGl_Sampler.cxx:107:46: warning: unused parameter 'theUnit' [-Wunused-parameter] OpenGl_Sampler.cxx:121:52: warning: unused parameter 'theContext' [-Wunused-parameter] OpenGl_Sampler.cxx:122:52: warning: unused parameter 'theParam' [-Wunused-parameter] OpenGl_Sampler.cxx:123:52: warning: unused parameter 'theValue' [-Wunused-parameter] OpenGl_ShaderProgram.cxx:813:82: warning: unused parameter 'theValue' [-Wunused-parameter] OpenGl_ShaderProgram.cxx:845:82: warning: unused parameter 'theCount' [-Wunused-parameter] OpenGl_ShaderProgram.cxx:846:82: warning: unused parameter 'theValue' [-Wunused-parameter] OpenGl_TextureBufferArb.cxx:94:67: warning: unused parameter 'theGlCtx' [-Wunused-parameter] OpenGl_TextureBufferArb.cxx:95:52: warning: unused parameter 'theComponentsNb' [-Wunused-parameter] OpenGl_TextureBufferArb.cxx:96:52: warning: unused parameter 'theElemsNb' [-Wunused-parameter] OpenGl_TextureBufferArb.cxx:97:52: warning: unused parameter 'theData' [-Wunused-parameter] OpenGl_TextureBufferArb.cxx:140:67: warning: unused parameter 'theGlCtx' [-Wunused-parameter] OpenGl_TextureBufferArb.cxx:141:52: warning: unused parameter 'theComponentsNb' [-Wunused-parameter] OpenGl_TextureBufferArb.cxx:142:52: warning: unused parameter 'theElemsNb' [-Wunused-parameter] OpenGl_TextureBufferArb.cxx:143:52: warning: unused parameter 'theData' [-Wunused-parameter] OpenGl_TextBuilder.cxx:58:30: warning: missing initializer for member 'OpenGl_Font::Tile::uv' [-Wmissing-field-initializers] OpenGl_TextBuilder.cxx:58:30: warning: missing initializer for member 'OpenGl_Font::Tile::px' [-Wmissing-field-initializers] OpenGl_TextBuilder.cxx:58:30: warning: missing initializer for member 'OpenGl_Font::Tile::texture' [-Wmissing-field-initializers]
Steps to reproduce
N/A
Public activity
18 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Tue Nov 24 15:31:03 2015 +0300
0026908: Visualization, TKOpenGl - eliminate -Wunused-parameter compiler warnings for Android target
[revision removed]
Detailed log of new commits:
Author: Author
Date: Tue Nov 24 15:31:03 2015 +0300
0026908: Visualization, TKOpenGl - eliminate -Wunused-parameter compiler warnings for Android target
Dear Kirill,
please review the branch CR26908.
please review the branch CR26908.
Branch [archived branch] has been updated forcibly by Author.
[revision removed]
[revision removed]
Branch [archived branch] has been updated forcibly by Author.
[revision removed]
[revision removed]
Rebase the branch CR26908 on the current master.
Branch [archived branch] has been updated by Commenter 2.
[revision removed]
Detailed log of new commits:
Author: Commenter 2
Date: Thu Dec 10 15:33:50 2015 +0300
OpenGl_ShaderProgram::SetUniform() - return false where needed
[revision removed]
Detailed log of new commits:
Author: Commenter 2
Date: Thu Dec 10 15:33:50 2015 +0300
OpenGl_ShaderProgram::SetUniform() - return false where needed
Branch [archived branch] has been created by Commenter 2.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Thu Dec 10 15:38:30 2015 +0300
0026908: Visualization, TKOpenGl - eliminate -Wunused-parameter compiler warnings for Android target
Support TBO on OpenGL ES 3.2+
[revision removed]
Detailed log of new commits:
Author: Author
Date: Thu Dec 10 15:38:30 2015 +0300
0026908: Visualization, TKOpenGl - eliminate -Wunused-parameter compiler warnings for Android target
Support TBO on OpenGL ES 3.2+
Please check compilation of patch in branch CR26908_1, testing is not needed.
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been rebased on the current master
Branch [archived branch] has been updated by Commenter 2.
[revision removed]
Detailed log of new commits:
Author: Commenter 2
Date: Tue Dec 15 10:56:46 2015 +0300
fix new warning
[revision removed]
Detailed log of new commits:
Author: Commenter 2
Date: Tue Dec 15 10:56:46 2015 +0300
fix new warning
Branch [archived branch] has been created by Commenter 2.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Tue Dec 15 10:58:58 2015 +0300
0026908: Visualization, TKOpenGl - eliminate -Wunused-parameter compiler warnings for Android target
Support TBO on OpenGL ES 3.2+
[revision removed]
Detailed log of new commits:
Author: Author
Date: Tue Dec 15 10:58:58 2015 +0300
0026908: Visualization, TKOpenGl - eliminate -Wunused-parameter compiler warnings for Android target
Support TBO on OpenGL ES 3.2+
Patch has been updated to eliminate new warning on non-Android platforms.
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Warnings on Android were eliminated.
New warnings were not detected
http://jenkins-test-03.nnov.opencascade.com:8080/view/Warnings%20OCCT%20/
There are no regressions testing on Linux and Windows platforms
occt
Windows
Total MEMORY difference: 54269737 / 55997393 [-3.09%]
Total CPU difference: 17417.371249098724 / 17618.019735298913 [-1.14%]
Linux
Total MEMORY difference: 88335602 / 92539349 [-4.54%]
Total CPU difference: 18740.920000000144 / 18299.43999999996 [+2.41%]
Difference in images were not detected
New warnings were not detected
http://jenkins-test-03.nnov.opencascade.com:8080/view/Warnings%20OCCT%20/
There are no regressions testing on Linux and Windows platforms
occt
Windows
Total MEMORY difference: 54269737 / 55997393 [-3.09%]
Total CPU difference: 17417.371249098724 / 17618.019735298913 [-1.14%]
Linux
Total MEMORY difference: 88335602 / 92539349 [-4.54%]
Total CPU difference: 18740.920000000144 / 18299.43999999996 [+2.41%]
Difference in images were not detected
Branch [archived branch] has been deleted by Commenter 2.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Commenter 2.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Commenter 2.
[revision removed]
[revision removed]