Archived issue #0026967
BRepFill_OffsetWire should not copy plane if Alt == 0.0
Description
BRepFill_OffsetWire should not copy plane if Alt == 0.0, because currently if I make an offset wire with BRepOffsetAPI_MakeOffset, BRep_Tools::CurveOnSurface(edge, faceThatContainedTheOriginalWire) will perform projection instead of returning the resulting offset curves, because the underlying PCurve representations will not be accessible since the copied surface inside BRepFill_OffsetWire is hidden from the user.
That is surprising and undesired behavior in my opinion. The fix is trivial, see the attached patch.
That is surprising and undesired behavior in my opinion. The fix is trivial, see the attached patch.
Steps to reproduce
Not needed
Public activity
16 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: msv
Date: Tue Dec 8 16:01:26 2015 +0300
0026967: BRepFill_OffsetWire should not copy plane if Alt == 0.0
[revision removed]
Detailed log of new commits:
Author: msv
Date: Tue Dec 8 16:01:26 2015 +0300
0026967: BRepFill_OffsetWire should not copy plane if Alt == 0.0
I have changed the patch a little and created the branch CR26967.
Dear Igor, please review it.
Seems to be OK
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Dear Commenter 1,
Branch CR26967 was rebased on current master of occt git-repository.
[revision removed]
Branch CR26967 was rebased on current master of occt git-repository.
[revision removed]
Dear Commenter 1,
Branch CR26967 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 134 (134 on master)
products component :
Linux: 37 (37 on master)
Windows: 0 (0 on master)
Regressions/Differences/Improvements:
http://occt-tests/CR26967-master-occt-64/Debian70-64/summary.html
http://occt-tests/CR26967-master-occt-64/Windows-64-VC10/summary.html
Failed:
bugs modalg_2 bug424_1, bug424_2
feat featdprism A1, B4, C3, E1
Testing cases:
Not needed
Testing on Linux:
occt component :
Total MEMORY difference: 93410815 / 94036565 [-0.67%]
Total CPU difference: 19610.799999999886 / 19277.53999999991 [+1.73%]
products component :
Total MEMORY difference: 26181702 / 26088083 [+0.36%]
Total CPU difference: 7393.740000000009 / 7351.649999999994 [+0.57%]
Testing on Windows:
occt component :
Total MEMORY difference: 56327014 / 56344722 [-0.03%]
Total CPU difference: 17953.016282699096 / 17819.651027798893 [+0.75%]
products component :
Total MEMORY difference: 16516499 / 16529851 [-0.08%]
Total CPU difference: 5607.611945999988 / 5737.9039811999755 [-2.27%]
There are no differences in images found by testdiff.
Branch CR26967 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 134 (134 on master)
products component :
Linux: 37 (37 on master)
Windows: 0 (0 on master)
Regressions/Differences/Improvements:
http://occt-tests/CR26967-master-occt-64/Debian70-64/summary.html
http://occt-tests/CR26967-master-occt-64/Windows-64-VC10/summary.html
Failed:
bugs modalg_2 bug424_1, bug424_2
feat featdprism A1, B4, C3, E1
Testing cases:
Not needed
Testing on Linux:
occt component :
Total MEMORY difference: 93410815 / 94036565 [-0.67%]
Total CPU difference: 19610.799999999886 / 19277.53999999991 [+1.73%]
products component :
Total MEMORY difference: 26181702 / 26088083 [+0.36%]
Total CPU difference: 7393.740000000009 / 7351.649999999994 [+0.57%]
Testing on Windows:
occt component :
Total MEMORY difference: 56327014 / 56344722 [-0.03%]
Total CPU difference: 17953.016282699096 / 17819.651027798893 [+0.75%]
products component :
Total MEMORY difference: 16516499 / 16529851 [-0.08%]
Total CPU difference: 5607.611945999988 / 5737.9039811999755 [-2.27%]
There are no differences in images found by testdiff.
Dear msv,
Branch [archived branch] has been rejected due to:
- regressions/differences/improvements
Branch [archived branch] has been rejected due to:
- regressions/differences/improvements
Branch [archived branch] has been updated by Participant.
[revision removed]
Detailed log of new commits:
Author: msv
Date: Mon Dec 14 16:16:46 2015 +0300
Correct misprint
[revision removed]
Detailed log of new commits:
Author: msv
Date: Mon Dec 14 16:16:46 2015 +0300
Correct misprint
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: msv
Date: Tue Dec 8 16:01:26 2015 +0300
0026967: BRepFill_OffsetWire should not copy plane if Alt == 0.0
In the class BRepFill_OffsetWire the base plane is not copied anymore if altitude parameter is equal to zero.
[revision removed]
Detailed log of new commits:
Author: msv
Date: Tue Dec 8 16:01:26 2015 +0300
0026967: BRepFill_OffsetWire should not copy plane if Alt == 0.0
In the class BRepFill_OffsetWire the base plane is not copied anymore if altitude parameter is equal to zero.
Misprint has been corrected.
Please test the branch CR26967_1.
Dear Commenter 1,
Branch CR26967_1 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 134 (134 on master)
products component :
Linux: 37 (37 on master)
Windows: 0 (0 on master)
Regressions/Differences/Improvements:
No regressions/differences
Testing cases:
Not needed
Testing on Linux:
occt component :
Total MEMORY difference: 93136558 / 94053417 [-0.97%]
Total CPU difference: 19763.039999999837 / 19278.489999999907 [+2.51%]
products component :
Total MEMORY difference: 26204992 / 26097898 [+0.41%]
Total CPU difference: 7281.219999999995 / 7353.209999999995 [-0.98%]
Testing on Windows:
occt component :
Total MEMORY difference: 56328952 / 56348011 [-0.03%]
Total CPU difference: 17840.69556269892 / 17820.446632898893 [+0.11%]
products component :
Total MEMORY difference: 16517167 / 16529851 [-0.08%]
Total CPU difference: 5624.740855799976 / 5737.9039811999755 [-1.97%]
There are no differences in images found by testdiff.
Branch CR26967_1 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 134 (134 on master)
products component :
Linux: 37 (37 on master)
Windows: 0 (0 on master)
Regressions/Differences/Improvements:
No regressions/differences
Testing cases:
Not needed
Testing on Linux:
occt component :
Total MEMORY difference: 93136558 / 94053417 [-0.97%]
Total CPU difference: 19763.039999999837 / 19278.489999999907 [+2.51%]
products component :
Total MEMORY difference: 26204992 / 26097898 [+0.41%]
Total CPU difference: 7281.219999999995 / 7353.209999999995 [-0.98%]
Testing on Windows:
occt component :
Total MEMORY difference: 56328952 / 56348011 [-0.03%]
Total CPU difference: 17840.69556269892 / 17820.446632898893 [+0.11%]
products component :
Total MEMORY difference: 16517167 / 16529851 [-0.08%]
Total CPU difference: 5624.740855799976 / 5737.9039811999755 [-1.97%]
There are no differences in images found by testdiff.
Dear Commenter 1,
Branch CR26967_1 is TESTED.
Branch CR26967_1 is TESTED.
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]