OCCT3D
DiscussionsIssue archiveOCCT:Visualization

Archived issue #0026975

Visualization, TKOpenGl - handle triangle strips correctly within Ray-Tracing core

Open CASCADEOCCT:Visualizationclosed12 public notes

Search issues

Description

It seems that triangle strips are converted incorrectly by Ray-Tracing uploader.

The code of the following functions should be checked:
- OpenGl_View::addRaytraceTriangleStripArray()
- OpenGl_View::addRaytraceTriangleFanArray()

Steps to reproduce

pload MODELING VISUALIZATION
vclear
vinit View1
vraytrace 0
vdrawparray s trianglestrips v 0 0 0 n 0 0 1 v 0 2 0 n 0 0 1 v 2 0 0 n 0 0 1 v 2 2 0 n 0 0 1
vfit
# triangle strip is displayed correctly
vraytrace 1
# triangle strip is broken

Public activity

12 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Participant.

[revision removed]


Detailed log of new commits:

Author: isk
Date: Thu Dec 10 13:53:30 2015 +0300

    0026975: Visualization, TKOpenGl - handle triangle strips correctly within Ray-Tracing core
02Commenter 2
Dear Kirill,
Please review the branch CR26795.
03Commenter 2
Branch [archived branch] has been updated forcibly by Participant.

[revision removed]
04Commenter 4
Add missing test case.
05Commenter 2
Branch [archived branch] has been updated forcibly by Participant.

[revision removed]
06Commenter 6
Update test case.
07Author
Please test the patch.
08Commenter 2
Branch [archived branch] has been updated forcibly by Participant.

[revision removed]
09Commenter 9
Dear Commenter 1,
Branch CR26975 was rebased on current master of occt git-repository.
[revision removed]
10Commenter 10
Dear Commenter 1,
Branch CR26975 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]

Number of compiler warnings:

occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 134 (134 on master)

products component :
Linux: 37 (37 on master)
Windows: 0 (0 on master)

Regressions/Differences/Improvements:
No regressions/differences

Testing cases:
http://occt-tests/CR26975-master-occt-64/Debian70-64/bugs/vis/bug26975.html
http://occt-tests/CR26975-master-occt-64/Windows-64-VC10/bugs/vis/bug26975.html
bugs vis bug26975: OK

Testing on Linux:
occt component :
Total MEMORY difference: 93347282 / 94056610 [-0.75%]
Total CPU difference: 19619.179999999815 / 19278.38999999991 [+1.77%]
products component :
Total MEMORY difference: 26226383 / 26088083 [+0.53%]
Total CPU difference: 7403.429999999996 / 7351.649999999994 [+0.70%]

Testing on Windows:
occt component :
Total MEMORY difference: 56324988 / 56346141 [-0.04%]
Total CPU difference: 17773.69313319891 / 17820.150230998894 [-0.26%]
products component :
Total MEMORY difference: 16516512 / 16529851 [-0.08%]
Total CPU difference: 5660.246683399965 / 5737.9039811999755 [-1.35%]

There are no differences in images found by testdiff.
11Commenter 11
Dear Commenter 1,
Branch CR26975 is TESTED.
12Commenter 2
Branch [archived branch] has been deleted by Author.

[revision removed]