Archived issue #0027247

Eliminate remaining compiler warnings in MFC samples and with OCCT_DEBUG

Open CASCADEOCCT:Codingclosed5 public notes

Search issues

Description

Some compiler warnings still remain in MFC samples and with OCCT_DEBUG, to be eliminated

Steps to reproduce

Build OCCT with OCCT_DEBUG enabled, and MFC samples using VS 2015

Public activity

5 archived notes

Participants are labeled by their role within this record.

01Commenter 1
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Fri Mar 11 07:23:55 2016 +0300

    0027247: Eliminate remaining compiler warnings in MFC samples and with OCCT_DEBUG
    
    Unsafe and useless casts of handles are eliminated
02Commenter 2
Fix pushed to CR27247, please review
03Commenter 3
Dear BugMaster,
Branch CR27247 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]

Number of compiler warnings on Release mode:
occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)
MFC Samples Windows: 0 (38 on master)

products component :
Linux: 41 (41 on master)
Windows: 0 (0 on master)

Number of compiler warnings on Debug mode:
occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)

products component :
Linux: 39 (39 on master)
Windows: 0 (0 on master)

Regressions/Differences/Improvements:
No regressions/differences

Testing cases:
Not needed

Testing on Linux:
occt component :
Total MEMORY difference: 90066954 / 90492662 [-0.47%]
Total CPU difference: 19500.88999999997 / 19575.36000000011 [-0.38%]
products component :
Total MEMORY difference: 25923447 / 25882280 [+0.16%]
Total CPU difference: 5382.419999999991 / 5317.479999999984 [+1.22%]

Testing on Windows:
occt component :
Total MEMORY difference: 57792138 / 57106142 [+1.20%]
Total CPU difference: 19055.397349199044 / 17710.091525498752 [+7.60%]
products component :
Total MEMORY difference: 17942533 / 17395600 [+3.14%]
Total CPU difference: 4964.56022389994 / 5095.257861699954 [-2.57%]

There are no differences in images found by testdiff.
04Commenter 4
Dear BugMaster,
Branch CR27247 is TESTED.
05Commenter 1
Branch [archived branch] has been deleted by Commenter 2.

[revision removed]