Archived issue #0027463

Checkprops can not be used with several properties

Open CASCADEOCCT:Testsclosed10 public notes

Search issues

Description

Added possibility to use several properties in one checkprops command (e.g. checkprops result -s 1456.2 -v 400)

Steps to reproduce

checkprops result -s 1456.2 -v 400

Public activity

10 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Wed May 4 14:13:02 2016 +0300

    0027463: Checkprops can not be used with several properties
    
    Added possibility to use several properties in one checkprops command
02Author
Dear ski, please review CR27463.
03Commenter 3
Reviewed without remarks,

please proceed.
04Commenter 4
Dear Commenter 1,

Branch CR27463 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
[revision removed]

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MacOS: 0 (0 on master)
products component:
   Linux: 72
   Windows: 4
   MacOS: 1129

Regressions/Differences:
http://occt-tests/CR27463-master-OCCT/Debian70-64/summary.html
http://occt-tests/CR27463-master-OCCT/Windows-64-VC10/summary.html
pipe specific K4, K7, K8, L1, L4, L5, L7, L9, M2, M4, M6, M9, N1, N4, N5, N7, N9, O2, O4, O6, O8, P1 P3, P5, P7, P9, Q2, Q4, Q6, Q8, R1, R3, R5, R7, R9, S2, S4, S6, S7

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 88033265 / 87414469 [+0.71%]
Total CPU difference: 19270.06999999993 / 19364.490000000176 [-0.49%]

Testing on Windows:
Total MEMORY difference: 55494596 / 55528156 [-0.06%]
Total CPU difference: 18336.357539998804 / 18262.678267698826 [+0.40%]
05Commenter 5
Dear apn,

Branch [archived branch] has been rejected due to:
- regressions/differences/improvements
06Commenter 2
Branch [archived branch] has been updated by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Thu May 5 16:01:47 2016 +0300

    Modified test cases according to changes in checkprops command

07Author
Command checkprops didn't take several arguments (-s -v -l), that's why test cases in pipe group worked incorrect (only last check vprops).
Now all checks works correct (sprops and vprops). Reference data was modified because earlier it didn't consider epsillon parameter.
08Commenter 8
Dear Commenter 1,
Branch CR27463 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]

Number of compiler warnings:

occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)

products component :
Linux: 72 (72 on master)
Windows: 4 (4 on master)
MacOS : 1131

Regressions/Differences/Improvements:
No regressions/differences

Testing cases:
Not needed

Modified testing cases:
pipe specific K4, K7, K8, L1, L4, L5, L7, L9, M2, M4, M6, M9, N1, N4, N5, N7, N9, O2, O4, O6, O8, P1, P3, P5, P7, P9, Q2, Q4, Q6 , Q8, R1, R3, R5, R7, R9, S2, S4, S6, S7 - OK

Testing on Linux:
occt component :
Total MEMORY difference: 87955459 / 87480793 [+0.54%]
Total CPU difference: 19298.23 / 19370.520000000186 [-0.37%]
products component :
Total MEMORY difference: 27832233 / 27839978 [-0.03%]
Total CPU difference: 5363.599999999975 / 5344.489999999986 [+0.36%]

Testing on Windows:
occt component :
Total MEMORY difference: 55523711 / 55549122 [-0.05%]
Total CPU difference: 18141.106688398875 / 18280.618382698816 [-0.76%]
products component :
Total MEMORY difference: 18922534 / 18891436 [+0.16%]
Total CPU difference: 5114.367984199952 / 5013.591338199941 [+2.01%]

There are no differences in images found by testdiff.
09Commenter 9
Dear Commenter 1,
Branch CR27463 is TESTED.
10Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]