Archived issue #0027464
BRepTools_ReShape ends up with empty shapes
Description
BRepTools_ReShape has no protection against creation of empty shapes (e.g. wires having all edges removed). It needs to be adjusted so that not to allow empty result shapes (invalid situation in terms of checkshape).
Steps to reproduce
Test case is heal / reshape / A1. Notice that a new test grid for reshape has been added.
Public activity
10 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Thu May 5 18:01:02 2016 +0300
0027463: BRepTools_ReShape ends up with empty shapes
Add check on empty topological containers.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Thu May 5 18:01:02 2016 +0300
0027463: BRepTools_ReShape ends up with empty shapes
Add check on empty topological containers.
Dear gka,
Could you please review?
Could you please review?
Branch [archived branch] has been updated by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Fri May 6 11:06:14 2016 +0300
Add empty shapes to the replacement map.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Fri May 6 11:06:14 2016 +0300
Add empty shapes to the replacement map.
Branch [archived branch] has been updated by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Tue May 10 11:13:19 2016 +0300
Add Draw command for Re-Shape.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Tue May 10 11:13:19 2016 +0300
Add Draw command for Re-Shape.
Dear gka,
Could you please review changes (Draw command 'reshape' has been added)?
Could you please review changes (Draw command 'reshape' has been added)?
Branch [archived branch] has been updated by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Tue May 10 13:26:32 2016 +0300
Add a test grid for reshape with a single use case for starters.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Tue May 10 13:26:32 2016 +0300
Add a test grid for reshape with a single use case for starters.
Branch CR27464 is ready to be tested
Dear Commenter 1,
Branch CR27464 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)
products component :
Linux: 72 (72 on master)
Windows: 4 (4 on master)
MacOS : 1130
Regressions/Differences/Improvements:
No regressions/differences
Testing cases:
http://occt-tests/CR27464-master-OCCT/Debian70-64/heal/reshape/A1.html
http://occt-tests/CR27464-master-OCCT/Windows-64-VC10/heal/reshape/A1.html
heal reshape A1: OK
Testing on Linux:
occt component :
Total MEMORY difference: 88819644 / 87476410 [+1.54%]
Total CPU difference: 19329.57000000014 / 19370.820000000185 [-0.21%]
products component :
Total MEMORY difference: 27815805 / 27839978 [-0.09%]
Total CPU difference: 5330.129999999974 / 5344.489999999986 [-0.27%]
Testing on Windows:
occt component :
Total MEMORY difference: 55520184 / 55549341 [-0.05%]
Total CPU difference: 18083.932321898894 / 18280.68078309882 [-1.08%]
products component :
Total MEMORY difference: 18916293 / 18885152 [+0.16%]
Total CPU difference: 5040.376709899946 / 5012.358930299941 [+0.56%]
There are no differences in images found by testdiff.
Branch CR27464 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)
products component :
Linux: 72 (72 on master)
Windows: 4 (4 on master)
MacOS : 1130
Regressions/Differences/Improvements:
No regressions/differences
Testing cases:
http://occt-tests/CR27464-master-OCCT/Debian70-64/heal/reshape/A1.html
http://occt-tests/CR27464-master-OCCT/Windows-64-VC10/heal/reshape/A1.html
heal reshape A1: OK
Testing on Linux:
occt component :
Total MEMORY difference: 88819644 / 87476410 [+1.54%]
Total CPU difference: 19329.57000000014 / 19370.820000000185 [-0.21%]
products component :
Total MEMORY difference: 27815805 / 27839978 [-0.09%]
Total CPU difference: 5330.129999999974 / 5344.489999999986 [-0.27%]
Testing on Windows:
occt component :
Total MEMORY difference: 55520184 / 55549341 [-0.05%]
Total CPU difference: 18083.932321898894 / 18280.68078309882 [-1.08%]
products component :
Total MEMORY difference: 18916293 / 18885152 [+0.16%]
Total CPU difference: 5040.376709899946 / 5012.358930299941 [+0.56%]
There are no differences in images found by testdiff.
Dear Commenter 1,
Branch CR27464 is TESTED.
Branch CR27464 is TESTED.
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]