Archived issue #0027629
Visualization - apply a correct model-world matrix to normals in fixed function pipeline with enabled zoom persistence.
Description
Zoom persistence from CR26641 updates model-world matrix that provide lighting bug - normals aren't normalized
Steps to reproduce
bugs vis bug27629
Additional information
Disable ffp to provide a right behaviour.
pload ALL
vinit
box b0 25 25 25
vsetdispmode 1
vdisplay b0 -trsfPers zoom
vzoom 10
vcaps -ffp 0
pload ALL
vinit
box b0 25 25 25
vsetdispmode 1
vdisplay b0 -trsfPers zoom
vzoom 10
vcaps -ffp 0
Public activity
9 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Thu Jun 23 15:01:34 2016 +0300
0027629: Visualization - apply a correct model-world matrix to normals in fixed function pipeline with enabled zoom persistence.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Thu Jun 23 15:01:34 2016 +0300
0027629: Visualization - apply a correct model-world matrix to normals in fixed function pipeline with enabled zoom persistence.
Dear Kirill,
please review the branch CR27629.
please review the branch CR27629.
Please test the patch.
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Dear Commenter 1,
Branch CR27629 was rebased on IR-2016-06-23 of occt git-repository.
[revision removed]
Branch CR27629 was rebased on IR-2016-06-23 of occt git-repository.
[revision removed]
Dear Commenter 1,
Branch CR27629 from occt git-repository (and IR-2016-06-23 from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)
products component :
Linux: 64 (64 on master)
Windows: 0 (0 on master)
MacOS : 1195
Regressions/Differences/Improvements:
No regressions/differences
Testing cases:
http://occt-tests/CR27629-master-OCCT/Debian70-64/bugs/vis/bug27629.html
http://occt-tests/CR27629-master-OCCT/Windows-64-VC10/bugs/vis/bug27629.html
bugs vis bug27629: OK
Testing on Linux:
occt component :
Total MEMORY difference: 87868754 / 88697478 [-0.93%]
Total CPU difference: 19364.649999999987 / 19559.88999999992 [-1.00%]
products component :
Total MEMORY difference: 27438428 / 27390508 [+0.17%]
Total CPU difference: 5167.399999999987 / 5182.479999999985 [-0.29%]
Testing on Windows:
occt component :
Total MEMORY difference: 55891384 / 55896743 [-0.01%]
Total CPU difference: 18159.436805898815 / 17842.239972598676 [+1.78%]
products component :
Total MEMORY difference: 18612813 / 18577733 [+0.19%]
Total CPU difference: 4994.122413399953 / 4930.286804199938 [+1.29%]
There are no differences in images found by testdiff.
Branch CR27629 from occt git-repository (and IR-2016-06-23 from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)
products component :
Linux: 64 (64 on master)
Windows: 0 (0 on master)
MacOS : 1195
Regressions/Differences/Improvements:
No regressions/differences
Testing cases:
http://occt-tests/CR27629-master-OCCT/Debian70-64/bugs/vis/bug27629.html
http://occt-tests/CR27629-master-OCCT/Windows-64-VC10/bugs/vis/bug27629.html
bugs vis bug27629: OK
Testing on Linux:
occt component :
Total MEMORY difference: 87868754 / 88697478 [-0.93%]
Total CPU difference: 19364.649999999987 / 19559.88999999992 [-1.00%]
products component :
Total MEMORY difference: 27438428 / 27390508 [+0.17%]
Total CPU difference: 5167.399999999987 / 5182.479999999985 [-0.29%]
Testing on Windows:
occt component :
Total MEMORY difference: 55891384 / 55896743 [-0.01%]
Total CPU difference: 18159.436805898815 / 17842.239972598676 [+1.78%]
products component :
Total MEMORY difference: 18612813 / 18577733 [+0.19%]
Total CPU difference: 4994.122413399953 / 4930.286804199938 [+1.29%]
There are no differences in images found by testdiff.
Branch [archived branch] has been updated by Participant.
[revision removed]
Detailed log of new commits:
Author: mkv
Date: Fri Jun 24 17:34:19 2016 +0300
Small correction of test case for issue CR27629
[revision removed]
Detailed log of new commits:
Author: mkv
Date: Fri Jun 24 17:34:19 2016 +0300
Small correction of test case for issue CR27629
Dear Commenter 1,
Branch CR27629 is TESTED.
Branch CR27629 is TESTED.
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Related records