Archived issue #0027675
Foundation Classes - handle Unicode path to CSF_UnitsLexicon and CSF_UnitsDefinition on Windows
Description
The package Units was not updated within #0022484 and does not handle Unicode file paths on Windows platform.
Steps to reproduce
N/A
Public activity
8 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Wed Jul 13 22:47:16 2016 +0300
0027675: Foundation Classes - handle Unicode path to CSF_UnitsLexicon and CSF_UnitsDefinition on Windows
Units package now uses Unicode-aware functions OSD_OpenStream
and OSD_FileStatCTime (introduced for fetching file timestamp).
[revision removed]
Detailed log of new commits:
Author: Author
Date: Wed Jul 13 22:47:16 2016 +0300
0027675: Foundation Classes - handle Unicode path to CSF_UnitsLexicon and CSF_UnitsDefinition on Windows
Units package now uses Unicode-aware functions OSD_OpenStream
and OSD_FileStatCTime (introduced for fetching file timestamp).
Patch is ready for review in branch CR27675.
Reviewed, please test.
One general remark (minor): in C casts, please do not put extra space before closing parenthesis, it looks weird but makes no sense. See OSD_OpenFile.cxx lines 180 and 186.
One general remark (minor): in C casts, please do not put extra space before closing parenthesis, it looks weird but makes no sense. See OSD_OpenFile.cxx lines 180 and 186.
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Dear Commenter 1,
Branch CR27675 was rebased on IR-2016-07-14 of occt git-repository.
[revision removed]
Branch CR27675 was rebased on IR-2016-07-14 of occt git-repository.
[revision removed]
Dear Commenter 1,
Branch CR27675 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)
products component :
Linux: 64 (64 on master)
Windows: 0 (0 on master)
MacOS : 1138
Regressions/Differences/Improvements:
No regressions/differences
Testing cases:
Not needed
Testing on Linux:
occt component :
Total MEMORY difference: 90011716 / 90019216 [-0.01%]
Total CPU difference: 19210.409999999894 / 19191.54999999992 [+0.10%]
products component :
Total MEMORY difference: 30000725 / 30103171 [-0.34%]
Total CPU difference: 5091.309999999968 / 5118.619999999969 [-0.53%]
Testing on Windows:
occt component :
Total MEMORY difference: 57444623 / 57431602 [+0.02%]
Total CPU difference: 19137.51627559889 / 18076.974677298753 [+5.87%]
products component :
Total MEMORY difference: 21262934 / 21224923 [+0.18%]
Total CPU difference: 4979.6143203999645 / 4905.607445999939 [+1.51%]
There are no differences in images found by testdiff.
Branch CR27675 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)
products component :
Linux: 64 (64 on master)
Windows: 0 (0 on master)
MacOS : 1138
Regressions/Differences/Improvements:
No regressions/differences
Testing cases:
Not needed
Testing on Linux:
occt component :
Total MEMORY difference: 90011716 / 90019216 [-0.01%]
Total CPU difference: 19210.409999999894 / 19191.54999999992 [+0.10%]
products component :
Total MEMORY difference: 30000725 / 30103171 [-0.34%]
Total CPU difference: 5091.309999999968 / 5118.619999999969 [-0.53%]
Testing on Windows:
occt component :
Total MEMORY difference: 57444623 / 57431602 [+0.02%]
Total CPU difference: 19137.51627559889 / 18076.974677298753 [+5.87%]
products component :
Total MEMORY difference: 21262934 / 21224923 [+0.18%]
Total CPU difference: 4979.6143203999645 / 4905.607445999939 [+1.51%]
There are no differences in images found by testdiff.
Dear Commenter 1,
Branch CR27675 is TESTED.
Branch CR27675 is TESTED.
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Related records