Archived issue #0027684

Coding rules - drop unused declarations from Graphic3d

Open CASCADEOCCT:Codingclosed12 public notes

Search issues

Description

Graphic3d package contains the following declarations that can be removed:
Graphic3d_TypeOfPolygon
Graphic3d_TypeOfPrimitive
Graphic3d_Array1OfVector.hxx
Graphic3d_Array1OfVertex.hxx
Graphic3d_Array2OfVertex.hxx
Graphic3d_CStructurePtr.hxx
Graphic3d_CycleError.hxx
Graphic3d_DataStructure.pxx
Graphic3d_HSequenceOfStructure.hxx
Graphic3d_InitialisationError.hxx
Graphic3d_ListIteratorOfListOfShortReal.hxx
Graphic3d_ListOfShortReal.hxx
Graphic3d_NListOfHAsciiString.hxx
Graphic3d_CBitFields8.hxx
Graphic3d_CBitFields16.hxx
Graphic3d_CBitFields20.hxx

Graphic3d_CBitFields4.hxx
Graphic3d_StructureManagerPtr.hxx
Graphic3d_StructurePtr.hxx


Steps to reproduce

N/A

Public activity

12 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Sat Jul 16 15:57:23 2016 +0300

    0027684: Coding rules - drop unused declarations from Graphic3d
    
    The following headers have been removed:
    - Graphic3d_TypeOfPolygon
    - Graphic3d_TypeOfPrimitive
    - Graphic3d_Array1OfVector.hxx
    - Graphic3d_Array1OfVertex.hxx
    - Graphic3d_Array2OfVertex.hxx
    - Graphic3d_CBitFields4.hxx
    - Graphic3d_CBitFields8.hxx
    - Graphic3d_CBitFields16.hxx
    - Graphic3d_CBitFields20.hxx
    - Graphic3d_CStructurePtr.hxx
    - Graphic3d_CycleError.hxx
    - Graphic3d_DataStructure.pxx
    - Graphic3d_HSequenceOfStructure.hxx
    - Graphic3d_InitialisationError.hxx
    - Graphic3d_ListIteratorOfListOfShortReal.hxx
    - Graphic3d_ListOfShortReal.hxx
    - Graphic3d_NListOfHAsciiString.hxx
    - Graphic3d_StructureManagerPtr.hxx
    - Graphic3d_StructurePtr.hxx
    
    Graphic3d_StructureManager - remove default aspects, which have been never used.
02Author
Please check compilation, regression testing is not needed.
03Commenter 3
Dear Commenter 1,

Branch CR27684 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms.
[revision removed]

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MasOS: 0 (0 on master)
products component:
   Linux: 64
   Windows: 0
   MacOS: 1126

Compilation errors have been detected during building of
Qt-based Products samples on Linux:
http://jenkins-test-05.nnov.opencascade.com/view/CR27684-master/job/CR27684-master-Products-Debian70-64-qt-samples-linux/1/parsed_console/
MFC-based OCCT samples on Windows:
http://jenkins-test-05.nnov.opencascade.com/view/CR27684-master/job/CR27684-master-OCCT-Windows-64-VC10-mfc-samples/2/parsed_console/
C# Products sample on Windows:
http://jenkins-test-05.nnov.opencascade.com/view/CR27684-master/job/CR27684-master-Products-Windows-64-VC10-csharp-samples/1/parsed_console/
Java Products sample on Windows:
http://jenkins-test-05.nnov.opencascade.com/view/CR27684-master/job/CR27684-master-Products-Windows-64-VC10-java-samples/1/parsed_console/
MFC-based Products samples on Windows:
http://jenkins-test-05.nnov.opencascade.com/view/CR27684-master/job/CR27684-master-Products-Windows-64-VC10-mfc-samples/1/parsed_console/
Qt-based Products samples on Windows:
http://jenkins-test-05.nnov.opencascade.com/view/CR27684-master/job/CR27684-master-Products-Windows-64-VC10-qt-samples-windows/1/parsed_console/

04Commenter 4
Dear Kirill,

Branch [archived branch] has been rejected due to:
- compilation errors
05Commenter 2
Branch [archived branch] has been updated by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Tue Jul 19 15:00:16 2016 +0300

    do not include non-existing header Graphic3d_Array1OfVertex.hxx from MFC sample

06Author
Please check OCCT/Products samples on updated branch CR27684 (occt and products); occt itself was not modified.
07Commenter 7
Dear Commenter 1,

Branch CR27684 from occt git-repository (and CR27684 from products git-repository) was compiled on Linux, MacOS and Windows platforms.
[revision removed]
[revision removed]

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MasOS: 0 (0 on master)
products component:
   Linux: 64
   Windows: 0
   MacOS: 1118

Compilation errors have been detected during building of
C# Products sample on Windows:
http://jenkins-test-05.nnov.opencascade.com/view/CR27684-CR27684/job/CR27684-CR27684-Products-Windows-64-VC10-csharp-samples/2/parsed_console/
Java Products sample on Windows:
http://jenkins-test-05.nnov.opencascade.com/view/CR27684-CR27684/job/CR27684-CR27684-Products-Windows-64-VC10-java-samples/2/parsed_console/
08Commenter 8
Dear Kirill,

Branches CR27684 from occt git-repository and CR27684 from products git-repository have been rejected due to:
- compilation errors

09Commenter 2
Branch [archived branch] has been updated by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Wed Jul 20 13:58:27 2016 +0300

    Graphic3d_Group::MinMaxValues() - add missing Standard_EXPORT

10Author
Updated patch should fix the issue - please check compilation.
11Commenter 11
Dear Commenter 1,

Branch CR27684 from occt git-repository (and CR27684 from products git-repository) was compiled on Linux, MacOS and Windows platforms.
[revision removed]
[revision removed]

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MasOS: 0 (0 on master)
products component:
   Linux: 64
   Windows: 0
   MacOS: 1152
12Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]