Archived issue #0027732

Visualization - AIS_ConnectedInteractive crashes on NULL handle returned by MeshVS_CommonSensitiveEntity::GetConnected()

Open CASCADEOCCT:Visualizationclosed7 public notes

Description

MeshVS_CommonSensitiveEntity::GetConnected() returns null handle leading to crash in case of AIS_MultipleConnectedInteractive

Steps to reproduce

pload VISUALIZATION XDE
vclear
vinit View1
meshfromstl m [locate_data_file bug26680.stl]
meshcolors m elem2 1
vselmode m 0 1
vconnect cm 50 0 0 m

Result:

** Exception ** [revision removed] : OSD_Exception_ACCESS_VIOLATION: ACCESS VIOLATION at address 0x0000000000000000 during 'READ' operation

Original test case:

Handle(AIS_MultipleConnectedInteractive) aPrs = new AIS_MultipleConnectedInteractive;

aPrs->Connect((MeshVS_Mesh)(...));
aPrs->Connect((MeshVS_Mesh)(...));

//Display

Public activity

7 archived notes

Participants are labeled by their role within this record.

01Commenter 22018-03-13 17:55

Branch [archived branch] has been created by Commenter 3.

[revision removed]

Detailed log of new commits:

Author: Commenter 3
Date: Tue Mar 13 17:54:11 2018 +0300

    0027732: Visualization - AIS_ConnectedInteractive crashes on NULL handle returned by MeshVS_CommonSensitiveEntity::GetConnected()

    AIS_ConnectedInteractive::ComputeSelection() - added NULL-check.

02Commenter 32018-03-13 20:49

Patch is ready for review.
Note that patch only solves NULL-dereference - it does not make MeshVS_Mesh useful with AIS_MultipleConnectedInteractive due to numerous of other issues like dynamic highlighting overridden by MeshVS_Mesh.

http://jenkins-test-10.nnov.opencascade.com/view/CR27732-master-KGV/

03Commenter 32018-03-13 23:17

Kirill, please describe all the changes included in the commit in its message, not only changes in one file

04Commenter 22018-03-14 11:07

Branch [archived branch] has been updated forcibly by Commenter 3.

[revision removed]

05Commenter 52018-03-21 20:15

Branch CR27732 reviewed without remarks, ready for testing.

06Commenter 12018-03-22 14:08

Combination -
OCCT branch : [archived branch] SHA - [revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian70-64:
OCCT
Total CPU difference: 18374.429999999764 / 18338.37999999957 [+0.20%]
Products
Total CPU difference: 7443.820000000006 / 7461.340000000009 [-0.23%]
Windows-64-VC10:
OCCT
Total CPU difference: 17602.0764330986 / 17653.338361698563 [-0.29%]
Products
Total CPU difference: 7975.207922799987 / 7990.761222500007 [-0.19%]

Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

07Commenter 22018-03-24 20:01

Branch [archived branch] has been deleted by Commenter 3.

[revision removed]