DiscussionsIssue archiveOCCT:Visualization

Archived issue #0027789

Visualization, TKOpenGl - improve compatibility with new OpenGL ES devices

Open CASCADEOCCT:Visualizationclosed7 public notes

Search issues

Description

The following issues should be considered:
1) Anaglyph fragment shader defines the following lines:
  vec4 THE_POW_UP   = vec4 (2.2, 2.2, 2.2, 1.0);
  vec4 THE_POW_DOWN = 1.0 / THE_POW_UP;

produce the following error
'multUp': Only consts or uniforms can be used in a global initializer


2) GL_KHR_debug extension should be loaded as functional equivalent of GL_ARB_debug_output on desktop.

Device info (Samsung Galaxy Tab S2):
EGL info
  Version:     1.4 (1.4 Android META-EGL)
  Vendor:      Android
  Client APIs: OpenGL_ES
  Extensions:  EGL_KHR_get_all_proc_addresses EGL_ANDROID_presentation_time EGL_KHR_swap_buffers_with_damage EGL_KHR_image EGL_KHR_image_base EGL_KHR_lock_surface EGL_KHR_gl_texture_2D_image EGL_KHR_gl_texture_3D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_gl_renderbuffer_image EGL_KHR_reusable_sync EGL_KHR_fence_sync EGL_KHR_create_context EGL_KHR_surfaceless_context EGL_EXT_create_context_robustness EGL_ANDROID_image_native_buffer EGL_KHR_wait_sync EGL_ANDROID_recordable EGL_KHR_partial_update EGL_KHR_create_context_no_error 

Created new GL context:
  GLvendor: Qualcomm
  GLdevice: Adreno (TM) 510
  GLversion: OpenGL ES 3.1 V@139.0 (GIT@Ic07f1cdce3)
  GLSLversion: OpenGL ES GLSL ES 3.10
  Max texture size: 16384
  Window Info: 0x0 RGB24 A0 D0 S0

Steps to reproduce

test case
v3d glsl stereo

Public activity

7 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Wed Aug 17 22:28:35 2016 +0300

    0027789: Visualization, TKOpenGl - improve compatibility with new OpenGL ES devices
    
    OpenGl_ShaderManager::prepareStdProgramStereo() - fixed definition of global constants
    in optimized Anaglyph shader.
    
    OpenGl_Context now loads GL_KHR_debug extension within OpenGL ES context.
02Author
Patch is ready for review.
03Commenter 3
Branch CR27789 reviewed without remarks, ready for testing.
04Commenter 2
Branch [archived branch] has been updated forcibly by Participant.

[revision removed]
05Commenter 5
Branch [archived branch] has been rebased on the current master
06Commenter 6
Dear Commenter 1,

Branch CR27789 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
[revision removed]

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MasOS: 0 (0 on master)
products component:
   Linux: 64
   Windows: 0
   MacOS: 1130

Regressions/Differences:
Not detected

Testing cases:
v3d glsl stereo - OK
http://occt-tests/CR27789-master-OCCT/Debian70-64/v3d/glsl/stereo.html
http://occt-tests/CR27789-master-OCCT/Windows-64-VC10/v3d/glsl/stereo.html

Testing on Linux:
Total MEMORY difference: 89940240 / 89557742 [+0.43%]
Total CPU difference: 19728.340000000087 / 19495.580000000107 [+1.19%]

Testing on Windows:
Total MEMORY difference: 57143308 / 57161393 [-0.03%]
Total CPU difference: 18069.892231898877 / 18084.68112669885 [-0.08%]

07Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]