Archived issue #0027815
Visualization, TKV3d - AIS_InteractiveContext has inconsistent display mode API
Description
Two overloads of AIS_InteractiveContext::SetDisplayMode() use different argument types for the display mode (AIS_DisplayMode vs Standard_Integer).
Meanwhile, a generic integer is used throughout TKV3d to identify a display mode. Using AIS_DisplayMode enum imposes a serious restriction on the API usage.
Thus it is proposed to use Standard_Integer in the both overloads of SetDisplayMode().
Meanwhile, a generic integer is used throughout TKV3d to identify a display mode. Using AIS_DisplayMode enum imposes a serious restriction on the API usage.
Thus it is proposed to use Standard_Integer in the both overloads of SetDisplayMode().
Steps to reproduce
N/A
Public activity
14 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Fri Aug 26 19:04:23 2016 +0300
0027815: Visualization, TKV3d - AIS_InteractiveContext has inconsistent display mode API
Author: Author
Date: Fri Aug 26 20:45:07 2016 +0300
Merge branch 'master' of san-occt:occt.git
Author: Author
Date: Wed Aug 10 12:02:57 2016 +0300
Merge branch 'master' of san-occt:occt
Author: Author
Date: Mon Aug 1 19:05:32 2016 +0300
Merge branch 'master' of san-occt:occt.git
Author: Author
Date: Thu Jun 23 17:46:18 2016 +0300
Merge branch 'master' of san-occt:occt
Author: Commenter 1
Date: Thu Jun 23 17:11:34 2016 +0300
0027631: license.md duplicated in the current master HEAD
[revision removed]
Detailed log of new commits:
Author: Author
Date: Fri Aug 26 19:04:23 2016 +0300
0027815: Visualization, TKV3d - AIS_InteractiveContext has inconsistent display mode API
Author: Author
Date: Fri Aug 26 20:45:07 2016 +0300
Merge branch 'master' of san-occt:occt.git
Author: Author
Date: Wed Aug 10 12:02:57 2016 +0300
Merge branch 'master' of san-occt:occt
Author: Author
Date: Mon Aug 1 19:05:32 2016 +0300
Merge branch 'master' of san-occt:occt.git
Author: Author
Date: Thu Jun 23 17:46:18 2016 +0300
Merge branch 'master' of san-occt:occt
Author: Commenter 1
Date: Thu Jun 23 17:11:34 2016 +0300
0027631: license.md duplicated in the current master HEAD
Branch [archived branch] has been deleted by Author.
[revision removed]
[revision removed]
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Fri Aug 26 19:04:23 2016 +0300
0027815: Visualization, TKV3d - AIS_InteractiveContext has inconsistent display mode API
[revision removed]
Detailed log of new commits:
Author: Author
Date: Fri Aug 26 19:04:23 2016 +0300
0027815: Visualization, TKV3d - AIS_InteractiveContext has inconsistent display mode API
Branch CR27815 ready for reviewing.
Please test the patch.
Dear Commenter 1,
Branch CR27815 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
There are following compilation errors:
Windows:
http://jenkins-test-07.nnov.opencascade.com:8080/view/CR27815-master/job/CR27815-master-Products-Windows-64-VC10-csharp-samples/1/parsed_console/
d:\install\CR27815-master\Windows-64-VC10-opt\Products\samples\csharp\ImportExport\OCCViewer.cs(239,7): error CS1502: The best overloaded method match for 'AIS.AIS_InteractiveContext.SetDisplayMode(int)' has some invalid arguments
d:\install\CR27815-master\Windows-64-VC10-opt\Products\samples\csharp\ImportExport\OCCViewer.cs(239,35): error CS1503: Argument 1: cannot convert from 'AIS.AIS_DisplayMode' to 'int'
Number of compiler warnings:
occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)
products component :
Linux: 64 (64 on master)
Windows: 0 (0 on master)
MacOS : 1126
Branch CR27815 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
There are following compilation errors:
Windows:
http://jenkins-test-07.nnov.opencascade.com:8080/view/CR27815-master/job/CR27815-master-Products-Windows-64-VC10-csharp-samples/1/parsed_console/
d:\install\CR27815-master\Windows-64-VC10-opt\Products\samples\csharp\ImportExport\OCCViewer.cs(239,7): error CS1502: The best overloaded method match for 'AIS.AIS_InteractiveContext.SetDisplayMode(int)' has some invalid arguments
d:\install\CR27815-master\Windows-64-VC10-opt\Products\samples\csharp\ImportExport\OCCViewer.cs(239,35): error CS1503: Argument 1: cannot convert from 'AIS.AIS_DisplayMode' to 'int'
Number of compiler warnings:
occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)
products component :
Linux: 64 (64 on master)
Windows: 0 (0 on master)
MacOS : 1126
Dear san,
Branch [archived branch] has been rejected due to:
- compilation errors
Branch [archived branch] has been rejected due to:
- compilation errors
Branch [archived branch] has been updated forcibly by Author.
[revision removed]
[revision removed]
Branch CR27815 in occt.git rebased to current master.
Branch CR27815 in occt-products.git includes correction of build error.
Branch CR27815 in occt-products.git includes correction of build error.
Please compilation test updated patch (regression testing is not needed).
Dear Commenter 1,
Branch CR27815 was rebased on IR-2016-09-01 of products git-repository.
[revision removed]
Branch CR27815 was rebased on IR-2016-09-01 of products git-repository.
[revision removed]
Dear Commenter 1,
Branch CR27815 from occt git-repository (and CR27815 from products git-repository) was compiled on Linux, MacOS and Windows platforms on Release mode.
[revision removed]
[revision removed]
Number of compiler warnings:
occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)
products component :
Linux: 64 (64 on master)
Windows: 0 (0 on master)
MacOS : 1146
Branch CR27815 from occt git-repository (and CR27815 from products git-repository) was compiled on Linux, MacOS and Windows platforms on Release mode.
[revision removed]
[revision removed]
Number of compiler warnings:
occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)
products component :
Linux: 64 (64 on master)
Windows: 0 (0 on master)
MacOS : 1146
Dear Commenter 1,
Branch CR27815 is TESTED.
Branch CR27815 is TESTED.
Branch [archived branch] has been deleted by Commenter 3.
[revision removed]
[revision removed]
Related records