DiscussionsIssue archiveOCCT:Visualization

Archived issue #0027821

Visualization, AIS_Shape - add NULL checks for displaying TopoDS_Face with NULL surface

Open CASCADEOCCT:Visualizationclosed13 public notes

Search issues

Description

Standard presentation tools used by AIS_Shape might cause NULL-dereference when displaying TopoDS_Face with NULL surface.

Steps to reproduce

N/A

Public activity

13 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: akz
Date: Fri Aug 5 11:24:58 2016 +0300

    0027821: Visualization, AIS_Shape - add NULL checks for displaying TopoDS_Face with NULL surface NULL surface
02Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
03Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
04Author
Patch is ready for testing.
05Author
New data is temporarily at
\\VIRTEX\dn43\occt_tests_data\INCOMING\
06Commenter 6
Dear Commenter 1,

Branch CR27821 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
[revision removed]

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MasOS: 0 (0 on master)
products component:
   Linux: 64
   Windows: 0
   MacOS: 1145

Regressions/Differences:
Not detected

Testing cases:
bugs vis bug27821 - FAILED
http://occt-tests/CR27821-master-OCCT/Debian70-64/bugs/vis/bug27821.html
http://occt-tests/CR27821-master-OCCT/Windows-64-VC10/bugs/vis/bug27821.html

Testing on Linux:
Total MEMORY difference: 89695025 / 89952196 [-0.29%]
Total CPU difference: 19326.470000000074 / 19309.729999999934 [+0.09%]

Testing on Windows:
Total MEMORY difference: 57089116 / 57107084 [-0.03%]
Total CPU difference: 17864.12691289886 / 18053.73052829886 [-1.05%]
07Commenter 7
Dear Kirill,

Branch [archived branch] has been rejected due to:
- failed test-case for issue
08Author
> brestore D:/occt_tests_data/public/brep/bug27821_nullsurf.brep n

How it is possible that in test case the variable "s" became "n" in your test report?
+restore [locate_data_file bug27821_nullsurf.brep] s
09Commenter 9
Shape bug27821_nullsurf.brep is stored in variable s. Symbol "n" is artefact of output for restore/brestore command. You can check this fact by view any other test (e.g. bugs vis bug25178).
10Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
11Author
Test case has been corrected - please check.
12Commenter 12
13Commenter 2
Branch [archived branch] has been deleted by Author.

[revision removed]

Related records