Archived issue #0027860

Visualization - clean up Transformation Persistence API

Open CASCADEOCCT:Visualizationclosed26 public notes

Description

Transformation Persistence API should be cleaned up in the following way:
- Graphic3d_TransformPers should become a handle class.
  Graphic3d_CStructure::TransformPersistence and PrsMgr_PresentableObject::myTransformPersistence should not be allocated by default.
  Since majority of presentations are expected to be without transformation persistence it sounds reasonable to allocate this property dynamically.
- Graphic3d_TransModeFlags should be defined as enumeration.
  Majority of flags can not be combined, so current definition as a bitmask is confusing.
- Graphic3d_TMF_PanPers should be removed as actually unsupported and making no sense.
  The appropriate alternative is Graphic3d_TMF_TriedronPers, which should be probably extended to define independent offset in pixels within X and Y coordinate.
- Graphic3d_TMF_FullPers should be removed as actually unsupported and making no sense.
  The appropriate replacement is Graphic3d_TMF_2d.
- Combination of Graphic3d_TMF_ZoomPers + Graphic3d_TMF_RotatePers should re-defined by dedicated value.
- Graphic3d_TransformPers should be extended by new methods
  making different meaning of Point depending on persistence mode more straightforward.

Projection state changes should be removed OpenGl_Structure::Render() then:

    aCtx->ProjectionState.Push();
    aCtx->ApplyProjectionMatrix();
...
    aCtx->ProjectionState.Pop();
    aCtx->ApplyProjectionMatrix();

Steps to reproduce

Transformation persistence float precision issues:

pload MODELING VISUALIZATION
box b 0 0 0 1 2 3
vclear
vinit View1
vaxo
vpoint p0 0 0 0
vpoint p1 1 0 0
vpoint p2 2 0 0
vfit
vtrih t
vdisplay -dispMode 1 b
vdisplay -trsfPers trihedron -trsfPersPos 1 -1 80 t
vzoom 100000

Public activity

26 archived notes

Participants are labeled by their role within this record.

01Commenter 22016-09-17 19:34

Branch [archived branch] has been created by Author.

[revision removed]

Detailed log of new commits:

Author: Author
Date: Sat Sep 17 19:33:53 2016 +0300

    0027860: Visualization - clean up Transformation Persistence API

    Graphic3d_Camera::TransformMatrices redundant NCollection_Handle usage
    has been replaced with validity flags.

    Graphic3d_TransModeFlags now defined as enumeration, not integer bit flags.
    Graphic3d_TMF_PanPers and Graphic3d_TMF_FullPers have been removed.
    Graphic3d_TMF_ZoomRotatePers has been introduced.

    Graphic3d_TransformPers is now inherits Standard_Transient.
    Graphic3d_TransformPers now defines dedicated constructors
    for 3D persistence (zoom / rotate) and 2D persistence (2d / trihedron).
    2D persistence now supports dedicated values for X and Y offsets.
    The corner is now specified by enumeration Aspect_TypeOfTriedronPosition
    instead of indirect interpretation of anchor point values.

    PrsMgr_PresentableObject, Graphic3d_CStructure now hold
    Handle(Graphic3d_TransformPers) instead of a value.
    Method ::SetTransformPersistence(), ::TransformPersistence()
    now works with Handle(Graphic3d_TransformPers).
    Old methods have been marked deprecated.

02Commenter 22016-09-17 21:11