Geom_BSplineSurface::SetVKnot(const Standard_Integer, const Standard_Real) has no effect

Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: razmyslovich
Date: Mon Sep 12 11:17:48 2016 +0200

    0027863: Fix Geom_BSplineSurface::SetVKnot function

The changes are committed, please, review.

Dear Author, do you have a use case that allows to reproduce incorrect behavior?

Branch [archived branch] has been created by Participant.

[revision removed]


Detailed log of new commits:

Author: razmyslovich
Date: Mon Sep 12 11:17:48 2016 +0200

    0027863: Geom_BSplineSurface::SetVKnot(const Standard_Integer, const Standard_Real) has no effect
    
    Fix Geom_BSplineSurface::SetVKnot function to have the same behavior as SetUKnot.

The new Branch [archived branch] has been created taking into account requirements to the OCCT patch.

Reviewed.

Dear msv, I don't have any special use case for it. In our code base we are just trying to edit the bspline surfaces, particularly, changing v and u knots. Changing of U knots works fine, while changing of V knots has no effect with no matter what bspline surface, what index and what parameter do we use. As it can be seen in the source code, the parameter is actually unused.

OK, the patch will go without a test case.

Dear Commenter 1,
Branch CR27863_1 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]

Number of compiler warnings:

occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)

products component :
Linux: 64 (64 on master)
Windows: 0 (0 on master)
MacOS : 1141

Regressions/Differences/Improvements:
No regressions/differences

Testing cases:
Not needed

Testing on Linux:
occt component :
Total MEMORY difference: 90273515 / 90412639 [-0.15%]
Total CPU difference: 19262.669999999875 / 19445.620000000134 [-0.94%]
products component :
Total MEMORY difference: 30051906 / 29998667 [+0.18%]
Total CPU difference: 5050.219999999977 / 5044.539999999978 [+0.11%]

Testing on Windows:
occt component :
Total MEMORY difference: 57168523 / 57172575 [-0.01%]
Total CPU difference: 18405.37238239873 / 18100.047225198865 [+1.69%]
products component :
Total MEMORY difference: 21261724 / 21225414 [+0.17%]
Total CPU difference: 4954.076956699952 / 4888.104133799955 [+1.35%]

There are no differences in images found by testdiff.

Dear Commenter 1,
Branch CR27863_1 is TESTED.

Branch [archived branch] has been deleted by Participant.

[revision removed]

Branch [archived branch] has been deleted by Participant.

[revision removed]