OCCT3D
DiscussionsIssue archiveOCCT:Visualization

Archived issue #0027893

Visualization - AIS_InteractiveContext::SetSelected does not work

CommunityOCCT:Visualizationclosed10 public notes

Search issues

Description

void AIS_InteractiveContext::SetSelected (const Handle(AIS_InteractiveObject)& theObject, const Standard_Boolean theToUpdateViewer) does not work.
Seems code contains typo.
...
  if (theObject->HasSelection (0))
    return;
...
  // added to avoid untimely viewer update...
  const Handle(SelectMgr_Selection)& aSel = theObject->Selection (0);
...

Seems, the first condition should be negate.

p.s. according to the #0026272
- now each selectable object can define own selection mode for "global" selection of the whole object;
- whole object selection mode is 0 by default for all standard interactive objects;
Why is mode 0 used by default instead of the own selection mode?

Steps to reproduce

bugs vis bug27893

Public activity

10 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Participant.

[revision removed]


Detailed log of new commits:

Author: vpa
Date: Fri Sep 23 15:39:56 2016 +0300

    0027893: Visualization - AIS_InteractiveContext::SetSelected does not work
    
    - misprint in check of global selection existence in AIS_InteractiveContext::SetSelected was corrected;
    - remaining occurrencies of hard-coded 0 selection mode were corrected to use global selection mode;
    - test case for issue #27983
02Commenter 2
Dear Kirill,

please review patch in branch CR27893.
03Commenter 1
Please test the patch.
04Commenter 4
Dear BugMaster,
Branch CR27893 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms on Release mode.
[revision removed]

There are following compilation errors:

Windows:
http://jenkins-test-07.nnov.opencascade.com:8080/view/CR27893-master/job/CR27893-master-OCCT-Windows-64-VC10-opt-compile/1/parsed_console/

59>..\..\..\src\QABugs\QABugs_19.cxx(5290): error C2668: 'AIS_InteractiveContext::SetSelected' : ambiguous call to overloaded function
...

1>..\..\..\src\QABugs\QABugs_19.cxx(5290): error C2668: 'AIS_InteractiveContext::SetSelected' : ambiguous call to overloaded function
....
05Commenter 5
Dear vpa,
Branch [archived branch] has been rejected due to:
- compilation errors
06Commenter 2
Branch [archived branch] has been updated forcibly by Participant.

[revision removed]
07Commenter 7
Dear Bugmaster,

please test updated patch in branch CR27893.
08Commenter 8
Dear BugMaster,
Branch CR27893 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]

Number of compiler warnings:

occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)

products component :
Linux: 64 (64 on master)
Windows: 0 (0 on master)
MacOS : 1144

Regressions/Differences/Improvements:
No regressions/differences

Testing cases:
http://occt-tests/CR27893-master-OCCT/Debian70-64/bugs/vis/bug27893.html
http://occt-tests/CR27893-master-OCCT/Windows-64-VC10/bugs/vis/bug27893.html
bugs vis bug27893: OK

Testing on Linux:
occt component :
Total MEMORY difference: 91002176 / 90234529 [+0.85%]
Total CPU difference: 19421.73999999987 / 19251.709999999875 [+0.88%]
products component :
Total MEMORY difference: 30039679 / 30046985 [-0.02%]
Total CPU difference: 5131.029999999967 / 5151.099999999975 [-0.39%]

Testing on Windows:
occt component :
Total MEMORY difference: 57214174 / 57221541 [-0.01%]
Total CPU difference: 18318.46422529868 / 18310.78897609872 [+0.04%]
products component :
Total MEMORY difference: 21271108 / 21235672 [+0.17%]
Total CPU difference: 4900.381412499953 / 4988.631178199945 [-1.77%]

There are no differences in images found by testdiff.
09Commenter 9
Dear BugMaster,
Branch CR27893 is TESTED.
10Commenter 2
Branch [archived branch] has been deleted by Commenter 1.

[revision removed]