Archived issue #0027952
Visualization - do not reset RayTracing state on changing structures not in main Z-Layer
Description
Current implementation reevaluates structure list on removing raytraceable structures from OpenGl_LayerList.
This invalidation is performed without check in which Z-Layer modification occurs, which results in redundant update, since only Graphic3d_ZLayerId_Default is actually handled by Ray-Tracing engine.
This invalidation is performed without check in which Z-Layer modification occurs, which results in redundant update, since only Graphic3d_ZLayerId_Default is actually handled by Ray-Tracing engine.
Steps to reproduce
source $env(CSF_OCCTSamplesPath)/tcl/pathtrace.tcl vremove c vdisplay c -layer -2 vfps verase c # bug - ray-tracing is invalidated
Public activity
6 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Tue Oct 11 22:55:25 2016 +0300
0027952: Visualization - do not reset RayTracing state on changing structures not in main Z-Layer
[revision removed]
Detailed log of new commits:
Author: Author
Date: Tue Oct 11 22:55:25 2016 +0300
0027952: Visualization - do not reset RayTracing state on changing structures not in main Z-Layer
Patch is ready for review (test case is not needed).
Branch CR27952 reviewed without remarks, ready for testing.
Dear BugMaster,
Branch CR27952 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)
products component :
Linux: 64 (64 on master)
Windows: 0 (0 on master)
MacOS : 1137
Regressions/Differences/Improvements:
No regressions/differences
Testing cases:
Not needed
Testing on Linux:
occt component :
Total MEMORY difference: 90742601 / 91119147 [-0.41%]
Total CPU difference: 19379.71999999993 / 19440.02000000002 [-0.31%]
products component :
Total MEMORY difference: 30068015 / 30010749 [+0.19%]
Total CPU difference: 5222.379999999984 / 5239.169999999957 [-0.32%]
Testing on Windows:
occt component :
Total MEMORY difference: 57231146 / 57241724 [-0.02%]
Total CPU difference: 19136.221467298616 / 18173.586096598698 [+5.30%]
products component :
Total MEMORY difference: 21277716 / 21240754 [+0.17%]
Total CPU difference: 5460.924205699973 / 5008.287304199943 [+9.04%]
There are no differences in images found by testdiff.
Branch CR27952 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)
products component :
Linux: 64 (64 on master)
Windows: 0 (0 on master)
MacOS : 1137
Regressions/Differences/Improvements:
No regressions/differences
Testing cases:
Not needed
Testing on Linux:
occt component :
Total MEMORY difference: 90742601 / 91119147 [-0.41%]
Total CPU difference: 19379.71999999993 / 19440.02000000002 [-0.31%]
products component :
Total MEMORY difference: 30068015 / 30010749 [+0.19%]
Total CPU difference: 5222.379999999984 / 5239.169999999957 [-0.32%]
Testing on Windows:
occt component :
Total MEMORY difference: 57231146 / 57241724 [-0.02%]
Total CPU difference: 19136.221467298616 / 18173.586096598698 [+5.30%]
products component :
Total MEMORY difference: 21277716 / 21240754 [+0.17%]
Total CPU difference: 5460.924205699973 / 5008.287304199943 [+9.04%]
There are no differences in images found by testdiff.
Dear BugMaster,
Branch CR27952 is TESTED.
Branch CR27952 is TESTED.
Branch [archived branch] has been deleted by Author.
[revision removed]
[revision removed]