Archived issue #0028095
Draw Harness, ViewerTest - use RGBA format instead of BGRA within vreadpixel
Description
OpenGL ES has GL_EXT_texture_format_BGRA8888 extension defining BGRA texture format but there are no extensions for glReadPixels()!
Command vreadpixel erroneously uses unsupported format leading to failures within OpenGL ES renderer.
Command vreadpixel erroneously uses unsupported format leading to failures within OpenGL ES renderer.
Steps to reproduce
N/A
Public activity
9 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Sat Nov 12 16:51:20 2016 +0300
0028095: Draw Harness, ViewerTest - use RGBA format instead of BGRA within vreadpixel
OpenGl_Workspace::BufferDump() now implicitly converts RGBA dump
into requested BGR, BGRA and RGB image.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Sat Nov 12 16:51:20 2016 +0300
0028095: Draw Harness, ViewerTest - use RGBA format instead of BGRA within vreadpixel
OpenGl_Workspace::BufferDump() now implicitly converts RGBA dump
into requested BGR, BGRA and RGB image.
Patch is ready for review.
Branch [archived branch] has been updated by Participant.
[revision removed]
Detailed log of new commits:
Author: abv
Date: Sun Nov 13 20:42:53 2016 +0300
DRAW command dversion is improved to report OpenGL variant used (desktop or ES); reporting of version of MSVC is corrected for VC14 and above; reporting of HAVE_OPENCL option is removed.
Usage of command vdump is corrected in some tests to specify extension .png for an image file.
Compiler warning is eliminated in OpenGl_Text.cxx (OpenGL ES mode only).
[revision removed]
Detailed log of new commits:
Author: abv
Date: Sun Nov 13 20:42:53 2016 +0300
DRAW command dversion is improved to report OpenGL variant used (desktop or ES); reporting of version of MSVC is corrected for VC14 and above; reporting of HAVE_OPENCL option is removed.
Usage of command vdump is corrected in some tests to specify extension .png for an image file.
Compiler warning is eliminated in OpenGl_Text.cxx (OpenGL ES mode only).
Branch [archived branch] has been updated forcibly by Author.
[revision removed]
[revision removed]
I confirm that this fix resolves problems on ~ 280 test cases when running on Windows with ANGLE
Branch CR28095 reviewed without remarks, ready for testing.
Dear Commenter 2,
Branch CR28095 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)
products component :
Linux: 63 (63 on master)
Windows: 0 (0 on master)
MacOS : 1125
Regressions/Differences/Improvements:
No regressions/differences
Testing cases:
Not needed
Testing on Linux:
occt component :
Total MEMORY difference: 91550787 / 91876668 [-0.35%]
Total CPU difference: 21674.74000000023 / 21600.690000000308 [+0.34%]
products component :
Total MEMORY difference: 29925013 / 29934528 [-0.03%]
Total CPU difference: 5318.629999999979 / 5309.129999999963 [+0.18%]
Testing on Windows:
occt component :
Total MEMORY difference: 56588716 / 56597852 [-0.02%]
Total CPU difference: 20301.112134498435 / 19669.510885798518 [+3.21%]
products component :
Total MEMORY difference: 20822560 / 20790286 [+0.16%]
Total CPU difference: 5307.6064228999685 / 5153.477434899959 [+2.99%]
There are no differences in images found by testdiff.
Branch CR28095 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)
products component :
Linux: 63 (63 on master)
Windows: 0 (0 on master)
MacOS : 1125
Regressions/Differences/Improvements:
No regressions/differences
Testing cases:
Not needed
Testing on Linux:
occt component :
Total MEMORY difference: 91550787 / 91876668 [-0.35%]
Total CPU difference: 21674.74000000023 / 21600.690000000308 [+0.34%]
products component :
Total MEMORY difference: 29925013 / 29934528 [-0.03%]
Total CPU difference: 5318.629999999979 / 5309.129999999963 [+0.18%]
Testing on Windows:
occt component :
Total MEMORY difference: 56588716 / 56597852 [-0.02%]
Total CPU difference: 20301.112134498435 / 19669.510885798518 [+3.21%]
products component :
Total MEMORY difference: 20822560 / 20790286 [+0.16%]
Total CPU difference: 5307.6064228999685 / 5153.477434899959 [+2.99%]
There are no differences in images found by testdiff.
Dear Commenter 2,
Branch CR28095 is TESTED.
Branch CR28095 is TESTED.
Branch [archived branch] has been deleted by Author.
[revision removed]
[revision removed]
Related records