Archived issue #0028103
Foundation Classes - extend NCollection_Map to check whether two given maps are intersected
Description
Extend type 'NCollection_Map' by method 'IsIntersection' to check whether two given maps are intersected.
Steps to reproduce
test collections n map
Public activity
16 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Mon Nov 14 18:08:44 2016 +0300
28103: Extend type 'NCollection_Map' to check whether two given maps are intersected
Mehtod 'IsIntersection' was created to check whether two given 'NCollection_Map' maps are intersected.
'Draw' command and test to check the method were created.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Mon Nov 14 18:08:44 2016 +0300
28103: Extend type 'NCollection_Map' to check whether two given maps are intersected
Mehtod 'IsIntersection' was created to check whether two given 'NCollection_Map' maps are intersected.
'Draw' command and test to check the method were created.
The method was created.
Please review.
Please review.
Branch [archived branch] has been updated forcibly by Author.
[revision removed]
[revision removed]
Reviewed.
Dear BugMaster,
Branch CR28103 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)
products component :
Linux: 63 (63 on master)
Windows: 0 (0 on master)
MacOS : 1123
Regressions/Differences/Improvements:
No regressions/differences
Testing cases:
http://occt-tests/CR28103-master-OCCT/Debian70-64/collections/n/map.html
http://occt-tests/CR28103-master-OCCT/Windows-64-VC10/collections/n/map.html
collections n map: OK
Testing on Linux:
occt component :
Total MEMORY difference: 90911185 / 91880280 [-1.05%]
Total CPU difference: 21718.740000000158 / 21600.70000000031 [+0.55%]
products component :
Total MEMORY difference: 29967472 / 29935586 [+0.11%]
Total CPU difference: 5305.989999999976 / 5309.249999999963 [-0.06%]
Testing on Windows:
occt component :
Total MEMORY difference: 56587780 / 56597852 [-0.02%]
Total CPU difference: 20137.57628619847 / 19669.510885798518 [+2.38%]
products component :
Total MEMORY difference: 20822543 / 20790286 [+0.16%]
Total CPU difference: 5280.633849999977 / 5153.477434899959 [+2.47%]
There are no differences in images found by testdiff.
Branch CR28103 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)
products component :
Linux: 63 (63 on master)
Windows: 0 (0 on master)
MacOS : 1123
Regressions/Differences/Improvements:
No regressions/differences
Testing cases:
http://occt-tests/CR28103-master-OCCT/Debian70-64/collections/n/map.html
http://occt-tests/CR28103-master-OCCT/Windows-64-VC10/collections/n/map.html
collections n map: OK
Testing on Linux:
occt component :
Total MEMORY difference: 90911185 / 91880280 [-1.05%]
Total CPU difference: 21718.740000000158 / 21600.70000000031 [+0.55%]
products component :
Total MEMORY difference: 29967472 / 29935586 [+0.11%]
Total CPU difference: 5305.989999999976 / 5309.249999999963 [-0.06%]
Testing on Windows:
occt component :
Total MEMORY difference: 56587780 / 56597852 [-0.02%]
Total CPU difference: 20137.57628619847 / 19669.510885798518 [+2.38%]
products component :
Total MEMORY difference: 20822543 / 20790286 [+0.16%]
Total CPU difference: 5280.633849999977 / 5153.477434899959 [+2.47%]
There are no differences in images found by testdiff.
Branch [archived branch] has been updated by Participant.
[revision removed]
Detailed log of new commits:
Author: mkv
Date: Tue Nov 15 15:50:46 2016 +0300
Small correction of test case for issue CR28103
[revision removed]
Detailed log of new commits:
Author: mkv
Date: Tue Nov 15 15:50:46 2016 +0300
Small correction of test case for issue CR28103
Dear BugMaster,
Branch CR28103 is TESTED.
Branch CR28103 is TESTED.
Alexander, Mikhail: can you explain why the new method is called "IsIntersection" and not "HasIntersection"?
I agree that HasIntersection is better.
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Mon Nov 14 18:08:44 2016 +0300
28103: Extend type 'NCollection_Map' to check whether two given maps are intersected
Mehtod HasIntersection added in NCollection_Map to check whether two given maps contain at least one same item.
'Draw' command and test to check the method were created.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Mon Nov 14 18:08:44 2016 +0300
28103: Extend type 'NCollection_Map' to check whether two given maps are intersected
Mehtod HasIntersection added in NCollection_Map to check whether two given maps contain at least one same item.
'Draw' command and test to check the method were created.
Please integrate branch CR28103_1: it is the same as CR28103, just the new method is renamed to "HasIntersection"
There is new warning on vc14 (win32 and win64):
QANCollection_Test.cxx:345, MSBuild, Priority: Normal
declaration of 'aM2' hides previous local declaration
QANCollection_Test.cxx:345, MSBuild, Priority: Normal
declaration of 'aM2' hides previous local declaration
Branch [archived branch] has been updated forcibly by Author.
[revision removed]
[revision removed]
The warning was fixed.
Please integrate branch CR28103_1.
Please integrate branch CR28103_1.
Branch [archived branch] has been deleted by Commenter 3.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Commenter 3.
[revision removed]
[revision removed]