Archived issue #0028110
Configuration - specify Unicode charset instead of multibyte in project files for Visual Studio
Description
OCCT is already using explicitly Unicode (wide-char) API in most places on Windows and MFC samples are build with Unicode charset. However, project files for OCCT itself are still generated with obsolete multibyte charset flag (both CMake and genproj).
The charset in project files should be changed to Unicode and remaining places relying on UNICODE macros in OCCT should be replaced by usage of wide-char API explicitly (thus technically OCCT should be build in the same way irrelevant to charset options in project settings).
The charset in project files should be changed to Unicode and remaining places relying on UNICODE macros in OCCT should be replaced by usage of wide-char API explicitly (thus technically OCCT should be build in the same way irrelevant to charset options in project settings).
Steps to reproduce
• Generate Visual Studio project via CMake / genproj
• Check that Character set of projects is Unicode
• Build solution
• Check that Character set of projects is Unicode
• Build solution
Public activity
25 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Mon Nov 14 14:31:00 2016 +0300
0028110: Configuration - specify Unicode charset instead of multibyte in project files for Visual Studio
Eliminated usage of ANSI methods.
All Visual Studio projects generated by genproj or CMake use Unicode character set.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Mon Nov 14 14:31:00 2016 +0300
0028110: Configuration - specify Unicode charset instead of multibyte in project files for Visual Studio
Eliminated usage of ANSI methods.
All Visual Studio projects generated by genproj or CMake use Unicode character set.
Dear abv,
branch CR28110 contains changed to generate Unicode projects for Visual Studio,
it is possible now to build occt using both Multibyte and Unicode character sets.
Please review.
branch CR28110 contains changed to generate Unicode projects for Visual Studio,
it is possible now to build occt using both Multibyte and Unicode character sets.
Please review.
Branch [archived branch] has been updated forcibly by Commenter 4.
[revision removed]
[revision removed]
Branch [archived branch] has been updated by Commenter 4.
[revision removed]
Detailed log of new commits:
Author: Commenter 4
Date: Sat Dec 10 00:44:16 2016 +0300
corrections
[revision removed]
Detailed log of new commits:
Author: Commenter 4
Date: Sat Dec 10 00:44:16 2016 +0300
corrections
Branch [archived branch] has been updated by Commenter 4.
[revision removed]
Detailed log of new commits:
Author: Commenter 4
Date: Sat Dec 10 03:47:59 2016 +0300
Draw Harness now handles Unicode input on Windows.
Tcl test scripts are now expected in UTF-8 encoding by default.
[revision removed]
Detailed log of new commits:
Author: Commenter 4
Date: Sat Dec 10 03:47:59 2016 +0300
Draw Harness now handles Unicode input on Windows.
Tcl test scripts are now expected in UTF-8 encoding by default.
Branch [archived branch] has been created by Commenter 4.
[revision removed]
Detailed log of new commits:
Author: Commenter 4
Date: Sat Dec 10 03:47:59 2016 +0300
Draw Harness now handles Unicode input on Windows.
Tcl test scripts are now expected in UTF-8 encoding by default.
Author: Author
Date: Mon Nov 14 14:31:00 2016 +0300
0028110: Configuration - specify Unicode charset instead of multibyte in project files for Visual Studio
Eliminated usage of ANSI methods.
All Visual Studio projects generated by genproj or CMake use Unicode character set.
[revision removed]
Detailed log of new commits:
Author: Commenter 4
Date: Sat Dec 10 03:47:59 2016 +0300
Draw Harness now handles Unicode input on Windows.
Tcl test scripts are now expected in UTF-8 encoding by default.
Author: Author
Date: Mon Nov 14 14:31:00 2016 +0300
0028110: Configuration - specify Unicode charset instead of multibyte in project files for Visual Studio
Eliminated usage of ANSI methods.
All Visual Studio projects generated by genproj or CMake use Unicode character set.
Updated patch is ready for review.
No remarks, please test
Why the patch is still not processed within normal queue?
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been rebased on the current master
Dear Commenter 2,
During building of branch CR28110_1 ([revision removed]) from occt git-repository (and master from products git-repository) compilation errors have been detected.
On Windows:
http://jenkins-test-05.nnov.opencascade.com/view/CR28110_1-master/job/CR28110_1-master-OCCT-Windows-64-VC10-opt-compile/2/parsed_console/
On MacOS:
http://jenkins-test-05.nnov.opencascade.com/view/CR28110_1-master/job/CR28110_1-master-OCCT-MacOS-opt-compile/2/parsed_console/
During building of branch CR28110_1 ([revision removed]) from occt git-repository (and master from products git-repository) compilation errors have been detected.
On Windows:
http://jenkins-test-05.nnov.opencascade.com/view/CR28110_1-master/job/CR28110_1-master-OCCT-Windows-64-VC10-opt-compile/2/parsed_console/
On MacOS:
http://jenkins-test-05.nnov.opencascade.com/view/CR28110_1-master/job/CR28110_1-master-OCCT-MacOS-opt-compile/2/parsed_console/
Dear Kirill,
Branch [archived branch] has been rejected due to:
- compilation errors
Branch [archived branch] has been rejected due to:
- compilation errors
Branch [archived branch] has been updated by Commenter 4.
[revision removed]
Detailed log of new commits:
Author: Commenter 4
Date: Thu Dec 22 11:52:58 2016 +0300
Correct IVtkDraw::WClass() definition and add missing TCollection_AsciiString definition.
[revision removed]
Detailed log of new commits:
Author: Commenter 4
Date: Thu Dec 22 11:52:58 2016 +0300
Correct IVtkDraw::WClass() definition and add missing TCollection_AsciiString definition.
Branch [archived branch] has been created by Commenter 4.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Mon Nov 14 14:31:00 2016 +0300
0028110: Configuration - specify Unicode charset instead of multibyte in project files for Visual Studio
Eliminated usage of ANSI methods.
All Visual Studio projects generated by genproj or CMake use Unicode character set.
Draw Harness now handles Unicode input on Windows.
Tcl test scripts are now expected in UTF-8 encoding by default.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Mon Nov 14 14:31:00 2016 +0300
0028110: Configuration - specify Unicode charset instead of multibyte in project files for Visual Studio
Eliminated usage of ANSI methods.
All Visual Studio projects generated by genproj or CMake use Unicode character set.
Draw Harness now handles Unicode input on Windows.
Tcl test scripts are now expected in UTF-8 encoding by default.
Please check updated patch in branch CR28110_2.
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been rebased on the current master
Dear Commenter 2,
Branch CR28110_2 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
[revision removed]
Number of compiler warnings:
occt component:
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MasOS: 0 (0 on master)
products component:
Linux: 63
Windows: 0
MacOS: 1132
Compilation errors have been detected during building of CSharp Products samples on Windows:
http://jenkins-test-05.nnov.opencascade.com/view/CR28110_2-master/job/CR28110_2-master-Products-Windows-64-VC10-csharp-samples/1/parsed_console/
Regressions/Differences:
Not detected
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 93444851 / 93048855 [+0.43%]
Total CPU difference: 21557.14000000025 / 21520.60000000037 [+0.17%]
Testing on Windows:
Total MEMORY difference: 58631217 / 58650770 [-0.03%]
Total CPU difference: 19384.419058298598 / 19731.318481998722 [-1.76%]
Branch CR28110_2 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
[revision removed]
Number of compiler warnings:
occt component:
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MasOS: 0 (0 on master)
products component:
Linux: 63
Windows: 0
MacOS: 1132
Compilation errors have been detected during building of CSharp Products samples on Windows:
http://jenkins-test-05.nnov.opencascade.com/view/CR28110_2-master/job/CR28110_2-master-Products-Windows-64-VC10-csharp-samples/1/parsed_console/
Regressions/Differences:
Not detected
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 93444851 / 93048855 [+0.43%]
Total CPU difference: 21557.14000000025 / 21520.60000000037 [+0.17%]
Testing on Windows:
Total MEMORY difference: 58631217 / 58650770 [-0.03%]
Total CPU difference: 19384.419058298598 / 19731.318481998722 [-1.76%]
Dear Kirill,
Branch [archived branch] has been rejected due to:
- compilation errors
Branch [archived branch] has been rejected due to:
- compilation errors
Please check compilation of modified C# sample, regression testing is not needed.
Dear Commenter 2,
Branch CR28110_2 from occt git-repository (and CR28110_2 from products git-repository) was compiled on Linux, MacOS and Windows platforms.
[revision removed]
[revision removed]
Number of compiler warnings:
occt component:
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MasOS: 0 (0 on master)
products component:
Linux: 63
Windows: 0
MacOS: 1152
Branch CR28110_2 from occt git-repository (and CR28110_2 from products git-repository) was compiled on Linux, MacOS and Windows platforms.
[revision removed]
[revision removed]
Number of compiler warnings:
occt component:
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MasOS: 0 (0 on master)
products component:
Linux: 63
Windows: 0
MacOS: 1152
Branch [archived branch] has been deleted by Commenter 4.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Commenter 4.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Commenter 4.
[revision removed]
[revision removed]
Related records
- #0024943 · related to · closedPort MFC sample to UNICODE for compatibility with VS2013
- #0029169 · parent of · closedConfiguration - fix compilation with undefined UNICODE on Windows
- #0028350 · related to · closedDraw Harness - DRAWEXE hangs up immediatly when redirecting input stream on Windows
- #0022484 · child of · closedUNICODE characters support.